feat(locale): add state and state_abbr to cz#1847
Merged
Conversation
xDivisionByZerox
added
c: feature
Member
Author
|
I was not able to find anything regarding state abbreviations. Should I simply copy the existing dataset in that case? |
xDivisionByZerox
changed the title
states to cz
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1847 +/- ##
==========================================
- Coverage 99.62% 99.62% -0.01%
==========================================
Files 2357 2357
Lines 236856 236875 +19
Branches 1229 1226 -3
==========================================
+ Hits 235974 235987 +13
- Misses 860 866 +6
Partials 22 22
|
matthewmayer
previously requested changes
Feb 16, 2023
Member
Instead of copying it you can import it and export it afterwards (with a comment why). |
xDivisionByZerox
changed the title
states to czstate and state_abbr to cz
ST-DDT
approved these changes
Feb 22, 2023
ST-DDT
added
s: accepted
matthewmayer
approved these changes
Mar 17, 2023
Shinigami92
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill the
statesdataset for the localecz.In the Czech Republic "states" are called "regions". They are not the same but serve the same purpose for our data.