You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Did we had a reason for just removing it?
What should I write in the proposed of deprecated?
Or do we just want to rename it to e.g. buzzWord?
bsAdjective should probably be merged into catchPhraseAdjective and deprecate bsBuzz should probably be called buzzWord (is that correctly written?) bsNoun should probably be merged into catchPhraseNoun and deprecated
Replace bs* with buzz* and improve JSDocs (buzz = manager language, catchPhrase = user language).
Open TODO:
improve JSDocs (buzz = manager language, catchPhrase = user language)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c: refactorPR that affects the runtime behavior, but doesn't add new features or fixes bugsdeprecationA deprecation was made in the PRp: 1-normalNothing urgents: acceptedAccepted feature / Confirmed bug
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
references #1346