fix(locale): remove invalid city patterns from pt_BR#1913
Merged
ST-DDT merged 1 commit intofaker-js:nextfrom Mar 7, 2023
Merged
fix(locale): remove invalid city patterns from pt_BR#1913ST-DDT merged 1 commit intofaker-js:nextfrom
ST-DDT merged 1 commit intofaker-js:nextfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1913 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2356 2356
Lines 236565 236563 -2
Branches 1190 1194 +4
=======================================
+ Hits 235670 235687 +17
+ Misses 873 854 -19
Partials 22 22
|
ejcheng
approved these changes
Mar 7, 2023
ST-DDT
approved these changes
Mar 7, 2023
Member
|
Should we remove the |
Member
I think the empty array here is a marker that these data are intentionally missing instead of just being missing. |
xDivisionByZerox
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is because two of the patterns for
cityreferencecity_prefix, but this is empty for pt_PThttps://github.com/faker-js/faker/blob/next/src/locales/pt_BR/location/city_prefix.ts
Removed these patterns