feat(locale): add additional metadata properties#2025
Conversation
|
i might need some assistance with the "Make MetadataDefinitions optional and Partial" part, wasn't sure how to do that. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2025 +/- ##
==========================================
- Coverage 99.61% 99.59% -0.03%
==========================================
Files 2538 2563 +25
Lines 242253 243670 +1417
Branches 1299 1278 -21
==========================================
+ Hits 241319 242672 +1353
- Misses 907 971 +64
Partials 27 27
|
ST-DDT
left a comment
There was a problem hiding this comment.
Here the suggested metadata definition type changes as requested: matthewmayer#1
…st-ddt feat(locale): add additional metadata properties
thanks for the help on this! |
ST-DDT
left a comment
There was a problem hiding this comment.
Thanks for filling in these metadata. The PR looks good to me.
I will have another look at the endonyms tomorrow just to be sure nothing slipped my checks.
Shinigami92
left a comment
There was a problem hiding this comment.
all in all looks good to me
still just some questions and suggestions
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: Shinigami <chrissi92@hotmail.de>
fix #2012