feat(locale): add minimal da locale, start with location#2324
Merged
ST-DDT merged 2 commits intofaker-js:nextfrom Aug 19, 2023
Merged
feat(locale): add minimal da locale, start with location#2324ST-DDT merged 2 commits intofaker-js:nextfrom
ST-DDT merged 2 commits intofaker-js:nextfrom
Conversation
ST-DDT
reviewed
Aug 18, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2324 +/- ##
==========================================
- Coverage 99.60% 99.59% -0.01%
==========================================
Files 2644 2660 +16
Lines 245613 246345 +732
Branches 1084 1082 -2
==========================================
+ Hits 244640 245357 +717
- Misses 946 961 +15
Partials 27 27
|
Contributor
matthewmayer
left a comment
There was a problem hiding this comment.
Should we consider making this locale da_DK as Danish is spoken in some other territories with their own ISO codes like Greenland or Faroe Islands?
Member
No, because these other territories probably share a lot of the names/values with Denmark and we shouldn't duplicate them. |
ST-DDT
approved these changes
Aug 18, 2023
Contributor
|
I'm not sure when we do lang vs lang_COUNTRY though. Eg ka_GE and sr_RS were added recently |
ejcheng
approved these changes
Aug 19, 2023
matthewmayer
approved these changes
Aug 19, 2023
Shinigami92
approved these changes
Aug 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #2321, add new language in smaller chunks.