fix(internet): username method to return value that always includes…

[amillwood]

Updated the username method to always return a value that includes the last name when provided.

Resolves #1000

[codecov]

Codecov Report

Merging #2506 (503e09e) into next (b8049d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2506   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files        2805     2805           
  Lines      250069   250088   +19     
  Branches     1097     1097           
=======================================
+ Hits       248996   249025   +29     
+ Misses       1045     1035   -10     
  Partials       28       28           

Files	Coverage Δ
src/modules/internet/index.ts	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[ST-DDT]

Sorry for the delay in review, we will look at it shortly.

[amillwood]

No worries. No rush, just a minor contribution - hope it helps

[ST-DDT]

One problem I see with the username method itself is that it produces very vage usernames that you might choose for private accounts.
But I think a lot of professional users of faker need usernames that companies would use and thus roughly follows the firstName.lastName strategy.

[matthewmayer]

Companies don't always use FirstName.lastname anyway though

At companies I have worked at there have been patterns like

john.smith@
john@
jsmith@
smithj@

[ST-DDT]

Companies don't always use FirstName.lastname anyway though

My point is that companies follow a more standardized approach to usernames than private persons do.

[matthewmayer]

I think using both FirstName and lastname when provided makes sense, but we could have more ways to combine them for greater variety eg

More separators including empty string
Surname or firstname first
Sometimes lowercase the whole string

[ST-DDT]

Team Decision

• We accept this as a fix for the problem at hand, we will rethink the username method in the future.
  • (More patterns,username modes e.g. company, private, gamer...)

[ST-DDT]

@amillwood Could you please fix the merge conflict?

[ST-DDT]

Thanks for your contribution ❤️