Skip to content

Commit 35eb6fa

Browse files
Don't add 'rdoc' as a dependency
When dependabot opened a PR to update 'rdoc' version, we got a few errors in Ruby https://github.com/faker-ruby/faker/actions/runs/20980245054/job/60303497935?pr=3178 The dependency was added in github.com//pull/3165 but that deprecation warning is not generated anymore after upgrading my local ruby version to 4.0. Removing 'rdoc' from the Gemfile does not break using faker console and I don't see the warning anymore. And since 'rdoc' is part of Ruby 3.5 by default, we don't need to list it as a dependency. For anyone using Ruby < 3.5 when opening a faker console, they can install 'rdoc' as needed locally.
1 parent 98aecf6 commit 35eb6fa

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

Gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ gem 'irb'
99
gem 'minitest', '5.27.0'
1010
gem 'pry', '0.16.0'
1111
gem 'rake', '13.3.1'
12-
gem 'rdoc'
1312
gem 'rubocop', '1.82.1'
1413
gem 'rubocop-minitest', '0.38.2'
1514
gem 'rubocop-rake', '0.7.1'

Gemfile.lock

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ DEPENDENCIES
103103
minitest (= 5.27.0)
104104
pry (= 0.16.0)
105105
rake (= 13.3.1)
106-
rdoc
107106
rubocop (= 1.82.1)
108107
rubocop-minitest (= 0.38.2)
109108
rubocop-rake (= 0.7.1)

0 commit comments

Comments
 (0)