Commit 35eb6fa
committed
Don't add 'rdoc' as a dependency
When dependabot opened a PR to update 'rdoc' version,
we got a few errors in Ruby https://github.com/faker-ruby/faker/actions/runs/20980245054/job/60303497935?pr=3178
The dependency was added in github.com//pull/3165
but that deprecation warning is not generated anymore after upgrading
my local ruby version to 4.0.
Removing 'rdoc' from the Gemfile does not break using faker
console and I don't see the warning anymore. And since 'rdoc' is part of Ruby 3.5
by default, we don't need to list it as a dependency. For anyone using Ruby < 3.5 when
opening a faker console, they can install 'rdoc' as needed locally.1 parent 98aecf6 commit 35eb6fa
2 files changed
+0
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
107 | 106 | | |
108 | 107 | | |
109 | 108 | | |
| |||
0 commit comments