Skip to content

Commit 1ca70c0

Browse files
committed
result: remove unused name parameter
1 parent 8f7752e commit 1ca70c0

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/pkgfile.cc

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,12 @@ int Pkgfile::SearchRepos(Database::RepoChunks repo_chunks,
237237

238238
ThreadSafeQueue<WorkItem> queue;
239239
for (auto& [reponame, filepath] : repo_chunks) {
240-
results.emplace(reponame, std::make_unique<Result>(reponame));
241-
queue.enqueue(
242-
WorkItem{&reponame, &filepath, &filter, results[reponame].get()});
240+
auto& result = results[reponame];
241+
if (result == nullptr) {
242+
result = std::make_unique<Result>();
243+
}
244+
245+
queue.enqueue(WorkItem{&reponame, &filepath, &filter, result.get()});
243246
}
244247

245248
const auto num_workers =

src/result.hh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace pkgfile {
88

99
class Result {
1010
public:
11-
explicit Result(std::string name) : name_(std::move(name)) {}
11+
Result() = default;
1212

1313
Result(const Result&) = delete;
1414
Result& operator=(const Result&) = delete;
@@ -29,7 +29,6 @@ class Result {
2929
};
3030

3131
std::mutex mu_;
32-
std::string name_;
3332
std::vector<Line> lines_;
3433
size_t max_prefixlen_ = 0;
3534

0 commit comments

Comments
 (0)