From a2c100f44e6463346d5133733dcab4284198acd9 Mon Sep 17 00:00:00 2001 From: didimelli Date: Mon, 12 Aug 2024 11:28:59 +0200 Subject: [PATCH 1/4] removed loop arg --- faust/transport/drivers/aiokafka.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/faust/transport/drivers/aiokafka.py b/faust/transport/drivers/aiokafka.py index 1c7c5fa13..67b7cb292 100644 --- a/faust/transport/drivers/aiokafka.py +++ b/faust/transport/drivers/aiokafka.py @@ -1242,12 +1242,9 @@ def _new_producer( self, transactional_id: Optional[str] = None ) -> aiokafka.AIOKafkaProducer: return self._producer_type( - loop=self.loop, - **{ - **self._settings_default(), - **self._settings_auth(), - **self._settings_extra(), - }, + **self._settings_default(), + **self._settings_auth(), + **self._settings_extra(), transactional_id=transactional_id, ) From de62daf5d4ed65fc3ff9a6800bc7c6095f7227c6 Mon Sep 17 00:00:00 2001 From: didimelli Date: Mon, 12 Aug 2024 16:43:17 +0200 Subject: [PATCH 2/4] restore double dict --- faust/transport/drivers/aiokafka.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/faust/transport/drivers/aiokafka.py b/faust/transport/drivers/aiokafka.py index 67b7cb292..2768bfe51 100644 --- a/faust/transport/drivers/aiokafka.py +++ b/faust/transport/drivers/aiokafka.py @@ -1242,9 +1242,11 @@ def _new_producer( self, transactional_id: Optional[str] = None ) -> aiokafka.AIOKafkaProducer: return self._producer_type( - **self._settings_default(), - **self._settings_auth(), - **self._settings_extra(), + **{ + **self._settings_default(), + **self._settings_auth(), + **self._settings_extra(), + } transactional_id=transactional_id, ) From a59bb77b50ff8174f80fbadda96fe043fec4eeda Mon Sep 17 00:00:00 2001 From: didimelli Date: Mon, 12 Aug 2024 16:43:43 +0200 Subject: [PATCH 3/4] re-add comma --- faust/transport/drivers/aiokafka.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/faust/transport/drivers/aiokafka.py b/faust/transport/drivers/aiokafka.py index 2768bfe51..e176fe3b4 100644 --- a/faust/transport/drivers/aiokafka.py +++ b/faust/transport/drivers/aiokafka.py @@ -1246,7 +1246,7 @@ def _new_producer( **self._settings_default(), **self._settings_auth(), **self._settings_extra(), - } + }, transactional_id=transactional_id, ) From ced7d5e3a58dc8c92cc2b9bf2709bf9dcfee0ac8 Mon Sep 17 00:00:00 2001 From: didimelli Date: Mon, 12 Aug 2024 17:18:22 +0200 Subject: [PATCH 4/4] tests --- tests/unit/transport/drivers/test_aiokafka.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/unit/transport/drivers/test_aiokafka.py b/tests/unit/transport/drivers/test_aiokafka.py index 04d5d910f..35fe87ba4 100644 --- a/tests/unit/transport/drivers/test_aiokafka.py +++ b/tests/unit/transport/drivers/test_aiokafka.py @@ -1391,7 +1391,6 @@ def assert_new_producer( max_request_size=max_request_size, compression_type=compression_type, security_protocol=security_protocol, - loop=producer.loop, partitioner=producer.partitioner, transactional_id=None, api_version=api_version,