Add --reverse to fedify lookup output ordering

[dahlia]

Summary

This PR adds a new --reverse option to fedify lookup so users can reverse the presentation order of emitted results without changing lookup semantics across default multi-input lookup, --traverse collection output, and --recurse chain output.

Changes

Added --reverse option parsing to the lookup command, added lookup.reverse support in the config schema, and applied reverse ordering logic to default multi-input output, recurse chain output, and traversal output.

Preserved existing behavior and failure semantics by keeping streaming traversal when --reverse is not enabled, preserving already-fetched items in --traverse --reverse when traversal fails later, and preserving root-object emission in recurse-mode failure paths after the root object has been fetched.

Updated documentation in docs/cli.md by adding a --reverse option section and adding reverse = false to the [lookup] config example, and updated changelog entries in CHANGES.md.

Tests

Added parser/config tests for --reverse, added ordering helper tests, and added async collection tests to verify partial-item preservation on iterator failure, all in packages/cli/src/lookup.test.ts.

Ran deno test --allow-all packages/cli/src/lookup.test.ts, and all tests passed.

References

Closes #607

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the fedify lookup command by introducing a --reverse option. This feature provides users with greater control over how results are displayed, allowing them to view fetched data in reverse order across various lookup modes. The implementation prioritizes maintaining existing functionality and error handling, ensuring a seamless and robust user experience while offering new flexibility in data presentation.

Highlights

• New --reverse option: Introduced a --reverse option to the fedify lookup command, allowing users to reverse the presentation order of emitted results.
• Output Ordering: The --reverse option now applies across default multi-input lookup, --traverse collection output, and --recurse chain output, affecting only presentation order without altering lookup semantics.
• Error Handling and Preservation: Existing behavior and failure semantics are preserved, including streaming traversal when --reverse is not enabled, retaining already-fetched items in --traverse when traversal fails, and preserving root-object emission in recurse-mode failure paths.
• Documentation and Changelog: Updated docs/cli.md with a new section for the --reverse option and added it to the config example. Changelog entries in CHANGES.md were also updated.
• Testing: Comprehensive tests were added for parser/config, ordering helpers, and async collection to verify partial-item preservation on iterator failure.

Changelog

• CHANGES.md
  • Added --reverse option to fedify lookup to reverse presentation order of emitted results. It now works across default multi-input lookup, --traverse collection traversal output, and --recurse object chains, while preserving existing fetch/error semantics. [[Add --reverse to fedify lookup to reverse output order in traversal/recurse modes #607], [Add --reverse to fedify lookup output ordering #609]]
  • Added references for issues Add --reverse to fedify lookup to reverse output order in traversal/recurse modes #607 and Add --reverse to fedify lookup output ordering #609.

Activity

• The author, dahlia, added parser/config tests for --reverse in packages/cli/src/lookup.test.ts.
• Ordering helper tests were added to ensure correct functionality of the new toPresentationOrder utility.
• Async collection tests were included to verify partial-item preservation on iterator failure, specifically for the collectAsyncItems utility.
• All 63 tests in packages/cli/src/lookup.test.ts passed successfully, confirming the stability and correctness of the changes.
• The pull request addresses and closes issue Add --reverse to fedify lookup to reverse output order in traversal/recurse modes #607.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a --reverse option to the fedify lookup command, allowing users to reverse the presentation order of results for multi-input lookups, collection traversals, and recursive chains. The implementation correctly handles the necessary buffering for reversal while preserving existing streaming behavior when the option is not used. The changes are well-documented and include thorough tests.

[Copilot]

Pull request overview

Adds a --reverse presentation option to fedify lookup so users can invert the output ordering of results across default multi-input lookups, --traverse collection traversal, and --recurse chain output, without changing lookup semantics.

Changes:

• Added --reverse CLI parsing + config binding (lookup.reverse) and config schema support.
• Implemented presentation-order helpers and applied reversal to recurse/traverse/default output paths.
• Updated CLI docs and changelog to document the new option.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/cli/src/lookup.ts	Adds --reverse option, introduces ordering/buffering helpers, and applies reversed presentation logic across modes.
packages/cli/src/lookup.test.ts	Adds tests for --reverse parsing/config and helper behavior (toPresentationOrder, collectAsyncItems).
packages/cli/src/config.ts	Extends lookup config schema with optional reverse boolean.
docs/cli.md	Documents --reverse and adds reverse = false to lookup config example.
CHANGES.md	Records the new --reverse option in the unreleased changelog.

Comments suppressed due to low confidence (1)

packages/cli/src/lookup.ts:1204

• The default multi-URL lookup path now always buffers into successfulObjects and prints in a second pass, even when command.reverse is false. That changes the write/error behavior vs the prior one-pass write-in-loop (e.g., write failures occur after all spinner statuses are emitted) and adds an unnecessary extra pass. Consider only buffering when command.reverse is true; otherwise keep the original one-pass write flow.

  const successfulObjects: APObject[] = [];
  for (const [i, obj] of objects.entries()) {
    const url = command.urls[i];
    if (obj == null) {
      spinner.fail(`Failed to fetch ${colors.red(url)}`);

[codecov]

Codecov Report

❌ Patch coverage is 60.61947% with 89 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
packages/cli/src/lookup.ts	60.44%	89 Missing ⚠️

Files with missing lines	Coverage Δ
packages/cli/src/config.ts	83.49% <100.00%> (+0.16%)	⬆️
packages/cli/src/lookup.ts	66.37% <60.44%> (+22.86%)	⬆️

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dahlia]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a --reverse option to the fedify lookup command, allowing users to reverse the output order of results. The feature is implemented across all relevant modes: default multi-input, collection traversal (--traverse), and recursive chain lookup (--recurse). The implementation correctly handles buffering when necessary (for traversal and multi-input modes) while preserving existing streaming behavior and failure semantics. The changes are well-tested, with new unit and integration tests covering the reverse ordering logic and error handling. Documentation and changelog have also been updated accordingly. The implementation appears solid and well-executed.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

[dahlia]

/gemini review

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

[gemini-code-assist]

Code Review

This pull request introduces a --reverse option to the fedify lookup command, allowing users to reverse the output order for various lookup modes. However, it introduces a potential memory exhaustion vulnerability when used with the --traverse option, as the tool buffers the entire collection in memory, which can lead to crashes with large ActivityPub collections.

[dahlia]

/gemini review

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

[gemini-code-assist]

Code Review

This pull request introduces a --reverse option to the fedify lookup command, allowing users to reverse the output order of results. The changes are well-implemented across the default, traverse, and recurse modes, with thoughtful consideration for failure semantics to preserve partial results. The documentation and tests have been updated accordingly, making this a solid feature addition. I have one minor suggestion to improve the consistency of a helper function.

[dahlia]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a --reverse option to the fedify lookup command, enabling users to reverse the output order of results. The implementation correctly handles this for default, traverse, and recurse modes, preserving streaming for non-reversed cases while buffering for reversed ones. The changes are well-documented and thoroughly tested.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

[dahlia]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a --reverse option to the fedify lookup command, allowing users to reverse the output order of results. The implementation correctly handles this for default multi-URL lookups, recursive lookups, and collection traversals. The changes also include updates to documentation, configuration, and comprehensive tests for the new functionality.

I've found one issue in the implementation for collection traversal (--traverse) where the logic for printing separators between items has a regression. This affects both normal and reversed traversal modes. My review includes a detailed comment and a code suggestion to fix this, aligning with the rule on managing state for independent processing chains.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

[dahlia]

/gemini review

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

[gemini-code-assist]

Code Review

This pull request introduces a --reverse option to the fedify lookup command, allowing users to reverse the output order of results. The implementation correctly handles this new option across default, traverse, and recurse modes, including failure scenarios. The changes are well-tested and include necessary documentation updates. I have one suggestion to improve the readability of the recursive lookup logic.

[dahlia]

/gemini review

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

[gemini-code-assist]

Code Review

This pull request introduces a --reverse option to the fedify lookup command, allowing users to reverse the output order of results. The changes are well-implemented across default, traverse, and recurse modes, with thorough test coverage for the new functionality and its edge cases. The documentation has also been updated accordingly. I have one suggestion to improve the readability of the new logic in runLookup.

[dahlia]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a --reverse option to the fedify lookup command, allowing users to reverse the output order of results. A security audit found no vulnerabilities meeting the severity threshold. The implementation is well-tested and documented.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.