Fix bug due to mutating table while iterating

Author: fewkz

README.md

@@ -7,7 +7,7 @@ You can download the latest release of froact as a rbxm file from https://github
 
 Froact can be added to your project via [Wally](https://wally.run/) by adding this line under dependencies.
 ```toml
-froact = "fewkz/froact@0.1.1"
+froact = "fewkz/froact@0.1.3"
 ```
 
 ## How to use

froactful.lua

@@ -197,17 +197,21 @@ function froact.configure<Hooks>(config: {
 		if config.defaultProperties then config.defaultProperties else {}
 	)
 	local function apply(props: any)
+		local toRemove = {}
 		for name, value in props do
 			if typeof(name) == "string" then
 				if name:sub(1, 2) == "on" then
 					props[(config.Roact.Event :: any)[name:sub(3)]] = value
-					props[name] = nil
+					toRemove[name] = true
 				elseif name:sub(1, 4) == "bind" then
 					props[(config.Roact.Change :: any)[name:sub(5)]] = value
-					props[name] = nil
+					toRemove[name] = true
 				end
 			end
 		end
+		for name, _ in toRemove do
+			props[name] = nil
+		end
 		if props.ref then
 			props[config.Roact.Ref] = props.ref
 			props.ref = nil

generate.py

@@ -492,17 +492,21 @@ def count_references(klass):
 body_lines.append(
     """\
 \tlocal function apply(props: any)
+\t\tlocal toRemove = {}
 \t\tfor name, value in props do
 \t\t\tif typeof(name) == "string" then
 \t\t\t\tif name:sub(1, 2) == "on" then
 \t\t\t\t\tprops[(config.Roact.Event :: any)[name:sub(3)]] = value
-\t\t\t\t\tprops[name] = nil
+\t\t\t\t\ttoRemove[name] = true
 \t\t\t\telseif name:sub(1, 4) == "bind" then
 \t\t\t\t\tprops[(config.Roact.Change :: any)[name:sub(5)]] = value
-\t\t\t\t\tprops[name] = nil
+\t\t\t\t\ttoRemove[name] = true
 \t\t\t\tend
 \t\t\tend
 \t\tend
+\t\tfor name, _ in toRemove do
+\t\t\tprops[name] = nil
+\t\tend
 \t\tif props.ref then
 \t\t\tprops[config.Roact.Ref] = props.ref
 \t\t\tprops.ref = nil

wally.toml

@@ -1,7 +1,7 @@
 [package]
 name = "fewkz/froact"
 description = " Wrapper around Roact & Roact Hooks to simplify UI development"
-version = "0.1.1"
+version = "0.1.3"
 license = "MIT"
 registry = "https://github.com/UpliftGames/wally-index"
 realm = "shared"