fix: connect unit tests to actual source code#33
Open
ArmaanjeetSandhu wants to merge 1 commit into
Open
Conversation
Previously, `tests/unit/freeUrl.test.js` contained a hardcoded copy of the `freeUrl` function. This meant that changes to the actual extension logic in `content.js` were not being verified, leading to potential false positives. This commit: - Modifies `extension/content.js` to conditionally export `freeUrl` for Node.js environments - Wraps the DOM event listeners in `content.js` to prevent execution during testing - Updates `tests/unit/freeUrl.test.js` to import the function directly from the source
VitoriaSouzaTec
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
tests/unit/freeUrl.test.jscontained a hardcoded copy of thefreeUrlfunction. This meant that changes to the actual extension logic incontent.jswere not being verified, leading to potential false positives.This commit:
extension/content.jsto conditionally exportfreeUrlfor Node.js environmentscontent.jsto prevent execution during testingtests/unit/freeUrl.test.jsto import the function directly from the source