Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: fhs/pyhdf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.11.3
Choose a base ref
...
head repository: fhs/pyhdf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 19 commits
  • 14 files changed
  • 6 contributors

Commits on Jun 25, 2023

  1. Configuration menu
    Copy the full SHA
    67beb1c View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Fix reads of 8-bit signed char SDSs (#68)

    This fixes an issue encountered after a recent upgrade from pyhdf 0.10.5 to 0.11.3. When reading an SDS of type `SDC.CHAR` with version 0.11.3, I'd get the following error:
    ```
    In [2]: SD("MYD03.A2023213.0000.061.2023213152719.hdf").select("Scan Type").get()
    ---------------------------------------------------------------------------
    ValueError                                Traceback (most recent call last)
    Cell In[2], line 1
    ----> 1 SD("MYD03.A2023213.0000.061.2023213152719.hdf").select("Scan Type").get()
    
    File ~/Code/pyhdf/pyhdf/SD.py:1920, in SDS.get(self, start, count, stride)
       1916 if not data_type in SDC.equivNumericTypes:
       1917     raise HDF4Error('get cannot currently deal with '\
       1918                      'the SDS data type')
    -> 1920 return _C._SDreaddata_0(self._id, data_type, start, count, stride)
    
    File ~/Code/pyhdf/pyhdf/hdfext.py:333, in _SDreaddata_0(sds_id, data_type, start, edges, stride)
        332 def _SDreaddata_0(sds_id, data_type, start, edges, stride):
    --> 333     return _hdfext._SDreaddata_0(sds_id, data_type, start, edges, stride)
    
    ValueError: data type must provide an itemsize
    ```
    I tracked the problem down to use of `PyArray_SimpleNew` with typenum `NPY_STRING`, which fails because that type code requires a size specification. This change instead uses `PyArray_New` with an `itemsize` of 1, which reproduces the 0.10.5 `SDC.CHAR` read behavior. All the non-`NPY_STRING` type codes are fixed-size in which case `PyArray_New` ignores the `itemsize` argument so behavior for these type codes should be unaffected.
    
    Fixes #67 
    ---------
    
    Co-authored-by: Greg Quinn <greg.quinn@ssec.wisc.edu>
    greg9q and greg9q authored Aug 12, 2023
    Configuration menu
    Copy the full SHA
    e8f87ad View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Check Multi-Arch path to fix build on Debian. (#71)

    The Debian package failed to build as reported in [Debian Bug #1066395](https://bugs.debian.org/1066395).
    
    This is fixed by also searching the [MultiArch](https://wiki.debian.org/Python/MultiArch#Python_code) path for the hdf4alt libraries.
    sebastic authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f508ec8 View commit details
    Browse the repository at this point in the history
  2. Bump version to 0.11.4

    fhs committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    e26afc7 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Include hdf.h instead of hdfi.h removed in 4.3.0. (#72)

    As reported in #70, hdfi.h has been removed in HDF 4.3.0 which causes build failures.
    
    Replacing the the include with hdf.h resolves this.
    
    Closes: #70
    sebastic authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7746b03 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. codespell with 2.2.6 (#74)

    schwehr authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5dab15c View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2025

  1. Configuration menu
    Copy the full SHA
    79be7e5 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2025

  1. Configuration menu
    Copy the full SHA
    c452b29 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c048200 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cb447e4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2107fb7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9f5e0b0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8ae76ad View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    18b45ff View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c704d58 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    82bb6bc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6de48b3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8d1a8ca View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    12376cf View commit details
    Browse the repository at this point in the history
Loading