Skip to content

Log console link again after running tests with apptesting:execute#10060

Merged
lfkellogg merged 2 commits into
mainfrom
lk/log
Mar 11, 2026
Merged

Log console link again after running tests with apptesting:execute#10060
lfkellogg merged 2 commits into
mainfrom
lk/log

Conversation

@lfkellogg
Copy link
Copy Markdown
Contributor

@lfkellogg lfkellogg commented Mar 10, 2026

It's printed once along with the other links when uploading the binary. But after running tests we'll show it again because it's the most important one, and they'll always want to follow it to see how the test does:

...
✔ Test execution requested

=== Running 1 test
View progress and results in the Firebase Console:
https://console.firebase.google.com/project/project-id/appdistribution/app/android:com.example/releases/1234567?utm_source=firebase-tools

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user experience for the apptesting:execute command by ensuring that the crucial Firebase Console link is re-logged after automated tests are completed. This change is implemented by modifying the upload utility to return a more complete Release object, which then allows the command to access and display the console URI at the most relevant point in the workflow, facilitating quick access to test results.

Highlights

  • Enhanced upload function return type: The upload function in src/appdistribution/distribution.ts now returns the full Release object instead of just the release name (string), providing more comprehensive release information.
  • Improved apptesting:execute command output: The apptesting:execute command now explicitly logs the Firebase Console link after automated tests have been run, making it easier for users to find test results.
  • Refactored command and tool integrations: All relevant commands and tools (appdistribution-distribute, apptesting, mcp/tools/apptesting/tests) have been updated to correctly handle and utilize the new Release object returned by the upload function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/appdistribution/distribution.ts
    • Updated the upload function's return type from Promise<string> to Promise<Release>.
    • Modified the upload function to return the complete Release object.
  • src/commands/appdistribution-distribute.ts
    • Adapted the distribute function to receive and use the Release object from the upload function.
    • Updated calls to updateReleaseNotes, distribute, and createReleaseTest to correctly reference release.name.
  • src/commands/apptesting.ts
    • Updated the apptesting:execute command to process the Release object returned by upload.
    • Added a new log message to display the Firebase Console link after test execution.
    • Refactored the invokeTests function to return Promise<ReleaseTest[]> and use release.name for test creation.
  • src/mcp/tools/apptesting/tests.ts
    • Modified the run_tests tool to correctly handle the Release object returned by the upload function.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the upload function to return the full Release object, which is then used to log the Firebase Console URL after executing tests, improving usability. However, it introduces several security concerns. The newly added MCP tool lacks proper validation for file paths and application IDs, potentially leading to path traversal and arbitrary file read vulnerabilities. Furthermore, the use of marked() on untrusted API data in the apptesting:execute command poses a potential Cross-Site Scripting (XSS) risk if rendered in a webview context. There is also a minor suggestion regarding the formatting of the logged URL.

Comment thread src/mcp/tools/apptesting/tests.ts
Comment thread src/commands/apptesting.ts
Comment thread src/mcp/tools/apptesting/tests.ts
@lfkellogg lfkellogg enabled auto-merge (squash) March 11, 2026 15:00
@lfkellogg lfkellogg merged commit 40d8588 into main Mar 11, 2026
58 of 60 checks passed
@lfkellogg lfkellogg deleted the lk/log branch March 11, 2026 15:20
andrewbrook pushed a commit that referenced this pull request Mar 25, 2026
…10060)

* Log console link again after running tests

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants