Skip to content

Additional notices for firebase-tools#10129

Merged
joehan merged 1 commit into
mainfrom
toolsNotice
Mar 18, 2026
Merged

Additional notices for firebase-tools#10129
joehan merged 1 commit into
mainfrom
toolsNotice

Conversation

@christhompsongoogle
Copy link
Copy Markdown
Contributor

Additional notices for firebase-tools

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances user guidance by clearly directing users to the appropriate channel for reporting bugs related to Firebase Studio migration and exports. By prominently displaying a link to the firebase-tools GitHub issues, it streamlines the process for users encountering issues and assists maintainers in efficiently tracking and resolving problems.

Highlights

  • Bug Reporting: Added a notice to direct users to file bugs at the firebase/firebase-tools GitHub issues page during Firebase Studio to Antigravity migration and within the exported readme_template.md.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a notice for users to file bugs. The notice is added to the console output of the firebase studio:migrate command and to the README.md file generated by it.

My review identifies one point of improvement: the notice in the console output is redundant as it's shown both at the beginning and at the end of the process. I've suggested removing the initial notice.

void track.trackGA4("firebase_studio_migrate", { app_type: appType, result: "started" });

logger.info("🚀 Starting Firebase Studio to Antigravity migration...");
logger.info("\nFile any bugs at https://github.com/firebase/firebase-tools/issues");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This message is already displayed at the end of the migration process within the askToOpenAntigravity function (see line 749). Displaying it here at the start is redundant and should be removed to avoid duplicate messages in the command's output.

@joehan joehan merged commit 49ccb6a into main Mar 18, 2026
47 checks passed
@joehan joehan deleted the toolsNotice branch March 18, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants