From cc2a83a33439a6c35a7356629ee572fe010f134d Mon Sep 17 00:00:00 2001 From: Arthur Thompson Date: Fri, 8 Nov 2019 14:22:55 -0800 Subject: [PATCH 1/5] Remove @visibleForTesting from FirebaseApp constructor --- packages/firebase_core/lib/src/firebase_app.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/firebase_core/lib/src/firebase_app.dart b/packages/firebase_core/lib/src/firebase_app.dart index f5b5069f8aec..fb82f56ef869 100644 --- a/packages/firebase_core/lib/src/firebase_app.dart +++ b/packages/firebase_core/lib/src/firebase_app.dart @@ -5,7 +5,6 @@ part of firebase_core; class FirebaseApp { - @visibleForTesting const FirebaseApp({@required this.name}) : assert(name != null); /// The name of this app. From ca0a81720b323bc767de4812e7b85c8632862acd Mon Sep 17 00:00:00 2001 From: Arthur Thompson Date: Fri, 8 Nov 2019 15:19:51 -0800 Subject: [PATCH 2/5] Add todo for tracking apps --- packages/firebase_core/lib/src/firebase_app.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/firebase_core/lib/src/firebase_app.dart b/packages/firebase_core/lib/src/firebase_app.dart index fb82f56ef869..1fbd05629426 100644 --- a/packages/firebase_core/lib/src/firebase_app.dart +++ b/packages/firebase_core/lib/src/firebase_app.dart @@ -5,7 +5,9 @@ part of firebase_core; class FirebaseApp { - const FirebaseApp({@required this.name}) : assert(name != null); + // TODO(kroikie): Track and assert configured apps and those retrieved via + // appNamed. + FirebaseApp({@required this.name}) : assert(name != null); /// The name of this app. final String name; From 90241d62727778493aee5a7d665a72f0cd457395 Mon Sep 17 00:00:00 2001 From: Arthur Thompson Date: Fri, 8 Nov 2019 15:34:30 -0800 Subject: [PATCH 3/5] fix tests --- packages/firebase_core/test/firebase_core_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase_core/test/firebase_core_test.dart b/packages/firebase_core/test/firebase_core_test.dart index 772b876fc37c..7c9effadc4f4 100755 --- a/packages/firebase_core/test/firebase_core_test.dart +++ b/packages/firebase_core/test/firebase_core_test.dart @@ -11,7 +11,7 @@ void main() { group('$FirebaseApp', () { final List log = []; - const FirebaseApp testApp = FirebaseApp( + final FirebaseApp testApp = FirebaseApp( name: 'testApp', ); const FirebaseOptions testOptions = FirebaseOptions( From c19b0e7ed30a3b9480eafe2073bd3c3d22199c0c Mon Sep 17 00:00:00 2001 From: Arthur Thompson Date: Fri, 8 Nov 2019 16:05:54 -0800 Subject: [PATCH 4/5] Update packages/firebase_core/lib/src/firebase_app.dart Co-Authored-By: Collin Jackson --- packages/firebase_core/lib/src/firebase_app.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase_core/lib/src/firebase_app.dart b/packages/firebase_core/lib/src/firebase_app.dart index 1fbd05629426..818522214ad9 100644 --- a/packages/firebase_core/lib/src/firebase_app.dart +++ b/packages/firebase_core/lib/src/firebase_app.dart @@ -5,7 +5,7 @@ part of firebase_core; class FirebaseApp { - // TODO(kroikie): Track and assert configured apps and those retrieved via + // TODO(jackson): We could assert here that an app with this name was configured previously. // appNamed. FirebaseApp({@required this.name}) : assert(name != null); From 8e9c0c552effbc3d221dfa5f179aa9fdc0aa3af9 Mon Sep 17 00:00:00 2001 From: Arthur Thompson Date: Fri, 8 Nov 2019 16:06:06 -0800 Subject: [PATCH 5/5] Update packages/firebase_core/lib/src/firebase_app.dart Co-Authored-By: Collin Jackson --- packages/firebase_core/lib/src/firebase_app.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/firebase_core/lib/src/firebase_app.dart b/packages/firebase_core/lib/src/firebase_app.dart index 818522214ad9..7c0bec0e0dda 100644 --- a/packages/firebase_core/lib/src/firebase_app.dart +++ b/packages/firebase_core/lib/src/firebase_app.dart @@ -6,7 +6,6 @@ part of firebase_core; class FirebaseApp { // TODO(jackson): We could assert here that an app with this name was configured previously. - // appNamed. FirebaseApp({@required this.name}) : assert(name != null); /// The name of this app.