From 443b0140b56e3bc26fb2b6b01626cc82294c97bb Mon Sep 17 00:00:00 2001 From: Arthur Thompson Date: Tue, 12 Nov 2019 14:52:12 -0800 Subject: [PATCH 1/3] Remove deprecated firebase-core dependency --- packages/firebase_core/android/build.gradle | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/firebase_core/android/build.gradle b/packages/firebase_core/android/build.gradle index a83c75ab8705..40707c96ecaf 100644 --- a/packages/firebase_core/android/build.gradle +++ b/packages/firebase_core/android/build.gradle @@ -32,8 +32,7 @@ android { disable 'InvalidPackage' } dependencies { - api 'com.google.firebase:firebase-core:16.0.9' - implementation 'com.google.firebase:firebase-common:16.1.0' + implementation 'com.google.firebase:firebase-common:19.2.0' } } From 588a48c4e22c1f667741a783ece3275227be8f8b Mon Sep 17 00:00:00 2001 From: Arthur Thompson Date: Tue, 12 Nov 2019 14:55:18 -0800 Subject: [PATCH 2/3] bump version --- packages/firebase_core/CHANGELOG.md | 4 ++++ packages/firebase_core/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/firebase_core/CHANGELOG.md b/packages/firebase_core/CHANGELOG.md index 3b71d493e74f..7ac186162464 100644 --- a/packages/firebase_core/CHANGELOG.md +++ b/packages/firebase_core/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.4.1+5 + +* Remove deprecated [firebase-core](https://firebase.google.com/support/release-notes/android) dependency. + ## 0.4.1+4 * Remove visibleForTesting annotation from FirebaseApp constructor. diff --git a/packages/firebase_core/pubspec.yaml b/packages/firebase_core/pubspec.yaml index d92b07068c04..0a810a2874b4 100644 --- a/packages/firebase_core/pubspec.yaml +++ b/packages/firebase_core/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for Firebase Core, enabling connecting to multiple Firebase apps. author: Flutter Team homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_core -version: 0.4.1+4 +version: 0.4.1+5 flutter: plugin: From 5ff62162f808316aece8f231e46496822bcd9333 Mon Sep 17 00:00:00 2001 From: Arthur Thompson Date: Tue, 12 Nov 2019 16:26:42 -0800 Subject: [PATCH 3/3] update embedding script to use implementation for dependencies --- packages/firebase_core/android/build.gradle | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/firebase_core/android/build.gradle b/packages/firebase_core/android/build.gradle index 40707c96ecaf..ce37c1f20cc9 100644 --- a/packages/firebase_core/android/build.gradle +++ b/packages/firebase_core/android/build.gradle @@ -32,7 +32,7 @@ android { disable 'InvalidPackage' } dependencies { - implementation 'com.google.firebase:firebase-common:19.2.0' + implementation 'com.google.firebase:firebase-common:16.1.0' } } @@ -54,9 +54,9 @@ afterEvaluate { android { dependencies { def lifecycle_version = "1.1.1" - compileOnly "android.arch.lifecycle:runtime:$lifecycle_version" - compileOnly "android.arch.lifecycle:common:$lifecycle_version" - compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version" + implementation "android.arch.lifecycle:runtime:$lifecycle_version" + implementation "android.arch.lifecycle:common:$lifecycle_version" + implementation "android.arch.lifecycle:common-java8:$lifecycle_version" } } }