From eb0d7a57775e46442daea32393436382bddddf87 Mon Sep 17 00:00:00 2001 From: Arthur Thompson Date: Thu, 14 Nov 2019 08:58:04 -0800 Subject: [PATCH 1/3] Add version to example apps --- packages/firebase_crashlytics/example/pubspec.yaml | 1 + packages/firebase_in_app_messaging/example/pubspec.yaml | 1 + packages/firebase_ml_vision/example/pubspec.yaml | 1 + 3 files changed, 3 insertions(+) diff --git a/packages/firebase_crashlytics/example/pubspec.yaml b/packages/firebase_crashlytics/example/pubspec.yaml index 8a12ba4d4bd6..775829ef5e46 100644 --- a/packages/firebase_crashlytics/example/pubspec.yaml +++ b/packages/firebase_crashlytics/example/pubspec.yaml @@ -1,5 +1,6 @@ name: firebase_crashlytics_example description: Demonstrates how to use the firebase_crashlytics plugin. +version: 1.0.0 environment: sdk: ">=2.0.0-dev.68.0 <3.0.0" diff --git a/packages/firebase_in_app_messaging/example/pubspec.yaml b/packages/firebase_in_app_messaging/example/pubspec.yaml index a2acd35b132f..645e6749aa53 100644 --- a/packages/firebase_in_app_messaging/example/pubspec.yaml +++ b/packages/firebase_in_app_messaging/example/pubspec.yaml @@ -1,6 +1,7 @@ name: firebase_in_app_messaging_example description: Demonstrates how to use the firebase_in_app_messaging plugin. publish_to: 'none' +version: 1.0.0 environment: sdk: ">=2.1.0 <3.0.0" diff --git a/packages/firebase_ml_vision/example/pubspec.yaml b/packages/firebase_ml_vision/example/pubspec.yaml index 452753c1b647..df946cf8ff3c 100644 --- a/packages/firebase_ml_vision/example/pubspec.yaml +++ b/packages/firebase_ml_vision/example/pubspec.yaml @@ -1,6 +1,7 @@ name: firebase_ml_vision_example description: Demonstrates how to use the firebase_ml_vision plugin. author: Flutter Team +version: 1.0.0 dependencies: flutter: From e293337cb243835a4b64804ef10340fd3168c60a Mon Sep 17 00:00:00 2001 From: Arthur Thompson Date: Thu, 14 Nov 2019 10:31:06 -0800 Subject: [PATCH 2/3] use hard coded versions --- packages/firebase_crashlytics/example/ios/Runner/Info.plist | 4 ++-- packages/firebase_crashlytics/example/pubspec.yaml | 1 - .../firebase_in_app_messaging/example/ios/Runner/Info.plist | 4 ++-- packages/firebase_in_app_messaging/example/pubspec.yaml | 1 - packages/firebase_ml_vision/example/ios/Runner/Info.plist | 4 ++-- packages/firebase_ml_vision/example/pubspec.yaml | 1 - 6 files changed, 6 insertions(+), 9 deletions(-) diff --git a/packages/firebase_crashlytics/example/ios/Runner/Info.plist b/packages/firebase_crashlytics/example/ios/Runner/Info.plist index 0f5908f87367..c256888395eb 100644 --- a/packages/firebase_crashlytics/example/ios/Runner/Info.plist +++ b/packages/firebase_crashlytics/example/ios/Runner/Info.plist @@ -15,11 +15,11 @@ CFBundlePackageType APPL CFBundleShortVersionString - $(FLUTTER_BUILD_NAME) + $(MARKETING_VERSION) CFBundleSignature ???? CFBundleVersion - $(FLUTTER_BUILD_NUMBER) + $(CURRENT_PROJECT_VERSION) LSRequiresIPhoneOS UILaunchStoryboardName diff --git a/packages/firebase_crashlytics/example/pubspec.yaml b/packages/firebase_crashlytics/example/pubspec.yaml index 775829ef5e46..8a12ba4d4bd6 100644 --- a/packages/firebase_crashlytics/example/pubspec.yaml +++ b/packages/firebase_crashlytics/example/pubspec.yaml @@ -1,6 +1,5 @@ name: firebase_crashlytics_example description: Demonstrates how to use the firebase_crashlytics plugin. -version: 1.0.0 environment: sdk: ">=2.0.0-dev.68.0 <3.0.0" diff --git a/packages/firebase_in_app_messaging/example/ios/Runner/Info.plist b/packages/firebase_in_app_messaging/example/ios/Runner/Info.plist index 9afd5ae7969f..ecf2175da5ff 100644 --- a/packages/firebase_in_app_messaging/example/ios/Runner/Info.plist +++ b/packages/firebase_in_app_messaging/example/ios/Runner/Info.plist @@ -15,11 +15,11 @@ CFBundlePackageType APPL CFBundleShortVersionString - $(FLUTTER_BUILD_NAME) + $(MARKETING_VERSION) CFBundleSignature ???? CFBundleVersion - $(FLUTTER_BUILD_NUMBER) + $(CURRENT_PROJECT_VERSION) LSRequiresIPhoneOS UILaunchStoryboardName diff --git a/packages/firebase_in_app_messaging/example/pubspec.yaml b/packages/firebase_in_app_messaging/example/pubspec.yaml index 645e6749aa53..a2acd35b132f 100644 --- a/packages/firebase_in_app_messaging/example/pubspec.yaml +++ b/packages/firebase_in_app_messaging/example/pubspec.yaml @@ -1,7 +1,6 @@ name: firebase_in_app_messaging_example description: Demonstrates how to use the firebase_in_app_messaging plugin. publish_to: 'none' -version: 1.0.0 environment: sdk: ">=2.1.0 <3.0.0" diff --git a/packages/firebase_ml_vision/example/ios/Runner/Info.plist b/packages/firebase_ml_vision/example/ios/Runner/Info.plist index b00979ea6bac..76d0a8828ed4 100644 --- a/packages/firebase_ml_vision/example/ios/Runner/Info.plist +++ b/packages/firebase_ml_vision/example/ios/Runner/Info.plist @@ -21,11 +21,11 @@ CFBundlePackageType APPL CFBundleShortVersionString - $(FLUTTER_BUILD_NAME) + $(MARKETING_VERSION) CFBundleSignature ???? CFBundleVersion - $(FLUTTER_BUILD_NUMBER) + $(CURRENT_PROJECT_VERSION) LSRequiresIPhoneOS UILaunchStoryboardName diff --git a/packages/firebase_ml_vision/example/pubspec.yaml b/packages/firebase_ml_vision/example/pubspec.yaml index df946cf8ff3c..452753c1b647 100644 --- a/packages/firebase_ml_vision/example/pubspec.yaml +++ b/packages/firebase_ml_vision/example/pubspec.yaml @@ -1,7 +1,6 @@ name: firebase_ml_vision_example description: Demonstrates how to use the firebase_ml_vision plugin. author: Flutter Team -version: 1.0.0 dependencies: flutter: From f1a707098e1da53ba2882d296ad9acb747245e08 Mon Sep 17 00:00:00 2001 From: Arthur Thompson Date: Thu, 14 Nov 2019 11:19:22 -0800 Subject: [PATCH 3/3] use hard coded version values --- packages/firebase_crashlytics/example/ios/Runner/Info.plist | 4 ++-- .../firebase_in_app_messaging/example/ios/Runner/Info.plist | 4 ++-- packages/firebase_ml_vision/example/ios/Runner/Info.plist | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/firebase_crashlytics/example/ios/Runner/Info.plist b/packages/firebase_crashlytics/example/ios/Runner/Info.plist index c256888395eb..e12fa7ea45bc 100644 --- a/packages/firebase_crashlytics/example/ios/Runner/Info.plist +++ b/packages/firebase_crashlytics/example/ios/Runner/Info.plist @@ -15,11 +15,11 @@ CFBundlePackageType APPL CFBundleShortVersionString - $(MARKETING_VERSION) + 1.0 CFBundleSignature ???? CFBundleVersion - $(CURRENT_PROJECT_VERSION) + 1 LSRequiresIPhoneOS UILaunchStoryboardName diff --git a/packages/firebase_in_app_messaging/example/ios/Runner/Info.plist b/packages/firebase_in_app_messaging/example/ios/Runner/Info.plist index ecf2175da5ff..3eafa5eb9de8 100644 --- a/packages/firebase_in_app_messaging/example/ios/Runner/Info.plist +++ b/packages/firebase_in_app_messaging/example/ios/Runner/Info.plist @@ -15,11 +15,11 @@ CFBundlePackageType APPL CFBundleShortVersionString - $(MARKETING_VERSION) + 1.0 CFBundleSignature ???? CFBundleVersion - $(CURRENT_PROJECT_VERSION) + 1 LSRequiresIPhoneOS UILaunchStoryboardName diff --git a/packages/firebase_ml_vision/example/ios/Runner/Info.plist b/packages/firebase_ml_vision/example/ios/Runner/Info.plist index 76d0a8828ed4..2038a4edf197 100644 --- a/packages/firebase_ml_vision/example/ios/Runner/Info.plist +++ b/packages/firebase_ml_vision/example/ios/Runner/Info.plist @@ -21,11 +21,11 @@ CFBundlePackageType APPL CFBundleShortVersionString - $(MARKETING_VERSION) + 1.0 CFBundleSignature ???? CFBundleVersion - $(CURRENT_PROJECT_VERSION) + 1 LSRequiresIPhoneOS UILaunchStoryboardName