From e9ea76e3de8bedca70bdf71097bc8d1c19c79c94 Mon Sep 17 00:00:00 2001 From: Stephen Beitzel Date: Thu, 23 Jan 2020 11:16:37 -0800 Subject: [PATCH 1/3] Fix method channel name --- .../cloud_functions_platform_interface/CHANGELOG.md | 4 ++++ .../lib/src/method_channel_cloud_functions.dart | 2 +- .../cloud_functions_platform_interface/pubspec.yaml | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/cloud_functions/cloud_functions_platform_interface/CHANGELOG.md b/packages/cloud_functions/cloud_functions_platform_interface/CHANGELOG.md index 9d241d49741c..514b0334be67 100644 --- a/packages/cloud_functions/cloud_functions_platform_interface/CHANGELOG.md +++ b/packages/cloud_functions/cloud_functions_platform_interface/CHANGELOG.md @@ -1,3 +1,7 @@ +## 1.0.0+1 + +* Fix plugin name in MethodChannel + ## 1.0.0 Initial release diff --git a/packages/cloud_functions/cloud_functions_platform_interface/lib/src/method_channel_cloud_functions.dart b/packages/cloud_functions/cloud_functions_platform_interface/lib/src/method_channel_cloud_functions.dart index ba1a52a35990..3db716978f31 100644 --- a/packages/cloud_functions/cloud_functions_platform_interface/lib/src/method_channel_cloud_functions.dart +++ b/packages/cloud_functions/cloud_functions_platform_interface/lib/src/method_channel_cloud_functions.dart @@ -9,7 +9,7 @@ class MethodChannelCloudFunctions extends CloudFunctionsPlatform { /// The [MethodChannel] to which calls will be delegated. @visibleForTesting static const MethodChannel channel = MethodChannel( - 'plugins.flutter.io/cloud_functions', + 'cloud_functions', ); /// Invokes the specified cloud function. diff --git a/packages/cloud_functions/cloud_functions_platform_interface/pubspec.yaml b/packages/cloud_functions/cloud_functions_platform_interface/pubspec.yaml index ffb73e687d2e..f2704ced4b6a 100644 --- a/packages/cloud_functions/cloud_functions_platform_interface/pubspec.yaml +++ b/packages/cloud_functions/cloud_functions_platform_interface/pubspec.yaml @@ -3,7 +3,7 @@ description: A common platform interface for the cloud_functions plugin. homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/cloud_functions/cloud_functions_platform_interface # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 1.0.0 +version: 1.0.0+1 dependencies: flutter: From b19a85efda7ec24903a7aeeb7fc2fa7953143e45 Mon Sep 17 00:00:00 2001 From: Stephen Beitzel Date: Thu, 23 Jan 2020 11:23:18 -0800 Subject: [PATCH 2/3] Add explanatory comment. --- .../lib/src/method_channel_cloud_functions.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/cloud_functions/cloud_functions_platform_interface/lib/src/method_channel_cloud_functions.dart b/packages/cloud_functions/cloud_functions_platform_interface/lib/src/method_channel_cloud_functions.dart index 3db716978f31..4736a939b893 100644 --- a/packages/cloud_functions/cloud_functions_platform_interface/lib/src/method_channel_cloud_functions.dart +++ b/packages/cloud_functions/cloud_functions_platform_interface/lib/src/method_channel_cloud_functions.dart @@ -7,6 +7,8 @@ part of cloud_functions_platform_interface; /// [CloudFunctionsPlatform] implementation that delegates to a [MethodChannel]. class MethodChannelCloudFunctions extends CloudFunctionsPlatform { /// The [MethodChannel] to which calls will be delegated. + /// Note that this name must match the name used in the platform (iOS/Android) + /// plugin. @visibleForTesting static const MethodChannel channel = MethodChannel( 'cloud_functions', From dd7cc39575fef383e39b11fe4728bcae43a8497b Mon Sep 17 00:00:00 2001 From: Stephen Beitzel Date: Thu, 23 Jan 2020 11:35:14 -0800 Subject: [PATCH 3/3] Change version number --- .../cloud_functions_platform_interface/CHANGELOG.md | 2 +- .../cloud_functions_platform_interface/pubspec.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/cloud_functions/cloud_functions_platform_interface/CHANGELOG.md b/packages/cloud_functions/cloud_functions_platform_interface/CHANGELOG.md index 514b0334be67..22adc33713b5 100644 --- a/packages/cloud_functions/cloud_functions_platform_interface/CHANGELOG.md +++ b/packages/cloud_functions/cloud_functions_platform_interface/CHANGELOG.md @@ -1,4 +1,4 @@ -## 1.0.0+1 +## 1.0.1 * Fix plugin name in MethodChannel diff --git a/packages/cloud_functions/cloud_functions_platform_interface/pubspec.yaml b/packages/cloud_functions/cloud_functions_platform_interface/pubspec.yaml index f2704ced4b6a..23da5f95811e 100644 --- a/packages/cloud_functions/cloud_functions_platform_interface/pubspec.yaml +++ b/packages/cloud_functions/cloud_functions_platform_interface/pubspec.yaml @@ -3,7 +3,7 @@ description: A common platform interface for the cloud_functions plugin. homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/cloud_functions/cloud_functions_platform_interface # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 1.0.0+1 +version: 1.0.1 dependencies: flutter: