From d62dec81aeb531a0683c072c1e76423bbd4a3852 Mon Sep 17 00:00:00 2001
From: Julien Wajsberg <felash@gmail.com>
Date: Fri, 6 Sep 2024 11:07:27 +0200
Subject: [PATCH 1/5] Use a TypedArray for a significant performance boost when
 switching to the marker chart

---
 src/components/marker-chart/Canvas.js | 15 +++++++++------
 src/components/marker-chart/index.js  |  4 ++++
 src/selectors/per-thread/markers.js   |  7 +++++++
 3 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/src/components/marker-chart/Canvas.js b/src/components/marker-chart/Canvas.js
index a50539c0af..b85615972e 100644
--- a/src/components/marker-chart/Canvas.js
+++ b/src/components/marker-chart/Canvas.js
@@ -80,6 +80,7 @@ type OwnProps = {|
   +markerTimingAndBuckets: MarkerTimingAndBuckets,
   +rowHeight: CssPixels,
   +getMarker: (MarkerIndex) => Marker,
+  +markerListLength: number,
   +threadsKey: ThreadsKey,
   +updatePreviewSelection: WrapFunctionInDispatch<UpdatePreviewSelection>,
   +changeMouseTimePosition: ChangeMouseTimePosition,
@@ -164,11 +165,11 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
     const rightClickedRow: number | void =
       rightClickedMarkerIndex === null
         ? undefined
-        : markerIndexToTimingRow.get(rightClickedMarkerIndex);
+        : markerIndexToTimingRow[rightClickedMarkerIndex];
     let newRow: number | void =
       hoveredMarker === null
         ? undefined
-        : markerIndexToTimingRow.get(hoveredMarker);
+        : markerIndexToTimingRow[hoveredMarker];
     if (
       timelineTrackOrganization.type === 'active-tab' &&
       newRow === undefined &&
@@ -190,7 +191,7 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
       let oldRow: number | void =
         prevHoveredMarker === null
           ? undefined
-          : markerIndexToTimingRow.get(prevHoveredMarker);
+          : markerIndexToTimingRow[prevHoveredMarker];
       if (
         timelineTrackOrganization.type === 'active-tab' &&
         oldRow === undefined &&
@@ -254,8 +255,10 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
   _getMarkerIndexToTimingRow = memoize(
     (
       markerTimingAndBuckets: MarkerTimingAndBuckets
-    ): Map<MarkerIndex, number> => {
-      const markerIndexToTimingRow = new Map();
+    ): Uint32Array /* like Map<MarkerIndex, RowIndex> */ => {
+      const markerIndexToTimingRow = new Uint32Array(
+        this.props.markerListLength
+      );
       for (
         let rowIndex = 0;
         rowIndex < markerTimingAndBuckets.length;
@@ -270,7 +273,7 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
           timingIndex < markerTiming.length;
           timingIndex++
         ) {
-          markerIndexToTimingRow.set(markerTiming.index[timingIndex], rowIndex);
+          markerIndexToTimingRow[markerTiming.index[timingIndex]] = rowIndex;
         }
       }
       return markerIndexToTimingRow;
diff --git a/src/components/marker-chart/index.js b/src/components/marker-chart/index.js
index 86a8d25bc1..2fad12c6ee 100644
--- a/src/components/marker-chart/index.js
+++ b/src/components/marker-chart/index.js
@@ -57,6 +57,7 @@ type StateProps = {|
   +getMarker: (MarkerIndex) => Marker,
   +markerTimingAndBuckets: MarkerTimingAndBuckets,
   +maxMarkerRows: number,
+  +markerListLength: number,
   +timeRange: StartEndRange,
   +threadsKey: ThreadsKey,
   +previewSelection: PreviewSelection,
@@ -105,6 +106,7 @@ class MarkerChartImpl extends React.PureComponent<Props> {
   render() {
     const {
       maxMarkerRows,
+      markerListLength,
       timeRange,
       threadsKey,
       markerTimingAndBuckets,
@@ -156,6 +158,7 @@ class MarkerChartImpl extends React.PureComponent<Props> {
               chartProps={{
                 markerTimingAndBuckets,
                 getMarker,
+                markerListLength,
                 // $FlowFixMe Error introduced by upgrading to v0.96.0. See issue #1936.
                 updatePreviewSelection,
                 changeMouseTimePosition,
@@ -196,6 +199,7 @@ export const MarkerChart = explicitConnect<{||}, StateProps, DispatchProps>({
       getMarker: selectedThreadSelectors.getMarkerGetter(state),
       markerTimingAndBuckets,
       maxMarkerRows: markerTimingAndBuckets.length,
+      markerListLength: selectedThreadSelectors.getMarkerListLength(state),
       timeRange: getCommittedRange(state),
       threadsKey: getSelectedThreadsKey(state),
       previewSelection: getPreviewSelection(state),
diff --git a/src/selectors/per-thread/markers.js b/src/selectors/per-thread/markers.js
index 66826cf505..574207c8b4 100644
--- a/src/selectors/per-thread/markers.js
+++ b/src/selectors/per-thread/markers.js
@@ -134,6 +134,12 @@ export function getMarkerSelectorsPerThread(
       )
   );
 
+  /**
+   * This returns the maximum marker index.
+   */
+  const getMarkerListLength: Selector<number> = (state) =>
+    getFullMarkerList(state).length;
+
   /**
    * This selector returns a function that's used to retrieve a marker object
    * from its MarkerIndex:
@@ -739,6 +745,7 @@ export function getMarkerSelectorsPerThread(
     getMarkerIndexToRawMarkerIndexes,
     getFullMarkerList,
     getFullMarkerListIndexes,
+    getMarkerListLength,
     getNetworkMarkerIndexes,
     getSearchFilteredNetworkMarkerIndexes,
     getAreMarkerPanelsEmptyInFullRange,

From 6d04c5fe708e0f4a4fe6b526fe585f89b4c97ec7 Mon Sep 17 00:00:00 2001
From: Julien Wajsberg <felash@gmail.com>
Date: Fri, 6 Sep 2024 11:42:36 +0200
Subject: [PATCH 2/5] Lazy compute labels in the marker chart

---
 src/components/marker-chart/Canvas.js | 25 ++++++++++++++++---------
 src/profile-logic/marker-timing.js    |  2 +-
 src/types/profile-derived.js          |  2 +-
 3 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/src/components/marker-chart/Canvas.js b/src/components/marker-chart/Canvas.js
index b85615972e..0c47f80b2e 100644
--- a/src/components/marker-chart/Canvas.js
+++ b/src/components/marker-chart/Canvas.js
@@ -48,7 +48,7 @@ type MarkerDrawingInformation = {|
   +w: CssPixels,
   +h: CssPixels,
   +isInstantMarker: boolean,
-  +text: string,
+  +textGetter: () => string,
 |};
 
 // We can hover over multiple items with Marker chart when we are in the active
@@ -290,13 +290,13 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
     w: CssPixels,
     h: CssPixels,
     isInstantMarker: boolean,
-    text: string,
+    textGetter: () => string,
     isHighlighted: boolean = false
   ) {
     if (isInstantMarker) {
       this.drawOneInstantMarker(ctx, x, y, h, isHighlighted);
     } else {
-      this.drawOneIntervalMarker(ctx, x, y, w, h, text, isHighlighted);
+      this.drawOneIntervalMarker(ctx, x, y, w, h, textGetter, isHighlighted);
     }
   }
 
@@ -306,7 +306,7 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
     y: CssPixels,
     w: CssPixels,
     h: CssPixels,
-    text: string,
+    textGetter: () => string,
     isHighlighted: boolean
   ) {
     const { marginLeft } = this.props;
@@ -354,7 +354,7 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
       const w2: CssPixels = visibleWidth - 2 * TEXT_OFFSET_START;
 
       if (w2 > textMeasurement.minWidth) {
-        const fittedText = textMeasurement.getFittedText(text, w2);
+        const fittedText = textMeasurement.getFittedText(textGetter(), w2);
         if (fittedText) {
           ctx.fillStyle = isHighlighted ? 'white' : 'black';
           ctx.fillText(fittedText, x2, y + TEXT_OFFSET_TOP);
@@ -477,7 +477,7 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
           x = Math.round(x * devicePixelRatio) / devicePixelRatio;
           w = Math.round(w * devicePixelRatio) / devicePixelRatio;
 
-          const text = markerTiming.label[i];
+          const textGetter = markerTiming.label[i];
           const markerIndex = markerTiming.index[i];
 
           const isHighlighted =
@@ -486,7 +486,14 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
             selectedMarkerIndex === markerIndex;
 
           if (isHighlighted) {
-            highlightedMarkers.push({ x, y, w, h, isInstantMarker, text });
+            highlightedMarkers.push({
+              x,
+              y,
+              w,
+              h,
+              isInstantMarker,
+              textGetter,
+            });
           } else if (
             // Always render non-dot markers and markers that are larger than
             // one pixel.
@@ -496,7 +503,7 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
             x !== previousMarkerDrawnAtX
           ) {
             previousMarkerDrawnAtX = x;
-            this.drawOneMarker(ctx, x, y, w, h, isInstantMarker, text);
+            this.drawOneMarker(ctx, x, y, w, h, isInstantMarker, textGetter);
           }
         }
       }
@@ -512,7 +519,7 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
         highlightedMarker.w,
         highlightedMarker.h,
         highlightedMarker.isInstantMarker,
-        highlightedMarker.text,
+        highlightedMarker.textGetter,
         true /* isHighlighted */
       );
     });
diff --git a/src/profile-logic/marker-timing.js b/src/profile-logic/marker-timing.js
index 8635198b75..25058b71dc 100644
--- a/src/profile-logic/marker-timing.js
+++ b/src/profile-logic/marker-timing.js
@@ -110,7 +110,7 @@ export function getMarkerTiming(
         // The chart will then be responsible for drawing this differently.
         marker.end === null ? marker.start : marker.end
       );
-      markerTiming.label.push(getLabel(markerIndex));
+      markerTiming.label.push(() => getLabel(markerIndex));
       markerTiming.index.push(markerIndex);
       markerTiming.length++;
     };
diff --git a/src/types/profile-derived.js b/src/types/profile-derived.js
index 03cc077102..c18e366b14 100644
--- a/src/types/profile-derived.js
+++ b/src/types/profile-derived.js
@@ -401,7 +401,7 @@ export type MarkerTiming = {|
   // End time in milliseconds. It will equals start for instant markers.
   end: number[],
   index: MarkerIndex[],
-  label: string[],
+  label: Array<() => string>,
   name: string,
   bucket: string,
   // True if this marker timing contains only instant markers.

From 749080666cdc6baffcafe2ea5fe9082831cef21a Mon Sep 17 00:00:00 2001
From: Julien Wajsberg <felash@gmail.com>
Date: Mon, 16 Sep 2024 17:12:06 +0200
Subject: [PATCH 3/5] Instead of storing a lambda for each marker, pass
 getMarkerLabel down to the Marker Chart canvas component

---
 src/components/marker-chart/Canvas.js | 23 +++++++++++++----------
 src/components/marker-chart/index.js  |  4 ++++
 src/profile-logic/marker-timing.js    | 10 ----------
 src/selectors/per-thread/markers.js   |  9 +++++----
 src/types/profile-derived.js          |  1 -
 5 files changed, 22 insertions(+), 25 deletions(-)

diff --git a/src/components/marker-chart/Canvas.js b/src/components/marker-chart/Canvas.js
index 0c47f80b2e..da9f33062b 100644
--- a/src/components/marker-chart/Canvas.js
+++ b/src/components/marker-chart/Canvas.js
@@ -48,7 +48,7 @@ type MarkerDrawingInformation = {|
   +w: CssPixels,
   +h: CssPixels,
   +isInstantMarker: boolean,
-  +textGetter: () => string,
+  +markerIndex: MarkerIndex,
 |};
 
 // We can hover over multiple items with Marker chart when we are in the active
@@ -80,6 +80,7 @@ type OwnProps = {|
   +markerTimingAndBuckets: MarkerTimingAndBuckets,
   +rowHeight: CssPixels,
   +getMarker: (MarkerIndex) => Marker,
+  +getMarkerLabel: (MarkerIndex) => string,
   +markerListLength: number,
   +threadsKey: ThreadsKey,
   +updatePreviewSelection: WrapFunctionInDispatch<UpdatePreviewSelection>,
@@ -290,13 +291,13 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
     w: CssPixels,
     h: CssPixels,
     isInstantMarker: boolean,
-    textGetter: () => string,
+    markerIndex: MarkerIndex,
     isHighlighted: boolean = false
   ) {
     if (isInstantMarker) {
       this.drawOneInstantMarker(ctx, x, y, h, isHighlighted);
     } else {
-      this.drawOneIntervalMarker(ctx, x, y, w, h, textGetter, isHighlighted);
+      this.drawOneIntervalMarker(ctx, x, y, w, h, markerIndex, isHighlighted);
     }
   }
 
@@ -306,10 +307,10 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
     y: CssPixels,
     w: CssPixels,
     h: CssPixels,
-    textGetter: () => string,
+    markerIndex: MarkerIndex,
     isHighlighted: boolean
   ) {
-    const { marginLeft } = this.props;
+    const { marginLeft, getMarkerLabel } = this.props;
 
     if (w <= 2) {
       // This is an interval marker small enough that if we drew it as a
@@ -354,7 +355,10 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
       const w2: CssPixels = visibleWidth - 2 * TEXT_OFFSET_START;
 
       if (w2 > textMeasurement.minWidth) {
-        const fittedText = textMeasurement.getFittedText(textGetter(), w2);
+        const fittedText = textMeasurement.getFittedText(
+          getMarkerLabel(markerIndex),
+          w2
+        );
         if (fittedText) {
           ctx.fillStyle = isHighlighted ? 'white' : 'black';
           ctx.fillText(fittedText, x2, y + TEXT_OFFSET_TOP);
@@ -477,7 +481,6 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
           x = Math.round(x * devicePixelRatio) / devicePixelRatio;
           w = Math.round(w * devicePixelRatio) / devicePixelRatio;
 
-          const textGetter = markerTiming.label[i];
           const markerIndex = markerTiming.index[i];
 
           const isHighlighted =
@@ -492,7 +495,7 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
               w,
               h,
               isInstantMarker,
-              textGetter,
+              markerIndex,
             });
           } else if (
             // Always render non-dot markers and markers that are larger than
@@ -503,7 +506,7 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
             x !== previousMarkerDrawnAtX
           ) {
             previousMarkerDrawnAtX = x;
-            this.drawOneMarker(ctx, x, y, w, h, isInstantMarker, textGetter);
+            this.drawOneMarker(ctx, x, y, w, h, isInstantMarker, markerIndex);
           }
         }
       }
@@ -519,7 +522,7 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
         highlightedMarker.w,
         highlightedMarker.h,
         highlightedMarker.isInstantMarker,
-        highlightedMarker.textGetter,
+        highlightedMarker.markerIndex,
         true /* isHighlighted */
       );
     });
diff --git a/src/components/marker-chart/index.js b/src/components/marker-chart/index.js
index 2fad12c6ee..17abbb99cf 100644
--- a/src/components/marker-chart/index.js
+++ b/src/components/marker-chart/index.js
@@ -55,6 +55,7 @@ type DispatchProps = {|
 
 type StateProps = {|
   +getMarker: (MarkerIndex) => Marker,
+  +getMarkerLabel: (MarkerIndex) => string,
   +markerTimingAndBuckets: MarkerTimingAndBuckets,
   +maxMarkerRows: number,
   +markerListLength: number,
@@ -111,6 +112,7 @@ class MarkerChartImpl extends React.PureComponent<Props> {
       threadsKey,
       markerTimingAndBuckets,
       getMarker,
+      getMarkerLabel,
       previewSelection,
       updatePreviewSelection,
       changeMouseTimePosition,
@@ -158,6 +160,7 @@ class MarkerChartImpl extends React.PureComponent<Props> {
               chartProps={{
                 markerTimingAndBuckets,
                 getMarker,
+                getMarkerLabel,
                 markerListLength,
                 // $FlowFixMe Error introduced by upgrading to v0.96.0. See issue #1936.
                 updatePreviewSelection,
@@ -197,6 +200,7 @@ export const MarkerChart = explicitConnect<{||}, StateProps, DispatchProps>({
       selectedThreadSelectors.getMarkerChartTimingAndBuckets(state);
     return {
       getMarker: selectedThreadSelectors.getMarkerGetter(state),
+      getMarkerLabel: selectedThreadSelectors.getMarkerChartLabelGetter(state),
       markerTimingAndBuckets,
       maxMarkerRows: markerTimingAndBuckets.length,
       markerListLength: selectedThreadSelectors.getMarkerListLength(state),
diff --git a/src/profile-logic/marker-timing.js b/src/profile-logic/marker-timing.js
index 25058b71dc..c74118b0ad 100644
--- a/src/profile-logic/marker-timing.js
+++ b/src/profile-logic/marker-timing.js
@@ -30,7 +30,6 @@ const MAX_STACKING_DEPTH = 300;
  *      start: [0, 23, 35, 65, 75],
  *      end: [1, 25, 37, 67, 77],
  *      index: [0, 2, 5, 6, 8],
- *      label: ["Aye", "Aye", "Aye", "Aye", "Aye"],
  *      bucket: "DOM",
  *      instantOnly: false,
  *      length: 5,
@@ -40,7 +39,6 @@ const MAX_STACKING_DEPTH = 300;
  *      start: [1, 28, 39, 69, 70],
  *      end: [2, 29, 49, 70, 77],
  *      index: [1, 3, 7, 9, 10],
- *      label: ["Bee", "Bee", "Bee", "Bee", "Bee"],
  *      bucket: "DOM",
  *      instantOnly: false,
  *      length: 5,
@@ -50,7 +48,6 @@ const MAX_STACKING_DEPTH = 300;
  *      start: [1, 28, 39, 69, 70],
  *      end: [2, 29, 49, 70, 77],
  *      index: [1, 3, 7, 9, 10],
- *      label: ["Bee", "Bee", "Bee", "Bee", "Bee"],
  *      bucket: "DOM",
  *      instantOnly: false,
  *      length: 5,
@@ -60,7 +57,6 @@ const MAX_STACKING_DEPTH = 300;
  *      start: [10, 33, 45, 75, 85],
  *      end: [11, 35, 47, 77, 87],
  *      index: [4, 11, 12, 13, 14],
- *      label: ["Sea", "Sea", "Sea", "Sea", "Sea"],
  *      bucket: "Other",
  *      instantOnly: false,
  *      length: 5,
@@ -110,7 +106,6 @@ export function getMarkerTiming(
         // The chart will then be responsible for drawing this differently.
         marker.end === null ? marker.start : marker.end
       );
-      markerTiming.label.push(() => getLabel(markerIndex));
       markerTiming.index.push(markerIndex);
       markerTiming.length++;
     };
@@ -129,7 +124,6 @@ export function getMarkerTiming(
       start: [],
       end: [],
       index: [],
-      label: [],
       name: markerLineName,
       bucket: bucketName,
       instantOnly,
@@ -254,7 +248,6 @@ export function getMarkerTiming(
  *      start: [0, 23, 35, 65, 75],
  *      end: [1, 25, 37, 67, 77],
  *      index: [0, 2, 5, 6, 8],
- *      label: ["Aye", "Aye", "Aye", "Aye", "Aye"],
  *      bucket: "DOM",
  *      instantOnly: false,
  *      length: 5,
@@ -264,7 +257,6 @@ export function getMarkerTiming(
  *      start: [1, 28, 39, 69, 70],
  *      end: [2, 29, 49, 70, 77],
  *      index: [1, 3, 7, 9, 10],
- *      label: ["Bee", "Bee", "Bee", "Bee", "Bee"],
  *      bucket: "DOM",
  *      instantOnly: false,
  *      length: 5,
@@ -274,7 +266,6 @@ export function getMarkerTiming(
  *      start: [1, 28, 39, 69, 70],
  *      end: [2, 29, 49, 70, 77],
  *      index: [1, 3, 7, 9, 10],
- *      label: ["Bee", "Bee", "Bee", "Bee", "Bee"],
  *      bucket: "DOM",
  *      instantOnly: false,
  *      length: 5,
@@ -285,7 +276,6 @@ export function getMarkerTiming(
  *      start: [10, 33, 45, 75, 85],
  *      end: [11, 35, 47, 77, 87],
  *      index: [4, 11, 12, 13, 14],
- *      label: ["Sea", "Sea", "Sea", "Sea", "Sea"],
  *      bucket: "Other",
  *      instantOnly: false,
  *      length: 5,
diff --git a/src/selectors/per-thread/markers.js b/src/selectors/per-thread/markers.js
index 574207c8b4..6cc4053978 100644
--- a/src/selectors/per-thread/markers.js
+++ b/src/selectors/per-thread/markers.js
@@ -452,7 +452,7 @@ export function getMarkerSelectorsPerThread(
   /**
    * This getter uses the marker schema to decide on the labels for the marker chart.
    */
-  const _getMarkerChartLabelGetter: Selector<(MarkerIndex) => string> =
+  const getMarkerChartLabelGetter: Selector<(MarkerIndex) => string> =
     createSelector(
       getMarkerGetter,
       ProfileSelectors.getMarkerSchema,
@@ -487,7 +487,7 @@ export function getMarkerSelectorsPerThread(
     createSelector(
       getMarkerGetter,
       getMarkerChartMarkerIndexes,
-      _getMarkerChartLabelGetter,
+      getMarkerChartLabelGetter,
       ProfileSelectors.getCategories,
       MarkerTimingLogic.getMarkerTimingAndBuckets
     );
@@ -541,7 +541,7 @@ export function getMarkerSelectorsPerThread(
   const getNetworkTrackTiming: Selector<MarkerTiming[]> = createSelector(
     getMarkerGetter,
     getNetworkMarkerIndexes,
-    _getMarkerChartLabelGetter,
+    getMarkerChartLabelGetter,
     MarkerTimingLogic.getMarkerTiming
   );
 
@@ -552,7 +552,7 @@ export function getMarkerSelectorsPerThread(
   const getUserTimingMarkerTiming: Selector<MarkerTiming[]> = createSelector(
     getMarkerGetter,
     getUserTimingMarkerIndexes,
-    _getMarkerChartLabelGetter,
+    getMarkerChartLabelGetter,
     MarkerTimingLogic.getMarkerTiming
   );
 
@@ -751,6 +751,7 @@ export function getMarkerSelectorsPerThread(
     getAreMarkerPanelsEmptyInFullRange,
     getMarkerTableMarkerIndexes,
     getMarkerChartMarkerIndexes,
+    getMarkerChartLabelGetter,
     getMarkerTooltipLabelGetter,
     getMarkerTableLabelGetter,
     getMarkerLabelToCopyGetter,
diff --git a/src/types/profile-derived.js b/src/types/profile-derived.js
index c18e366b14..3d1d84301a 100644
--- a/src/types/profile-derived.js
+++ b/src/types/profile-derived.js
@@ -401,7 +401,6 @@ export type MarkerTiming = {|
   // End time in milliseconds. It will equals start for instant markers.
   end: number[],
   index: MarkerIndex[],
-  label: Array<() => string>,
   name: string,
   bucket: string,
   // True if this marker timing contains only instant markers.

From 9bbb0e7c576db1c6c6cbffd9d4c6bc0b3bc85a40 Mon Sep 17 00:00:00 2001
From: Julien Wajsberg <felash@gmail.com>
Date: Mon, 16 Sep 2024 17:15:08 +0200
Subject: [PATCH 4/5] Clean-up

---
 src/profile-logic/marker-timing.js  | 3 ---
 src/selectors/per-thread/markers.js | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/src/profile-logic/marker-timing.js b/src/profile-logic/marker-timing.js
index c74118b0ad..9bf6b13f0d 100644
--- a/src/profile-logic/marker-timing.js
+++ b/src/profile-logic/marker-timing.js
@@ -86,7 +86,6 @@ export function getMarkerTiming(
   markerIndexes: MarkerIndex[],
   // Categories can be null for things like Network Markers, where we don't care to
   // break things up by category.
-  getLabel: (MarkerIndex) => string,
   categories: ?CategoryList
 ): MarkerTiming[] {
   // Each marker type will have it's own timing information, later collapse these into
@@ -287,13 +286,11 @@ export function getMarkerTimingAndBuckets(
   markerIndexes: MarkerIndex[],
   // Categories can be null for things like Network Markers, where we don't care to
   // break things up by category.
-  getLabel: (MarkerIndex) => string,
   categories: ?CategoryList
 ): MarkerTimingAndBuckets {
   const allMarkerTimings = getMarkerTiming(
     getMarker,
     markerIndexes,
-    getLabel,
     categories
   );
 
diff --git a/src/selectors/per-thread/markers.js b/src/selectors/per-thread/markers.js
index 6cc4053978..393ee3f168 100644
--- a/src/selectors/per-thread/markers.js
+++ b/src/selectors/per-thread/markers.js
@@ -487,7 +487,6 @@ export function getMarkerSelectorsPerThread(
     createSelector(
       getMarkerGetter,
       getMarkerChartMarkerIndexes,
-      getMarkerChartLabelGetter,
       ProfileSelectors.getCategories,
       MarkerTimingLogic.getMarkerTimingAndBuckets
     );
@@ -541,7 +540,6 @@ export function getMarkerSelectorsPerThread(
   const getNetworkTrackTiming: Selector<MarkerTiming[]> = createSelector(
     getMarkerGetter,
     getNetworkMarkerIndexes,
-    getMarkerChartLabelGetter,
     MarkerTimingLogic.getMarkerTiming
   );
 
@@ -552,7 +550,6 @@ export function getMarkerSelectorsPerThread(
   const getUserTimingMarkerTiming: Selector<MarkerTiming[]> = createSelector(
     getMarkerGetter,
     getUserTimingMarkerIndexes,
-    getMarkerChartLabelGetter,
     MarkerTimingLogic.getMarkerTiming
   );
 

From 390fe35fdd9c844db28c8cdce441194e163c343c Mon Sep 17 00:00:00 2001
From: Julien Wajsberg <felash@gmail.com>
Date: Mon, 16 Sep 2024 17:18:16 +0200
Subject: [PATCH 5/5] Update tests

---
 .../store/__snapshots__/profile-view.test.js.snap   | 13 -------------
 src/test/store/actions.test.js                      |  4 ----
 src/test/store/markers.test.js                      | 11 -----------
 3 files changed, 28 deletions(-)

diff --git a/src/test/store/__snapshots__/profile-view.test.js.snap b/src/test/store/__snapshots__/profile-view.test.js.snap
index 9b4663e43e..34be6786a1 100644
--- a/src/test/store/__snapshots__/profile-view.test.js.snap
+++ b/src/test/store/__snapshots__/profile-view.test.js.snap
@@ -2007,9 +2007,6 @@ Array [
       3,
     ],
     "instantOnly": true,
-    "label": Array [
-      "",
-    ],
     "length": 1,
     "name": "D",
     "start": Array [
@@ -2025,9 +2022,6 @@ Array [
       4,
     ],
     "instantOnly": true,
-    "label": Array [
-      "",
-    ],
     "length": 1,
     "name": "E",
     "start": Array [
@@ -2043,9 +2037,6 @@ Array [
       5,
     ],
     "instantOnly": true,
-    "label": Array [
-      "",
-    ],
     "length": 1,
     "name": "F",
     "start": Array [
@@ -2063,10 +2054,6 @@ Array [
       7,
     ],
     "instantOnly": false,
-    "label": Array [
-      "https://mozilla.org",
-      "https://mozilla.org",
-    ],
     "length": 2,
     "name": "Network Requests",
     "start": Array [
diff --git a/src/test/store/actions.test.js b/src/test/store/actions.test.js
index eb6670a187..31a0ed22be 100644
--- a/src/test/store/actions.test.js
+++ b/src/test/store/actions.test.js
@@ -460,7 +460,6 @@ describe('selectors/getCombinedTimingRows', function () {
         start: [0],
         end: [10],
         index: [0],
-        label: ['renderFunction'],
         name: 'A',
         bucket: 'None',
         instantOnly: false,
@@ -470,7 +469,6 @@ describe('selectors/getCombinedTimingRows', function () {
         start: [1],
         end: [9],
         index: [1],
-        label: ['componentA'],
         name: 'A',
         bucket: 'None',
         instantOnly: false,
@@ -480,7 +478,6 @@ describe('selectors/getCombinedTimingRows', function () {
         start: [2],
         end: [6],
         index: [2],
-        label: ['componentB'],
         name: 'A',
         bucket: 'None',
         instantOnly: false,
@@ -490,7 +487,6 @@ describe('selectors/getCombinedTimingRows', function () {
         bucket: 'None',
         end: [4],
         index: [3],
-        label: ['componentC'],
         length: 1,
         name: 'A',
         start: [3],
diff --git a/src/test/store/markers.test.js b/src/test/store/markers.test.js
index 8ec23095c3..61450e3768 100644
--- a/src/test/store/markers.test.js
+++ b/src/test/store/markers.test.js
@@ -118,7 +118,6 @@ describe('selectors/getMarkerChartTimingAndBuckets', function () {
           start: [1],
           end: [1],
           index: [0],
-          label: [''],
           bucket: 'Other',
           instantOnly: true,
           length: 1,
@@ -169,10 +168,6 @@ describe('selectors/getMarkerChartTimingAndBuckets', function () {
           start: [1, 6],
           end: [5, 9],
           index: [0, 1],
-          label: [
-            'https://www.mozilla.org/',
-            'https://www.mozilla.org/image.jpg',
-          ],
           instantOnly: false,
           length: 2,
         },
@@ -192,7 +187,6 @@ describe('selectors/getMarkerChartTimingAndBuckets', function () {
           start: [3],
           end: [3],
           index: [1],
-          label: [''],
           instantOnly: true,
           length: 1,
         },
@@ -202,7 +196,6 @@ describe('selectors/getMarkerChartTimingAndBuckets', function () {
           start: [0],
           end: [1],
           index: [0],
-          label: ['https://mozilla.org'],
           instantOnly: false,
           length: 1,
         },
@@ -284,7 +277,6 @@ describe('selectors/getUserTimingMarkerTiming', function () {
         start: [6],
         end: [6],
         index: [3],
-        label: ['pointInTime'],
         name: 'UserTiming',
         bucket: 'None',
         instantOnly: true,
@@ -294,7 +286,6 @@ describe('selectors/getUserTimingMarkerTiming', function () {
         start: [0],
         end: [10],
         index: [0],
-        label: ['renderFunction'],
         name: 'UserTiming',
         bucket: 'None',
         instantOnly: false,
@@ -304,7 +295,6 @@ describe('selectors/getUserTimingMarkerTiming', function () {
         start: [1],
         end: [9],
         index: [1],
-        label: ['componentA'],
         name: 'UserTiming',
         bucket: 'None',
         instantOnly: false,
@@ -314,7 +304,6 @@ describe('selectors/getUserTimingMarkerTiming', function () {
         start: [2, 7],
         end: [5, 9],
         index: [2, 4],
-        label: ['componentB', 'componentC'],
         name: 'UserTiming',
         bucket: 'None',
         instantOnly: false,