From bdd2a1e7ddb267587b41b7b2ef22abd7e12a3492 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Naz=C4=B1m=20Can=20Alt=C4=B1nova?= Date: Thu, 6 Nov 2025 14:49:27 +0100 Subject: [PATCH 1/2] Migrate from Appveyor to GitHub Actions Windows runners --- .github/workflows/ci.yml | 11 +++++++++-- appveyor.yml | 37 ------------------------------------- 2 files changed, 9 insertions(+), 39 deletions(-) delete mode 100644 appveyor.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1421c56181..6e194068d8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,7 +22,10 @@ jobs: run: yarn lint tests: - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest, windows-latest] steps: - name: Checkout code uses: actions/checkout@v5 @@ -36,12 +39,16 @@ jobs: run: yarn test --coverage --logHeapUsage -w=4 --workerIdleMemoryLimit=1.5G - name: Upload coverage to Codecov + if: matrix.os == 'ubuntu-latest' uses: codecov/codecov-action@v5 with: fail_ci_if_error: false build-prod: - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest, windows-latest] steps: - name: Checkout code uses: actions/checkout@v5 diff --git a/appveyor.yml b/appveyor.yml deleted file mode 100644 index a9021d7b33..0000000000 --- a/appveyor.yml +++ /dev/null @@ -1,37 +0,0 @@ -image: Visual Studio 2022 -clone_depth: 5 -environment: - nodejs_version: '22.14' -platform: x64 # flow needs 64b platforms - -branches: - only: - - main - - production - -# Install scripts. (runs after repo cloning) -install: - # 1. Select the right node - # The following command works by fully reinstalling a version of node. It's a - # lot slower than the other command. This needs the full version (eg: 18.12) - - ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:platform - # Use the following command if the wanted version is already part of - # appveyor's windows machines, see https://www.appveyor.com/docs/windows-images-software/#node-js - # This needs the major version only (eg: 18) - # - ps: Install-Product node $env:nodejs_version $env:platform - # 2. Setup the project - - yarn install --frozen-lockfile - -# Post-install test scripts. -test_script: - # Output useful info for debugging. - - yarn versions - # run tests - - yarn test-all - - yarn build-prod:quiet - -cache: - - node_modules - -# Don't actually build. -build: off From 381b3e278cfc311f8d4129ac5a9c1d2f8ad11684 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Naz=C4=B1m=20Can=20Alt=C4=B1nova?= Date: Thu, 6 Nov 2025 15:34:33 +0100 Subject: [PATCH 2/2] Run other CI jobs in Windows as well --- .github/workflows/ci.yml | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6e194068d8..5772a2148b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,7 +10,10 @@ on: jobs: lint: - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest, windows-latest] steps: - name: Checkout code uses: actions/checkout@v5 @@ -63,7 +66,10 @@ jobs: run: yarn build-symbolicator-cli:quiet licence-check: - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest, windows-latest] steps: - name: Checkout code uses: actions/checkout@v5 @@ -75,7 +81,10 @@ jobs: run: yarn license-check typecheck: - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest, windows-latest] steps: - name: Checkout code uses: actions/checkout@v5 @@ -87,7 +96,10 @@ jobs: run: yarn ts alex: - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest, windows-latest] steps: - name: Checkout code uses: actions/checkout@v5 @@ -99,7 +111,10 @@ jobs: run: yarn test-alex yarn-lock: - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest, windows-latest] steps: - name: Checkout code uses: actions/checkout@v5