Merge pull request #230 from webidea24/fix/configurable-fallback

sprankhub · web-flow · commit 45153d7b4e3d · 2026-01-28T07:46:30.000+01:00
checkout: prevent configurable fallback on "0"-value
diff --git a/Plugin/Catalog/Helper/Product/Configuration/AddVisibleInCheckoutAttributesToCustomOptionsPlugin.php b/Plugin/Catalog/Helper/Product/Configuration/AddVisibleInCheckoutAttributesToCustomOptionsPlugin.php
@@ -84,7 +84,10 @@ public function afterGetCustomOptions(Configuration $configuration, array $custo
                 $children = $item->getChildren();
                 if ($children[0] instanceof AbstractItem && $children[0]->getProduct()) {
                     // fetch the attribute value of the child
-                    $value = $attributeFrontend->getValue($children[0]->getProduct()) ?: $value;
+                    $childValue = $attributeFrontend->getValue($children[0]->getProduct());
+                    // Be careful: "0" is a valid value for setting a yes/no attribute to false, so the check must be
+                    // against explicit null
+                    $value = $childValue === null ? $value : $childValue;
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,10 @@ public function afterGetCustomOptions(Configuration $configuration, array $custo`
`84`	`84`	`$children = $item->getChildren();`
`85`	`85`	`if ($children[0] instanceof AbstractItem && $children[0]->getProduct()) {`
`86`	`86`	`// fetch the attribute value of the child`
`87`		`- $value = $attributeFrontend->getValue($children[0]->getProduct()) ?: $value;`
	`87`	`+ $childValue = $attributeFrontend->getValue($children[0]->getProduct());`
	`88`	`+ // Be careful: "0" is a valid value for setting a yes/no attribute to false, so the check must be`
	`89`	`+ // against explicit null`
	`90`	`+ $value = $childValue === null ? $value : $childValue;`
`88`	`91`	`}`
`89`	`92`	`}`
`90`	`93`