From 6281bb34493b06a1a715f662996faafbadf0f919 Mon Sep 17 00:00:00 2001
From: Stuart Morgan <stuartmorgan@google.com>
Date: Thu, 13 Apr 2023 15:20:58 -0400
Subject: [PATCH] [shared_preferences] Remove Android lint baseline

All of the issues in the baseline file were stale, so it can just be
removed.

Part of https://github.com/flutter/flutter/issues/88011
---
 .../android/build.gradle                      |   1 -
 .../android/lint-baseline.xml                 | 125 ------------------
 2 files changed, 126 deletions(-)
 delete mode 100644 packages/shared_preferences/shared_preferences_android/android/lint-baseline.xml

diff --git a/packages/shared_preferences/shared_preferences_android/android/build.gradle b/packages/shared_preferences/shared_preferences_android/android/build.gradle
index 905150edf786..e7396887cff6 100644
--- a/packages/shared_preferences/shared_preferences_android/android/build.gradle
+++ b/packages/shared_preferences/shared_preferences_android/android/build.gradle
@@ -40,7 +40,6 @@ android {
         checkAllWarnings true
         warningsAsErrors true
         disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
-        baseline file("lint-baseline.xml")
     }
     dependencies {
         testImplementation 'junit:junit:4.13.2'
diff --git a/packages/shared_preferences/shared_preferences_android/android/lint-baseline.xml b/packages/shared_preferences/shared_preferences_android/android/lint-baseline.xml
deleted file mode 100644
index ca2bc158739f..000000000000
--- a/packages/shared_preferences/shared_preferences_android/android/lint-baseline.xml
+++ /dev/null
@@ -1,125 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 7.0.1" type="baseline" client="gradle" name="AGP (7.0.1)" variant="all" version="7.0.1">
-
-    <issue
-        id="CommitPrefEdits"
-        message="`SharedPreferences.edit()` without a corresponding `commit()` or `apply()` call"
-        errorLine1="          commitAsync(preferences.edit().putBoolean(key, (boolean) call.argument(&quot;value&quot;)), result);"
-        errorLine2="                      ~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src/main/java/io/flutter/plugins/sharedpreferences/MethodCallHandlerImpl.java"
-            line="66"
-            column="23"/>
-    </issue>
-
-    <issue
-        id="CommitPrefEdits"
-        message="`SharedPreferences.edit()` without a corresponding `commit()` or `apply()` call"
-        errorLine1="          commitAsync(preferences.edit().putString(key, DOUBLE_PREFIX + doubleValueStr), result);"
-        errorLine2="                      ~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src/main/java/io/flutter/plugins/sharedpreferences/MethodCallHandlerImpl.java"
-            line="71"
-            column="23"/>
-    </issue>
-
-    <issue
-        id="CommitPrefEdits"
-        message="`SharedPreferences.edit()` without a corresponding `commit()` or `apply()` call"
-        errorLine1="                preferences"
-        errorLine2="                ^">
-        <location
-            file="src/main/java/io/flutter/plugins/sharedpreferences/MethodCallHandlerImpl.java"
-            line="78"
-            column="17"/>
-    </issue>
-
-    <issue
-        id="CommitPrefEdits"
-        message="`SharedPreferences.edit()` without a corresponding `commit()` or `apply()` call"
-        errorLine1="            commitAsync(preferences.edit().putLong(key, number.longValue()), result);"
-        errorLine2="                        ~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src/main/java/io/flutter/plugins/sharedpreferences/MethodCallHandlerImpl.java"
-            line="84"
-            column="25"/>
-    </issue>
-
-    <issue
-        id="CommitPrefEdits"
-        message="`SharedPreferences.edit()` without a corresponding `commit()` or `apply()` call"
-        errorLine1="          commitAsync(preferences.edit().putString(key, value), result);"
-        errorLine2="                      ~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src/main/java/io/flutter/plugins/sharedpreferences/MethodCallHandlerImpl.java"
-            line="98"
-            column="23"/>
-    </issue>
-
-    <issue
-        id="CommitPrefEdits"
-        message="`SharedPreferences.edit()` without a corresponding `commit()` or `apply()` call"
-        errorLine1="              preferences.edit().putString(key, LIST_IDENTIFIER + encodeList(list)), result);"
-        errorLine2="              ~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src/main/java/io/flutter/plugins/sharedpreferences/MethodCallHandlerImpl.java"
-            line="103"
-            column="15"/>
-    </issue>
-
-    <issue
-        id="CommitPrefEdits"
-        message="`SharedPreferences.edit()` without a corresponding `commit()` or `apply()` call"
-        errorLine1="          commitAsync(preferences.edit().remove(key), result);"
-        errorLine2="                      ~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src/main/java/io/flutter/plugins/sharedpreferences/MethodCallHandlerImpl.java"
-            line="114"
-            column="23"/>
-    </issue>
-
-    <issue
-        id="SyntheticAccessor"
-        message="Access to `private` field `handler` of class `MethodCallHandlerImpl` requires synthetic accessor"
-        errorLine1="            handler.post("
-        errorLine2="            ~~~~~~~">
-        <location
-            file="src/main/java/io/flutter/plugins/sharedpreferences/MethodCallHandlerImpl.java"
-            line="146"
-            column="13"/>
-    </issue>
-
-    <issue
-        id="UnknownNullness"
-        message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://android.github.io/kotlin-guides/interop.html#nullability-annotations"
-        errorLine1="  public static void registerWith(io.flutter.plugin.common.PluginRegistry.Registrar registrar) {"
-        errorLine2="                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src/main/java/io/flutter/plugins/sharedpreferences/SharedPreferencesPlugin.java"
-            line="19"
-            column="35"/>
-    </issue>
-
-    <issue
-        id="UnknownNullness"
-        message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://android.github.io/kotlin-guides/interop.html#nullability-annotations"
-        errorLine1="  public void onAttachedToEngine(FlutterPlugin.FlutterPluginBinding binding) {"
-        errorLine2="                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src/main/java/io/flutter/plugins/sharedpreferences/SharedPreferencesPlugin.java"
-            line="25"
-            column="34"/>
-    </issue>
-
-    <issue
-        id="UnknownNullness"
-        message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://android.github.io/kotlin-guides/interop.html#nullability-annotations"
-        errorLine1="  public void onDetachedFromEngine(FlutterPlugin.FlutterPluginBinding binding) {"
-        errorLine2="                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src/main/java/io/flutter/plugins/sharedpreferences/SharedPreferencesPlugin.java"
-            line="30"
-            column="36"/>
-    </issue>
-
-</issues>