From 63c92823a0c7dfdae858b7b860599c3298456708 Mon Sep 17 00:00:00 2001 From: Stuart Morgan Date: Thu, 1 Aug 2024 14:26:21 -0400 Subject: [PATCH] [google_maps_flutter] Switch Android examples to TLHC The Android example apps were still using HC mode, from when that was the recommended option due to lost updates with TLHC. Now that the README strongly recommends using TLHC rather than HC, we should reflect that in our examples. This is both a user-facing change, since it's what shows on pub.dev and we want to set the right example there, and also cahnges our test coverage. Ideally we would test both, and an issue will be filed to explore that, but for as long as we are only testing one it should be the recommended option. --- packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md | 4 ++++ .../google_maps_flutter/example/lib/main.dart | 1 - packages/google_maps_flutter/google_maps_flutter/pubspec.yaml | 2 +- .../google_maps_flutter_android/CHANGELOG.md | 4 ++++ .../google_maps_flutter_android/example/lib/main.dart | 3 --- .../google_maps_flutter_android/pubspec.yaml | 2 +- 6 files changed, 10 insertions(+), 6 deletions(-) diff --git a/packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md b/packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md index c92f63deb0eb..78e2e457191e 100644 --- a/packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md +++ b/packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.7.1 + +* Updates the example app to use TLHC mode, per current package guidance. + ## 2.7.0 * Adds support for BitmapDescriptor classes `AssetMapBitmap` and `BytesMapBitmap`. diff --git a/packages/google_maps_flutter/google_maps_flutter/example/lib/main.dart b/packages/google_maps_flutter/google_maps_flutter/example/lib/main.dart index a0060e1c7254..a7bd320b5bf2 100644 --- a/packages/google_maps_flutter/google_maps_flutter/example/lib/main.dart +++ b/packages/google_maps_flutter/google_maps_flutter/example/lib/main.dart @@ -78,7 +78,6 @@ void main() { final GoogleMapsFlutterPlatform mapsImplementation = GoogleMapsFlutterPlatform.instance; if (mapsImplementation is GoogleMapsFlutterAndroid) { - mapsImplementation.useAndroidViewSurface = true; initializeMapRenderer(); } runApp(const MaterialApp(home: MapsDemo())); diff --git a/packages/google_maps_flutter/google_maps_flutter/pubspec.yaml b/packages/google_maps_flutter/google_maps_flutter/pubspec.yaml index 3ab5430b0955..c38f7e9c5839 100644 --- a/packages/google_maps_flutter/google_maps_flutter/pubspec.yaml +++ b/packages/google_maps_flutter/google_maps_flutter/pubspec.yaml @@ -2,7 +2,7 @@ name: google_maps_flutter description: A Flutter plugin for integrating Google Maps in iOS and Android applications. repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22 -version: 2.7.0 +version: 2.7.1 environment: sdk: ^3.4.0 diff --git a/packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md b/packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md index ea28432f9d37..fa0e4a06a869 100644 --- a/packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md +++ b/packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.12.2 + +* Updates the example app to use TLHC mode, per current package guidance. + ## 2.12.1 * Updates lint checks to ignore NewerVersionAvailable. diff --git a/packages/google_maps_flutter/google_maps_flutter_android/example/lib/main.dart b/packages/google_maps_flutter/google_maps_flutter_android/example/lib/main.dart index 16e1dfd59bb6..30665c1be23d 100644 --- a/packages/google_maps_flutter/google_maps_flutter_android/example/lib/main.dart +++ b/packages/google_maps_flutter/google_maps_flutter_android/example/lib/main.dart @@ -77,9 +77,6 @@ class MapsDemo extends StatelessWidget { } void main() { - final GoogleMapsFlutterPlatform platform = GoogleMapsFlutterPlatform.instance; - // Default to Hybrid Composition for the example. - (platform as GoogleMapsFlutterAndroid).useAndroidViewSurface = true; initializeMapRenderer(); runApp(const MaterialApp(home: MapsDemo())); } diff --git a/packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml b/packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml index 1d63d05991b6..f4924aef5f48 100644 --- a/packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml +++ b/packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml @@ -2,7 +2,7 @@ name: google_maps_flutter_android description: Android implementation of the google_maps_flutter plugin. repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_android issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22 -version: 2.12.1 +version: 2.12.2 environment: sdk: ^3.4.0