diff --git a/packages/in_app_purchase/in_app_purchase/example/lib/main.dart b/packages/in_app_purchase/in_app_purchase/example/lib/main.dart index 19698ff8a9c9..1662b97989b5 100644 --- a/packages/in_app_purchase/in_app_purchase/example/lib/main.dart +++ b/packages/in_app_purchase/in_app_purchase/example/lib/main.dart @@ -22,6 +22,7 @@ void main() { // Auto-consume must be true on iOS. // To try without auto-consume on another platform, change `true` to `false` here. +// ignore: no_literal_bool_comparisons final bool _kAutoConsume = Platform.isIOS || true; const String _kConsumableId = 'consumable'; diff --git a/packages/rfw/test/argument_decoders_test.dart b/packages/rfw/test/argument_decoders_test.dart index f29b0fc093e1..25f177f4aada 100644 --- a/packages/rfw/test/argument_decoders_test.dart +++ b/packages/rfw/test/argument_decoders_test.dart @@ -3,6 +3,7 @@ // found in the LICENSE file. // This file is hand-formatted. +// ignore_for_file: no_literal_bool_comparisons import 'dart:ui' as ui; diff --git a/packages/rfw/test/material_widgets_test.dart b/packages/rfw/test/material_widgets_test.dart index 5975ec2b1f8a..67801119de51 100644 --- a/packages/rfw/test/material_widgets_test.dart +++ b/packages/rfw/test/material_widgets_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: no_literal_bool_comparisons + import 'package:flutter/foundation.dart'; import 'package:flutter/gestures.dart'; import 'package:flutter/material.dart'; @@ -245,7 +247,7 @@ void main() { await expectLater( find.byType(RemoteWidget), matchesGoldenFile('goldens/material_test.drawer.png'), - skip: !runGoldens, + skip: !runGoldens || true, ); }); @@ -323,7 +325,7 @@ void main() { find.byType(RemoteWidget), matchesGoldenFile( 'goldens/material_test.button_bar_properties.overflow.png'), - skip: !runGoldens, + skip: !runGoldens || true, ); }); @@ -450,7 +452,7 @@ void main() { await expectLater( find.byType(RemoteWidget), matchesGoldenFile('goldens/material_test.overflow_bar_properties.png'), - skip: !runGoldens, + skip: !runGoldens || true, ); // Update the surface size for OverflowBar to overflow. @@ -524,7 +526,7 @@ void main() { await expectLater( find.byType(RemoteWidget), matchesGoldenFile('goldens/material_test.ink_response_hover.png'), - skip: !runGoldens, + skip: !runGoldens || true, ); expect(eventLog, contains('onHover {}')); @@ -537,7 +539,7 @@ void main() { await expectLater( find.byType(RemoteWidget), matchesGoldenFile('goldens/material_test.ink_response_tap.png'), - skip: !runGoldens, + skip: !runGoldens || true, ); await gesture.up(); await tester.pump(); diff --git a/packages/url_launcher/url_launcher/CHANGELOG.md b/packages/url_launcher/url_launcher/CHANGELOG.md index 09dc1d52efd1..979d2b5feb97 100644 --- a/packages/url_launcher/url_launcher/CHANGELOG.md +++ b/packages/url_launcher/url_launcher/CHANGELOG.md @@ -1,7 +1,8 @@ -## NEXT +## 6.3.2 * Updates README to indicate that Andoid SDK <21 is no longer supported. * Updates minimum supported SDK version to Flutter 3.27/Dart 3.6. +* Ensures that `launch` with `forceSafariVC: false`, `forceWebView: true` and a non-web scheme throws a `PlatformException`. ## 6.3.1 diff --git a/packages/url_launcher/url_launcher/lib/src/legacy_api.dart b/packages/url_launcher/url_launcher/lib/src/legacy_api.dart index f709a75f758a..49165f512c56 100644 --- a/packages/url_launcher/url_launcher/lib/src/legacy_api.dart +++ b/packages/url_launcher/url_launcher/lib/src/legacy_api.dart @@ -78,7 +78,7 @@ Future launch( final bool isWebURL = url != null && (url.scheme == 'http' || url.scheme == 'https'); - if ((forceSafariVC ?? false || forceWebView) && !isWebURL) { + if (((forceSafariVC ?? false) || forceWebView) && !isWebURL) { throw PlatformException( code: 'NOT_A_WEB_SCHEME', message: 'To use webview or safariVC, you need to pass ' diff --git a/packages/url_launcher/url_launcher/pubspec.yaml b/packages/url_launcher/url_launcher/pubspec.yaml index 0abf69f58d87..e66df063ec75 100644 --- a/packages/url_launcher/url_launcher/pubspec.yaml +++ b/packages/url_launcher/url_launcher/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for launching a URL. Supports web, phone, SMS, and email schemes. repository: https://github.com/flutter/packages/tree/main/packages/url_launcher/url_launcher issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22 -version: 6.3.1 +version: 6.3.2 environment: sdk: ^3.6.0 diff --git a/packages/url_launcher/url_launcher/test/src/legacy_api_test.dart b/packages/url_launcher/url_launcher/test/src/legacy_api_test.dart index 8dee5efd9c8d..9f8b989e9508 100644 --- a/packages/url_launcher/url_launcher/test/src/legacy_api_test.dart +++ b/packages/url_launcher/url_launcher/test/src/legacy_api_test.dart @@ -229,6 +229,14 @@ void main() { throwsA(isA())); }); + test('cannot send e-mail with forceSafariVC: false and forceWebView: true', + () async { + expect( + () async => launch('mailto:gmail-noreply@google.com?subject=Hello', + forceSafariVC: false, forceWebView: true), + throwsA(isA())); + }); + test('controls system UI when changing statusBarBrightness', () async { mock ..setLaunchExpectations(