From 09802c04795b88e72248343e03f2c6979ab2a49a Mon Sep 17 00:00:00 2001 From: Aditya Thakur Date: Wed, 6 Oct 2021 11:44:38 +0530 Subject: [PATCH 1/6] Added flutter_lints to all pubspec --- melos.yaml | 2 +- packages/android_alarm_manager_plus/example/pubspec.yaml | 2 +- packages/android_alarm_manager_plus/pubspec.yaml | 2 +- packages/android_intent_plus/example/pubspec.yaml | 2 +- packages/android_intent_plus/pubspec.yaml | 2 +- packages/battery_plus/battery_plus/example/pubspec.yaml | 2 +- packages/battery_plus/battery_plus/pubspec.yaml | 2 +- packages/battery_plus/battery_plus_linux/pubspec.yaml | 2 +- .../battery_plus/battery_plus_platform_interface/pubspec.yaml | 2 +- .../connectivity_plus/connectivity_plus/example/pubspec.yaml | 2 +- packages/connectivity_plus/connectivity_plus/pubspec.yaml | 2 +- packages/connectivity_plus/connectivity_plus_linux/pubspec.yaml | 2 +- .../connectivity_plus_platform_interface/pubspec.yaml | 2 +- packages/connectivity_plus/connectivity_plus_web/pubspec.yaml | 2 +- packages/device_info_plus/device_info_plus/example/pubspec.yaml | 2 +- packages/device_info_plus/device_info_plus/pubspec.yaml | 2 +- packages/device_info_plus/device_info_plus_linux/pubspec.yaml | 2 +- .../device_info_plus_platform_interface/pubspec.yaml | 2 +- packages/device_info_plus/device_info_plus_web/pubspec.yaml | 2 +- .../network_info_plus/network_info_plus/example/pubspec.yaml | 2 +- packages/network_info_plus/network_info_plus/pubspec.yaml | 2 +- packages/network_info_plus/network_info_plus_linux/pubspec.yaml | 2 +- .../network_info_plus_platform_interface/pubspec.yaml | 2 +- .../network_info_plus/network_info_plus_windows/pubspec.yaml | 2 +- .../package_info_plus/package_info_plus/example/pubspec.yaml | 2 +- packages/package_info_plus/package_info_plus/pubspec.yaml | 2 +- packages/package_info_plus/package_info_plus_linux/pubspec.yaml | 2 +- .../package_info_plus_platform_interface/pubspec.yaml | 2 +- packages/package_info_plus/package_info_plus_web/pubspec.yaml | 2 +- .../package_info_plus/package_info_plus_windows/pubspec.yaml | 2 +- packages/sensors_plus/sensors_plus/example/pubspec.yaml | 2 +- packages/sensors_plus/sensors_plus/pubspec.yaml | 2 +- .../sensors_plus/sensors_plus_platform_interface/pubspec.yaml | 2 +- packages/sensors_plus/sensors_plus_web/pubspec.yaml | 2 +- packages/share_plus/share_plus/example/pubspec.yaml | 2 +- packages/share_plus/share_plus/pubspec.yaml | 2 +- packages/share_plus/share_plus_linux/pubspec.yaml | 2 +- packages/share_plus/share_plus_macos/pubspec.yaml | 2 +- packages/share_plus/share_plus_platform_interface/pubspec.yaml | 2 +- packages/share_plus/share_plus_web/pubspec.yaml | 2 +- packages/share_plus/share_plus_windows/pubspec.yaml | 2 +- 41 files changed, 41 insertions(+), 41 deletions(-) diff --git a/melos.yaml b/melos.yaml index 577e4f96ee..a24e59a092 100644 --- a/melos.yaml +++ b/melos.yaml @@ -243,7 +243,7 @@ scripts: melos exec -c 6 -- "flutter clean" dev_dependencies: - pedantic: 1.10.0 + flutter_lints: 1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/android_alarm_manager_plus/example/pubspec.yaml b/packages/android_alarm_manager_plus/example/pubspec.yaml index cc25168fc7..377b0a6cb3 100644 --- a/packages/android_alarm_manager_plus/example/pubspec.yaml +++ b/packages/android_alarm_manager_plus/example/pubspec.yaml @@ -20,7 +20,7 @@ dev_dependencies: sdk: flutter flutter_test: sdk: flutter - pedantic: ^1.9.2 + flutter_lints: ^1.0.4 flutter: uses-material-design: true diff --git a/packages/android_alarm_manager_plus/pubspec.yaml b/packages/android_alarm_manager_plus/pubspec.yaml index b8e99c5472..a7180fc3b7 100644 --- a/packages/android_alarm_manager_plus/pubspec.yaml +++ b/packages/android_alarm_manager_plus/pubspec.yaml @@ -12,7 +12,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 flutter: plugin: diff --git a/packages/android_intent_plus/example/pubspec.yaml b/packages/android_intent_plus/example/pubspec.yaml index e85ba191ee..b2255f164e 100644 --- a/packages/android_intent_plus/example/pubspec.yaml +++ b/packages/android_intent_plus/example/pubspec.yaml @@ -15,7 +15,7 @@ dev_dependencies: sdk: flutter integration_test: sdk: flutter - pedantic: ^1.8.0 + flutter_lints: ^1.0.4 # The following section is specific to Flutter. flutter: diff --git a/packages/android_intent_plus/pubspec.yaml b/packages/android_intent_plus/pubspec.yaml index 578316d946..50a9642e23 100644 --- a/packages/android_intent_plus/pubspec.yaml +++ b/packages/android_intent_plus/pubspec.yaml @@ -26,4 +26,4 @@ dev_dependencies: sdk: flutter test: ^1.16.4 mockito: ^5.0.0 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 diff --git a/packages/battery_plus/battery_plus/example/pubspec.yaml b/packages/battery_plus/battery_plus/example/pubspec.yaml index d7deba9736..d5ab622760 100644 --- a/packages/battery_plus/battery_plus/example/pubspec.yaml +++ b/packages/battery_plus/battery_plus/example/pubspec.yaml @@ -15,7 +15,7 @@ dev_dependencies: sdk: flutter integration_test: sdk: flutter - pedantic: ^1.9.2 + flutter_lints: ^1.0.4 dependency_overrides: args: ^2.0.0 diff --git a/packages/battery_plus/battery_plus/pubspec.yaml b/packages/battery_plus/battery_plus/pubspec.yaml index c6e0d498a9..9e2db3544d 100644 --- a/packages/battery_plus/battery_plus/pubspec.yaml +++ b/packages/battery_plus/battery_plus/pubspec.yaml @@ -38,7 +38,7 @@ dev_dependencies: async: ^2.5.0 plugin_platform_interface: ^2.0.0 test: ^1.16.4 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/battery_plus/battery_plus_linux/pubspec.yaml b/packages/battery_plus/battery_plus_linux/pubspec.yaml index 65080b11f8..bc50d334c8 100644 --- a/packages/battery_plus/battery_plus_linux/pubspec.yaml +++ b/packages/battery_plus/battery_plus_linux/pubspec.yaml @@ -18,7 +18,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 flutter: plugin: diff --git a/packages/battery_plus/battery_plus_platform_interface/pubspec.yaml b/packages/battery_plus/battery_plus_platform_interface/pubspec.yaml index ffbaa5a6ae..e3cf1e2197 100644 --- a/packages/battery_plus/battery_plus_platform_interface/pubspec.yaml +++ b/packages/battery_plus/battery_plus_platform_interface/pubspec.yaml @@ -17,4 +17,4 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 diff --git a/packages/connectivity_plus/connectivity_plus/example/pubspec.yaml b/packages/connectivity_plus/connectivity_plus/example/pubspec.yaml index 6806a94093..1ea8a57a35 100644 --- a/packages/connectivity_plus/connectivity_plus/example/pubspec.yaml +++ b/packages/connectivity_plus/connectivity_plus/example/pubspec.yaml @@ -16,7 +16,7 @@ dev_dependencies: integration_test: sdk: flutter test: ^1.16.4 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 dependency_overrides: args: ^2.0.0 diff --git a/packages/connectivity_plus/connectivity_plus/pubspec.yaml b/packages/connectivity_plus/connectivity_plus/pubspec.yaml index a7734734c0..10b223e83a 100644 --- a/packages/connectivity_plus/connectivity_plus/pubspec.yaml +++ b/packages/connectivity_plus/connectivity_plus/pubspec.yaml @@ -41,4 +41,4 @@ dev_dependencies: test: ^1.16.4 mockito: ^5.0.0 plugin_platform_interface: ^2.0.0 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 diff --git a/packages/connectivity_plus/connectivity_plus_linux/pubspec.yaml b/packages/connectivity_plus/connectivity_plus_linux/pubspec.yaml index 60182f9da7..ad1a82ea0e 100644 --- a/packages/connectivity_plus/connectivity_plus_linux/pubspec.yaml +++ b/packages/connectivity_plus/connectivity_plus_linux/pubspec.yaml @@ -21,7 +21,7 @@ dev_dependencies: sdk: flutter build_runner: ^1.11.5 mockito: ^5.0.0 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 flutter: plugin: diff --git a/packages/connectivity_plus/connectivity_plus_platform_interface/pubspec.yaml b/packages/connectivity_plus/connectivity_plus_platform_interface/pubspec.yaml index 5f86ebabb0..9c77097f1b 100644 --- a/packages/connectivity_plus/connectivity_plus_platform_interface/pubspec.yaml +++ b/packages/connectivity_plus/connectivity_plus_platform_interface/pubspec.yaml @@ -17,4 +17,4 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 diff --git a/packages/connectivity_plus/connectivity_plus_web/pubspec.yaml b/packages/connectivity_plus/connectivity_plus_web/pubspec.yaml index ca7148ebb4..21e53ddb46 100644 --- a/packages/connectivity_plus/connectivity_plus_web/pubspec.yaml +++ b/packages/connectivity_plus/connectivity_plus_web/pubspec.yaml @@ -26,4 +26,4 @@ dev_dependencies: test: ^1.16.4 flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 diff --git a/packages/device_info_plus/device_info_plus/example/pubspec.yaml b/packages/device_info_plus/device_info_plus/example/pubspec.yaml index 458801c370..450d26e5cf 100644 --- a/packages/device_info_plus/device_info_plus/example/pubspec.yaml +++ b/packages/device_info_plus/device_info_plus/example/pubspec.yaml @@ -12,7 +12,7 @@ dev_dependencies: sdk: flutter integration_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 flutter: uses-material-design: true diff --git a/packages/device_info_plus/device_info_plus/pubspec.yaml b/packages/device_info_plus/device_info_plus/pubspec.yaml index 5972995c7a..1e7feaebd7 100644 --- a/packages/device_info_plus/device_info_plus/pubspec.yaml +++ b/packages/device_info_plus/device_info_plus/pubspec.yaml @@ -35,7 +35,7 @@ dev_dependencies: test: ^1.16.4 flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/device_info_plus/device_info_plus_linux/pubspec.yaml b/packages/device_info_plus/device_info_plus_linux/pubspec.yaml index f432686334..8f43e23732 100644 --- a/packages/device_info_plus/device_info_plus_linux/pubspec.yaml +++ b/packages/device_info_plus/device_info_plus_linux/pubspec.yaml @@ -18,4 +18,4 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 diff --git a/packages/device_info_plus/device_info_plus_platform_interface/pubspec.yaml b/packages/device_info_plus/device_info_plus_platform_interface/pubspec.yaml index 9e9681a876..d8a76a1799 100644 --- a/packages/device_info_plus/device_info_plus_platform_interface/pubspec.yaml +++ b/packages/device_info_plus/device_info_plus_platform_interface/pubspec.yaml @@ -14,7 +14,7 @@ dev_dependencies: flutter_test: sdk: flutter mockito: ^5.0.0 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/device_info_plus/device_info_plus_web/pubspec.yaml b/packages/device_info_plus/device_info_plus_web/pubspec.yaml index 998a8c7aae..51412037c9 100644 --- a/packages/device_info_plus/device_info_plus_web/pubspec.yaml +++ b/packages/device_info_plus/device_info_plus_web/pubspec.yaml @@ -23,7 +23,7 @@ dev_dependencies: flutter_test: sdk: flutter mockito: ^5.0.0 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/network_info_plus/network_info_plus/example/pubspec.yaml b/packages/network_info_plus/network_info_plus/example/pubspec.yaml index 488b43546a..7e4fbdae7d 100644 --- a/packages/network_info_plus/network_info_plus/example/pubspec.yaml +++ b/packages/network_info_plus/network_info_plus/example/pubspec.yaml @@ -16,7 +16,7 @@ dev_dependencies: integration_test: sdk: flutter test: ^1.16.4 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 dependency_overrides: args: ^2.0.0 diff --git a/packages/network_info_plus/network_info_plus/pubspec.yaml b/packages/network_info_plus/network_info_plus/pubspec.yaml index 7c310c053a..6268636008 100644 --- a/packages/network_info_plus/network_info_plus/pubspec.yaml +++ b/packages/network_info_plus/network_info_plus/pubspec.yaml @@ -37,7 +37,7 @@ dev_dependencies: test: ^1.16.4 mockito: ^5.0.0 plugin_platform_interface: ^2.0.0 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/network_info_plus/network_info_plus_linux/pubspec.yaml b/packages/network_info_plus/network_info_plus_linux/pubspec.yaml index ce0760a69e..a1a471f211 100644 --- a/packages/network_info_plus/network_info_plus_linux/pubspec.yaml +++ b/packages/network_info_plus/network_info_plus_linux/pubspec.yaml @@ -19,7 +19,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 flutter: plugin: diff --git a/packages/network_info_plus/network_info_plus_platform_interface/pubspec.yaml b/packages/network_info_plus/network_info_plus_platform_interface/pubspec.yaml index 9f5fe60a5d..94ddaf1be3 100644 --- a/packages/network_info_plus/network_info_plus_platform_interface/pubspec.yaml +++ b/packages/network_info_plus/network_info_plus_platform_interface/pubspec.yaml @@ -13,7 +13,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/network_info_plus/network_info_plus_windows/pubspec.yaml b/packages/network_info_plus/network_info_plus_windows/pubspec.yaml index d294795e90..eff327df0e 100644 --- a/packages/network_info_plus/network_info_plus_windows/pubspec.yaml +++ b/packages/network_info_plus/network_info_plus_windows/pubspec.yaml @@ -15,7 +15,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 flutter: plugin: diff --git a/packages/package_info_plus/package_info_plus/example/pubspec.yaml b/packages/package_info_plus/package_info_plus/example/pubspec.yaml index ac82744c66..5d753a2671 100644 --- a/packages/package_info_plus/package_info_plus/example/pubspec.yaml +++ b/packages/package_info_plus/package_info_plus/example/pubspec.yaml @@ -19,7 +19,7 @@ dev_dependencies: integration_test: sdk: flutter test: any - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 flutter: uses-material-design: true diff --git a/packages/package_info_plus/package_info_plus/pubspec.yaml b/packages/package_info_plus/package_info_plus/pubspec.yaml index 2560fd294f..05fd7d6b20 100644 --- a/packages/package_info_plus/package_info_plus/pubspec.yaml +++ b/packages/package_info_plus/package_info_plus/pubspec.yaml @@ -34,7 +34,7 @@ dev_dependencies: flutter_test: sdk: flutter test: ^1.16.4 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/package_info_plus/package_info_plus_linux/pubspec.yaml b/packages/package_info_plus/package_info_plus_linux/pubspec.yaml index edd450e8b4..8c38b792a6 100644 --- a/packages/package_info_plus/package_info_plus_linux/pubspec.yaml +++ b/packages/package_info_plus/package_info_plus_linux/pubspec.yaml @@ -17,4 +17,4 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 diff --git a/packages/package_info_plus/package_info_plus_platform_interface/pubspec.yaml b/packages/package_info_plus/package_info_plus_platform_interface/pubspec.yaml index 4eb34baead..9205a934a7 100644 --- a/packages/package_info_plus/package_info_plus_platform_interface/pubspec.yaml +++ b/packages/package_info_plus/package_info_plus_platform_interface/pubspec.yaml @@ -14,7 +14,7 @@ dev_dependencies: flutter_test: sdk: flutter mockito: ^5.0.0 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/package_info_plus/package_info_plus_web/pubspec.yaml b/packages/package_info_plus/package_info_plus_web/pubspec.yaml index c036615d4e..7d1e412583 100644 --- a/packages/package_info_plus/package_info_plus_web/pubspec.yaml +++ b/packages/package_info_plus/package_info_plus_web/pubspec.yaml @@ -25,7 +25,7 @@ dev_dependencies: sdk: flutter mockito: ^5.0.7 build_runner: ^2.0.3 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/package_info_plus/package_info_plus_windows/pubspec.yaml b/packages/package_info_plus/package_info_plus_windows/pubspec.yaml index 04240684fe..7476f9b85a 100644 --- a/packages/package_info_plus/package_info_plus_windows/pubspec.yaml +++ b/packages/package_info_plus/package_info_plus_windows/pubspec.yaml @@ -18,4 +18,4 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 diff --git a/packages/sensors_plus/sensors_plus/example/pubspec.yaml b/packages/sensors_plus/sensors_plus/example/pubspec.yaml index bf75bf6fe1..c2b100e8b3 100644 --- a/packages/sensors_plus/sensors_plus/example/pubspec.yaml +++ b/packages/sensors_plus/sensors_plus/example/pubspec.yaml @@ -12,7 +12,7 @@ dev_dependencies: sdk: flutter integration_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 flutter: uses-material-design: true diff --git a/packages/sensors_plus/sensors_plus/pubspec.yaml b/packages/sensors_plus/sensors_plus/pubspec.yaml index 2ccfec5776..dd8f8786f1 100644 --- a/packages/sensors_plus/sensors_plus/pubspec.yaml +++ b/packages/sensors_plus/sensors_plus/pubspec.yaml @@ -27,7 +27,7 @@ dev_dependencies: test: ^1.16.4 flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/sensors_plus/sensors_plus_platform_interface/pubspec.yaml b/packages/sensors_plus/sensors_plus_platform_interface/pubspec.yaml index c6790a0920..02a6151d09 100644 --- a/packages/sensors_plus/sensors_plus_platform_interface/pubspec.yaml +++ b/packages/sensors_plus/sensors_plus_platform_interface/pubspec.yaml @@ -13,7 +13,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 test: ^1.16.4 environment: diff --git a/packages/sensors_plus/sensors_plus_web/pubspec.yaml b/packages/sensors_plus/sensors_plus_web/pubspec.yaml index f735b4f3d6..68aa62cc6b 100644 --- a/packages/sensors_plus/sensors_plus_web/pubspec.yaml +++ b/packages/sensors_plus/sensors_plus_web/pubspec.yaml @@ -26,4 +26,4 @@ dev_dependencies: test: ^1.16.4 flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 diff --git a/packages/share_plus/share_plus/example/pubspec.yaml b/packages/share_plus/share_plus/example/pubspec.yaml index e73c9e6665..5ae4f85640 100644 --- a/packages/share_plus/share_plus/example/pubspec.yaml +++ b/packages/share_plus/share_plus/example/pubspec.yaml @@ -13,7 +13,7 @@ dev_dependencies: sdk: flutter integration_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 flutter: uses-material-design: true diff --git a/packages/share_plus/share_plus/pubspec.yaml b/packages/share_plus/share_plus/pubspec.yaml index f590ce2cde..e55d0e8358 100644 --- a/packages/share_plus/share_plus/pubspec.yaml +++ b/packages/share_plus/share_plus/pubspec.yaml @@ -35,7 +35,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/share_plus/share_plus_linux/pubspec.yaml b/packages/share_plus/share_plus_linux/pubspec.yaml index f97207f741..8fe597ca3b 100644 --- a/packages/share_plus/share_plus_linux/pubspec.yaml +++ b/packages/share_plus/share_plus_linux/pubspec.yaml @@ -19,5 +19,5 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 url_launcher_platform_interface: ^2.0.2 diff --git a/packages/share_plus/share_plus_macos/pubspec.yaml b/packages/share_plus/share_plus_macos/pubspec.yaml index ef94b81786..b6b1320572 100644 --- a/packages/share_plus/share_plus_macos/pubspec.yaml +++ b/packages/share_plus/share_plus_macos/pubspec.yaml @@ -16,7 +16,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 flutter: plugin: diff --git a/packages/share_plus/share_plus_platform_interface/pubspec.yaml b/packages/share_plus/share_plus_platform_interface/pubspec.yaml index a3b122530a..1d0a910a01 100644 --- a/packages/share_plus/share_plus_platform_interface/pubspec.yaml +++ b/packages/share_plus/share_plus_platform_interface/pubspec.yaml @@ -15,7 +15,7 @@ dev_dependencies: flutter_test: sdk: flutter mockito: ^5.0.0 - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 test: ^1.16.4 environment: diff --git a/packages/share_plus/share_plus_web/pubspec.yaml b/packages/share_plus/share_plus_web/pubspec.yaml index dbf932c138..c3028dd855 100644 --- a/packages/share_plus/share_plus_web/pubspec.yaml +++ b/packages/share_plus/share_plus_web/pubspec.yaml @@ -23,7 +23,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/share_plus/share_plus_windows/pubspec.yaml b/packages/share_plus/share_plus_windows/pubspec.yaml index b0f74d9736..1fcdba4684 100644 --- a/packages/share_plus/share_plus_windows/pubspec.yaml +++ b/packages/share_plus/share_plus_windows/pubspec.yaml @@ -18,5 +18,5 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - pedantic: ^1.10.0 + flutter_lints: ^1.0.4 url_launcher_platform_interface: ^2.0.2 From 81ad0ab4a2c4f2ae14919f2e27af58ccc51ecba2 Mon Sep 17 00:00:00 2001 From: Aditya Thakur Date: Wed, 6 Oct 2021 11:52:47 +0530 Subject: [PATCH 2/6] Modified analysis_options --- analysis_options.yaml | 15 +++------------ .../example/analysis_options.yaml | 13 +++---------- 2 files changed, 6 insertions(+), 22 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index 67c406f74b..e0ec2f5873 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -4,18 +4,9 @@ # # include: ../../analysis_options.yaml # -include: package:pedantic/analysis_options.yaml - -analyzer: - enable-experiment: - - non-nullable - exclude: - # Ignore generated files - - '**/*.g.dart' - - 'lib/src/generated/*.dart' +include: package:flutter_lints/flutter.yaml linter: rules: - public_member_api_docs: true - prefer_final_in_for_each: true - prefer_final_locals: true + - prefer_final_in_for_each + - prefer_final_locals diff --git a/packages/android_intent_plus/example/analysis_options.yaml b/packages/android_intent_plus/example/analysis_options.yaml index c48c349fce..8b38242f71 100644 --- a/packages/android_intent_plus/example/analysis_options.yaml +++ b/packages/android_intent_plus/example/analysis_options.yaml @@ -1,14 +1,7 @@ # TODO: Remove this when migrated to null safety -include: package:pedantic/analysis_options.yaml - -analyzer: - exclude: - # Ignore generated files - - '**/*.g.dart' - - 'lib/src/generated/*.dart' +include: package:flutter_lints/flutter.yaml linter: rules: - public_member_api_docs: true - prefer_final_in_for_each: true - prefer_final_locals: true + - prefer_final_in_for_each + - prefer_final_locals From 8445dfff3ab1cb5cda21a785dd38f0bc640120f1 Mon Sep 17 00:00:00 2001 From: Aditya Thakur Date: Wed, 6 Oct 2021 13:22:14 +0530 Subject: [PATCH 3/6] Ignored print in production --- analysis_options.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/analysis_options.yaml b/analysis_options.yaml index e0ec2f5873..67bf994280 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -6,6 +6,15 @@ # include: package:flutter_lints/flutter.yaml +analyzer: + exclude: + # Ignore generated files + - '**/*.g.dart' + - 'lib/src/generated/*.dart' + + errors: + avoid_print: ignore + linter: rules: - prefer_final_in_for_each From eca459b8e58b0b88158ecef95e2889bc98177dd1 Mon Sep 17 00:00:00 2001 From: Aditya Thakur Date: Wed, 6 Oct 2021 16:12:04 +0530 Subject: [PATCH 4/6] melos run analyze success --- .../example/lib/main.dart | 15 ++++--- .../android_alarm_manager_plus_e2e.dart | 6 +-- .../lib/android_alarm_manager_plus.dart | 6 ++- .../test/android_alarm_manager_test.dart | 41 ++++++++++--------- .../android_intent_plus/example/lib/main.dart | 19 +++++---- .../test_driver/android_intent_plus_e2e.dart | 8 ++-- packages/android_intent_plus/lib/flag.dart | 3 ++ .../battery_plus/example/lib/main.dart | 8 ++-- .../example/test/widget_test.dart | 2 +- .../lib/src/battery_plus_linux_real.dart | 2 +- .../lib/method_channel_battery_plus.dart | 2 + .../connectivity_plus/example/lib/main.dart | 8 ++-- .../lib/src/connectivity_real.dart | 1 + .../lib/method_channel_connectivity.dart | 4 +- ...k_information_api_connectivity_plugin.dart | 1 + .../device_info_plus/example/lib/main.dart | 4 +- .../lib/src/device_info.dart | 2 +- .../method_channel_device_info.dart | 2 +- .../network_info_plus/example/lib/main.dart | 8 ++-- .../lib/src/network_info_real.dart | 1 + .../lib/method_channel_network_info.dart | 2 +- .../test_driver/package_info_plus_e2e.dart | 1 + .../test/package_info_plus_web_test.dart | 1 + .../package_info_plus_web_test.mocks.dart | 2 + .../lib/src/file_version_info.dart | 1 + .../sensors_plus/example/lib/main.dart | 8 ++-- .../sensors_plus/example/lib/snake.dart | 4 +- .../example/lib/image_previews.dart | 4 +- .../share_plus/example/lib/main.dart | 8 ++-- .../share_plus_platform_interface_test.dart | 4 +- .../share_plus_web/lib/share_plus_web.dart | 1 + 31 files changed, 109 insertions(+), 70 deletions(-) diff --git a/packages/android_alarm_manager_plus/example/lib/main.dart b/packages/android_alarm_manager_plus/example/lib/main.dart index 3f4525ee7e..fe992b989b 100644 --- a/packages/android_alarm_manager_plus/example/lib/main.dart +++ b/packages/android_alarm_manager_plus/example/lib/main.dart @@ -25,6 +25,7 @@ final ReceivePort port = ReceivePort(); SharedPreferences prefs; Future main() async { + // ignore: todo // TODO(bkonyi): uncomment WidgetsFlutterBinding.ensureInitialized(); @@ -38,15 +39,17 @@ Future main() async { if (!prefs.containsKey(countKey)) { await prefs.setInt(countKey, 0); } - runApp(AlarmManagerExampleApp()); + runApp(const AlarmManagerExampleApp()); } /// Example app for Espresso plugin. class AlarmManagerExampleApp extends StatelessWidget { + const AlarmManagerExampleApp({Key key}) : super(key: key); + // This widget is the root of your application. @override Widget build(BuildContext context) { - return MaterialApp( + return const MaterialApp( title: 'Flutter Demo', home: _AlarmHomePage(title: 'Flutter Demo Home Page'), ); @@ -54,7 +57,7 @@ class AlarmManagerExampleApp extends StatelessWidget { } class _AlarmHomePage extends StatefulWidget { - _AlarmHomePage({Key key, this.title}) : super(key: key); + const _AlarmHomePage({Key key, this.title}) : super(key: key); final String title; @override @@ -126,13 +129,13 @@ class _AlarmHomePageState extends State<_AlarmHomePage> { ), Text( prefs.getInt(countKey).toString(), - key: ValueKey('BackgroundCountText'), + key: const ValueKey('BackgroundCountText'), style: textStyle, ), ], ), ElevatedButton( - key: ValueKey('RegisterOneShotAlarm'), + key: const ValueKey('RegisterOneShotAlarm'), onPressed: () async { await AndroidAlarmManager.oneShot( const Duration(seconds: 5), @@ -143,7 +146,7 @@ class _AlarmHomePageState extends State<_AlarmHomePage> { wakeup: true, ); }, - child: Text( + child: const Text( 'Schedule OneShot Alarm', ), ), diff --git a/packages/android_alarm_manager_plus/example/test_driver/android_alarm_manager_plus_e2e.dart b/packages/android_alarm_manager_plus/example/test_driver/android_alarm_manager_plus_e2e.dart index 862be800be..3a376d35d4 100644 --- a/packages/android_alarm_manager_plus/example/test_driver/android_alarm_manager_plus_e2e.dart +++ b/packages/android_alarm_manager_plus/example/test_driver/android_alarm_manager_plus_e2e.dart @@ -63,7 +63,7 @@ void main() { group('oneshot', () { testWidgets('cancelled before it fires', (WidgetTester tester) async { - final alarmId = 0; + const alarmId = 0; final startingValue = await readCounter(); debugPrint('oneShot start'); await AndroidAlarmManager.oneShot( @@ -78,7 +78,7 @@ void main() { }); testWidgets('cancelled after it fires', (WidgetTester tester) async { - final alarmId = 1; + const alarmId = 1; final startingValue = await readCounter(); debugPrint('oneShot start'); await AndroidAlarmManager.oneShot( @@ -100,7 +100,7 @@ void main() { }); testWidgets('periodic', (WidgetTester tester) async { - final alarmId = 2; + const alarmId = 2; final startingValue = await readCounter(); await AndroidAlarmManager.periodic( const Duration(seconds: 1), alarmId, incrementCounter, diff --git a/packages/android_alarm_manager_plus/lib/android_alarm_manager_plus.dart b/packages/android_alarm_manager_plus/lib/android_alarm_manager_plus.dart index 311f4b7ec7..ce2e7012ba 100644 --- a/packages/android_alarm_manager_plus/lib/android_alarm_manager_plus.dart +++ b/packages/android_alarm_manager_plus/lib/android_alarm_manager_plus.dart @@ -64,14 +64,16 @@ typedef _GetCallbackHandle = CallbackHandle? Function(Function callback); class AndroidAlarmManager { static const String _channelName = 'dev.fluttercommunity.plus/android_alarm_manager'; - static final MethodChannel _channel = - const MethodChannel(_channelName, JSONMethodCodec()); + static const MethodChannel _channel = + MethodChannel(_channelName, JSONMethodCodec()); // Function used to get the current time. It's [DateTime.now] by default. + // ignore: prefer_function_declarations_over_variables static _Now _now = () => DateTime.now(); // Callback used to get the handle for a callback. It's // [PluginUtilities.getCallbackHandle] by default. + // ignore: prefer_function_declarations_over_variables static _GetCallbackHandle _getCallbackHandle = (Function callback) => PluginUtilities.getCallbackHandle(callback); diff --git a/packages/android_alarm_manager_plus/test/android_alarm_manager_test.dart b/packages/android_alarm_manager_plus/test/android_alarm_manager_test.dart index 12b0984bef..d59ec544dd 100644 --- a/packages/android_alarm_manager_plus/test/android_alarm_manager_test.dart +++ b/packages/android_alarm_manager_plus/test/android_alarm_manager_test.dart @@ -10,6 +10,7 @@ import 'package:flutter_test/flutter_test.dart'; void main() { String invalidCallback(String foo) => foo; + // ignore: avoid_returning_null_for_void void validCallback(int id) => null; const testChannel = MethodChannel( @@ -34,7 +35,7 @@ void main() { group('${AndroidAlarmManager.oneShotAt}', () { test('validates input', () async { final validTime = DateTime.utc(1993); - final validId = 1; + const validId = 1; // Callback should take a single int param. await expectLater( @@ -56,12 +57,12 @@ void main() { getCallbackHandle: (Function _) => CallbackHandle.fromRawHandle(rawHandle)); - final id = 1; - final alarmClock = true; - final allowWhileIdle = true; - final exact = true; - final wakeup = true; - final rescheduleOnReboot = true; + const id = 1; + const alarmClock = true; + const allowWhileIdle = true; + const exact = true; + const wakeup = true; + const rescheduleOnReboot = true; testChannel.setMockMethodCallHandler((MethodCall call) async { expect(call.method, 'Alarm.oneShotAt'); @@ -97,12 +98,12 @@ void main() { CallbackHandle.fromRawHandle(rawHandle)); const alarm = Duration(seconds: 1); - final id = 1; - final alarmClock = true; - final allowWhileIdle = true; - final exact = true; - final wakeup = true; - final rescheduleOnReboot = true; + const id = 1; + const alarmClock = true; + const allowWhileIdle = true; + const exact = true; + const wakeup = true; + const rescheduleOnReboot = true; testChannel.setMockMethodCallHandler((MethodCall call) async { expect(call.method, 'Alarm.oneShotAt'); @@ -131,7 +132,7 @@ void main() { group('${AndroidAlarmManager.periodic}', () { test('validates input', () async { const validDuration = Duration(seconds: 0); - final validId = 1; + const validId = 1; // Callback should take a single int param. await expectLater( @@ -154,11 +155,11 @@ void main() { getCallbackHandle: (Function _) => CallbackHandle.fromRawHandle(rawHandle)); - final id = 1; - final allowWhileIdle = true; - final exact = true; - final wakeup = true; - final rescheduleOnReboot = true; + const id = 1; + const allowWhileIdle = true; + const exact = true; + const wakeup = true; + const rescheduleOnReboot = true; const period = Duration(seconds: 1); testChannel.setMockMethodCallHandler((MethodCall call) async { @@ -190,7 +191,7 @@ void main() { }); test('${AndroidAlarmManager.cancel}', () async { - final id = 1; + const id = 1; testChannel.setMockMethodCallHandler((MethodCall call) async { assert(call.method == 'Alarm.cancel' && call.arguments[0] == id); return true; diff --git a/packages/android_intent_plus/example/lib/main.dart b/packages/android_intent_plus/example/lib/main.dart index 67f154ed62..d99bf463dd 100644 --- a/packages/android_intent_plus/example/lib/main.dart +++ b/packages/android_intent_plus/example/lib/main.dart @@ -8,11 +8,13 @@ import 'package:flutter/material.dart'; import 'package:platform/platform.dart'; void main() { - runApp(MyApp()); + runApp(const MyApp()); } /// A sample app for launching intents. class MyApp extends StatelessWidget { + const MyApp({Key key}) : super(key: key); + // This widget is the root of your application. @override Widget build(BuildContext context) { @@ -21,7 +23,7 @@ class MyApp extends StatelessWidget { theme: ThemeData( primarySwatch: Colors.blue, ), - home: MyHomePage(), + home: const MyHomePage(), routes: { ExplicitIntentsWidget.routeName: (BuildContext context) => const ExplicitIntentsWidget() @@ -32,8 +34,10 @@ class MyApp extends StatelessWidget { /// Holds the different intent widgets. class MyHomePage extends StatelessWidget { + const MyHomePage({Key key}) : super(key: key); + void _createAlarm() { - final intent = const AndroidIntent( + const intent = AndroidIntent( action: 'android.intent.action.SET_ALARM', arguments: { 'android.intent.extra.alarm.DAYS': [2, 3, 4, 5, 6], @@ -91,7 +95,7 @@ class MyHomePage extends StatelessWidget { } void _openChooser() { - final intent = const AndroidIntent( + const intent = AndroidIntent( action: 'android.intent.action.SEND', type: 'plain/text', data: 'text example', @@ -100,7 +104,7 @@ class MyHomePage extends StatelessWidget { } void _sendBroadcast() { - final intent = const AndroidIntent( + const intent = AndroidIntent( action: 'com.example.broadcast', ); intent.sendBroadcast(); @@ -109,6 +113,7 @@ class MyHomePage extends StatelessWidget { /// Launches intents to specific Android activities. class ExplicitIntentsWidget extends StatelessWidget { + // ignore: use_key_in_widget_constructors const ExplicitIntentsWidget(); // ignore: public_member_api_docs // ignore: public_member_api_docs @@ -165,14 +170,14 @@ class ExplicitIntentsWidget extends StatelessWidget { } void _openLocationSettingsConfiguration() { - final intent = const AndroidIntent( + const AndroidIntent intent = AndroidIntent( action: 'action_location_source_settings', ); intent.launch(); } void _openApplicationDetails() { - final intent = const AndroidIntent( + const intent = AndroidIntent( action: 'action_application_details_settings', data: 'package:io.flutter.plugins.androidintentexample', ); diff --git a/packages/android_intent_plus/example/test_driver/android_intent_plus_e2e.dart b/packages/android_intent_plus/example/test_driver/android_intent_plus_e2e.dart index 7f42f0c060..4b8ad5c844 100644 --- a/packages/android_intent_plus/example/test_driver/android_intent_plus_e2e.dart +++ b/packages/android_intent_plus/example/test_driver/android_intent_plus_e2e.dart @@ -15,7 +15,7 @@ void main() { IntegrationTestWidgetsFlutterBinding.ensureInitialized(); testWidgets('Embedding example app loads', (WidgetTester tester) async { // Build our app and trigger a frame. - await tester.pumpWidget(MyApp()); + await tester.pumpWidget(const MyApp()); // Verify that the new embedding example app builds if (Platform.isAndroid) { @@ -50,7 +50,7 @@ void main() { }, skip: !Platform.isAndroid); testWidgets('#launchChooser should not throw', (WidgetTester tester) async { - final intent = const AndroidIntent( + const intent = AndroidIntent( action: 'android.intent.action.SEND', type: 'plain/text', data: 'text example', @@ -59,7 +59,7 @@ void main() { }, skip: !Platform.isAndroid); testWidgets('#sendBroadcast should not throw', (WidgetTester tester) async { - final intent = const AndroidIntent( + const intent = AndroidIntent( action: 'com.example.broadcast', ); await intent.sendBroadcast(); @@ -67,7 +67,7 @@ void main() { testWidgets('#canResolveActivity returns true when example Activity is found', (WidgetTester tester) async { - final intent = AndroidIntent( + const intent = AndroidIntent( action: 'action_view', package: 'io.flutter.plugins.androidintentexample', componentName: 'io.flutter.plugins.androidintentexample.MainActivity', diff --git a/packages/android_intent_plus/lib/flag.dart b/packages/android_intent_plus/lib/flag.dart index e05aa6d126..4c9ac93ca9 100644 --- a/packages/android_intent_plus/lib/flag.dart +++ b/packages/android_intent_plus/lib/flag.dart @@ -4,6 +4,8 @@ /// https://developer.android.com/reference/android/content/Intent.html#setFlags(int) /// for the official documentation on Intent flags. The constants here mirror /// the existing [android.content.Intent] ones. +// ignore_for_file: constant_identifier_names + class Flag { /// Specifies how an activity should be launched. Generally set by the system /// in conjunction with SINGLE_TASK. @@ -25,6 +27,7 @@ class Flag { /// @deprecated Use [FLAG_ACTIVITY_NEW_DOCUMENT] instead when on API 21 or above. /// /// See https://developer.android.com/reference/android/content/Intent.html#FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET + // ignore: provide_deprecation_message @deprecated static const int FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET = 524288; diff --git a/packages/battery_plus/battery_plus/example/lib/main.dart b/packages/battery_plus/battery_plus/example/lib/main.dart index 4870e24bf5..72f3e125a8 100644 --- a/packages/battery_plus/battery_plus/example/lib/main.dart +++ b/packages/battery_plus/battery_plus/example/lib/main.dart @@ -10,10 +10,12 @@ import 'package:flutter/material.dart'; import 'package:battery_plus/battery_plus.dart'; void main() { - runApp(MyApp()); + runApp(const MyApp()); } class MyApp extends StatelessWidget { + const MyApp({Key? key}) : super(key: key); + @override Widget build(BuildContext context) { return MaterialApp( @@ -21,13 +23,13 @@ class MyApp extends StatelessWidget { theme: ThemeData( primarySwatch: Colors.blue, ), - home: MyHomePage(title: 'Flutter Demo Home Page'), + home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } } class MyHomePage extends StatefulWidget { - MyHomePage({Key? key, this.title}) : super(key: key); + const MyHomePage({Key? key, this.title}) : super(key: key); final String? title; diff --git a/packages/battery_plus/battery_plus/example/test/widget_test.dart b/packages/battery_plus/battery_plus/example/test/widget_test.dart index 92425a59d5..0ca91e7906 100644 --- a/packages/battery_plus/battery_plus/example/test/widget_test.dart +++ b/packages/battery_plus/battery_plus/example/test/widget_test.dart @@ -12,7 +12,7 @@ import 'package:battery_plus_example/main.dart'; void main() { testWidgets('Initial battery value smoke test', (WidgetTester tester) async { // Build our app and trigger a frame. - await tester.pumpWidget(MyApp()); + await tester.pumpWidget(const MyApp()); expect(find.text('null'), findsOneWidget); }); diff --git a/packages/battery_plus/battery_plus_linux/lib/src/battery_plus_linux_real.dart b/packages/battery_plus/battery_plus_linux/lib/src/battery_plus_linux_real.dart index e063c92c07..362f9be6c1 100644 --- a/packages/battery_plus/battery_plus_linux/lib/src/battery_plus_linux_real.dart +++ b/packages/battery_plus/battery_plus_linux/lib/src/battery_plus_linux_real.dart @@ -50,7 +50,7 @@ class BatteryPlusLinux extends BatteryPlatform { StreamController? _stateController; @visibleForTesting - // ignore: public_member_api_docs + // ignore: public_member_api_docs, prefer_function_declarations_over_variables UPowerDeviceFactory createDevice = () => UPowerDevice.display(); void _addState(UPowerBatteryState value) { diff --git a/packages/battery_plus/battery_plus_platform_interface/lib/method_channel_battery_plus.dart b/packages/battery_plus/battery_plus_platform_interface/lib/method_channel_battery_plus.dart index b10f849662..e70ade2159 100644 --- a/packages/battery_plus/battery_plus_platform_interface/lib/method_channel_battery_plus.dart +++ b/packages/battery_plus/battery_plus_platform_interface/lib/method_channel_battery_plus.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: prefer_const_constructors + import 'dart:async'; import 'package:flutter/services.dart'; diff --git a/packages/connectivity_plus/connectivity_plus/example/lib/main.dart b/packages/connectivity_plus/connectivity_plus/example/lib/main.dart index b707a75144..681d3c30d6 100644 --- a/packages/connectivity_plus/connectivity_plus/example/lib/main.dart +++ b/packages/connectivity_plus/connectivity_plus/example/lib/main.dart @@ -12,10 +12,12 @@ import 'package:flutter/material.dart'; import 'package:flutter/services.dart'; void main() { - runApp(MyApp()); + runApp(const MyApp()); } class MyApp extends StatelessWidget { + const MyApp({Key? key}) : super(key: key); + // This widget is the root of your application. @override Widget build(BuildContext context) { @@ -24,13 +26,13 @@ class MyApp extends StatelessWidget { theme: ThemeData( primarySwatch: Colors.blue, ), - home: MyHomePage(title: 'Flutter Demo Home Page'), + home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } } class MyHomePage extends StatefulWidget { - MyHomePage({Key? key, required this.title}) : super(key: key); + const MyHomePage({Key? key, required this.title}) : super(key: key); final String title; diff --git a/packages/connectivity_plus/connectivity_plus_linux/lib/src/connectivity_real.dart b/packages/connectivity_plus/connectivity_plus_linux/lib/src/connectivity_real.dart index 542a74bd0e..e1e7505e3f 100644 --- a/packages/connectivity_plus/connectivity_plus_linux/lib/src/connectivity_real.dart +++ b/packages/connectivity_plus/connectivity_plus_linux/lib/src/connectivity_real.dart @@ -69,5 +69,6 @@ class ConnectivityLinux extends ConnectivityPlatform { } @visibleForTesting + // ignore: prefer_function_declarations_over_variables NetworkManagerClientFactory createClient = () => NetworkManagerClient(); } diff --git a/packages/connectivity_plus/connectivity_plus_platform_interface/lib/method_channel_connectivity.dart b/packages/connectivity_plus/connectivity_plus_platform_interface/lib/method_channel_connectivity.dart index 668bd262a1..1c053d9133 100644 --- a/packages/connectivity_plus/connectivity_plus_platform_interface/lib/method_channel_connectivity.dart +++ b/packages/connectivity_plus/connectivity_plus_platform_interface/lib/method_channel_connectivity.dart @@ -15,12 +15,12 @@ class MethodChannelConnectivity extends ConnectivityPlatform { /// The method channel used to interact with the native platform. @visibleForTesting MethodChannel methodChannel = - MethodChannel('dev.fluttercommunity.plus/connectivity'); + const MethodChannel('dev.fluttercommunity.plus/connectivity'); /// The event channel used to receive ConnectivityResult changes from the native platform. @visibleForTesting EventChannel eventChannel = - EventChannel('dev.fluttercommunity.plus/connectivity_status'); + const EventChannel('dev.fluttercommunity.plus/connectivity_status'); Stream? _onConnectivityChanged; diff --git a/packages/connectivity_plus/connectivity_plus_web/lib/src/network_information_api_connectivity_plugin.dart b/packages/connectivity_plus/connectivity_plus_web/lib/src/network_information_api_connectivity_plugin.dart index 3af5c36894..3dd57dc87a 100644 --- a/packages/connectivity_plus/connectivity_plus_web/lib/src/network_information_api_connectivity_plugin.dart +++ b/packages/connectivity_plus/connectivity_plus_web/lib/src/network_information_api_connectivity_plugin.dart @@ -45,6 +45,7 @@ class NetworkInformationApiConnectivityPlugin extends ConnectivityPlusPlugin { _connectivityResultStreamController! .add(networkInformationToConnectivityResult(_networkInformation)); })); + // ignore: todo // TODO: Implement the above with _networkInformation.onChange: // _networkInformation.onChange.listen((_) { // _connectivityResult diff --git a/packages/device_info_plus/device_info_plus/example/lib/main.dart b/packages/device_info_plus/device_info_plus/example/lib/main.dart index fa5702fecb..1e284f0e62 100644 --- a/packages/device_info_plus/device_info_plus/example/lib/main.dart +++ b/packages/device_info_plus/device_info_plus/example/lib/main.dart @@ -14,7 +14,7 @@ import 'package:device_info_plus/device_info_plus.dart'; void main() { runZonedGuarded(() { - runApp(MyApp()); + runApp(const MyApp()); }, (dynamic error, dynamic stack) { print(error); print(stack); @@ -22,6 +22,8 @@ void main() { } class MyApp extends StatefulWidget { + const MyApp({Key? key}) : super(key: key); + @override _MyAppState createState() => _MyAppState(); } diff --git a/packages/device_info_plus/device_info_plus_linux/lib/src/device_info.dart b/packages/device_info_plus/device_info_plus_linux/lib/src/device_info.dart index e0e50adce7..0ba800e137 100644 --- a/packages/device_info_plus/device_info_plus_linux/lib/src/device_info.dart +++ b/packages/device_info_plus/device_info_plus_linux/lib/src/device_info.dart @@ -12,7 +12,7 @@ class DeviceInfoLinux extends DeviceInfoPlatform { /// DeviceInfoLinux({@visibleForTesting FileSystem? fileSystem}) - : _fileSystem = fileSystem ?? LocalFileSystem(); + : _fileSystem = fileSystem ?? const LocalFileSystem(); @override Future linuxInfo() async { diff --git a/packages/device_info_plus/device_info_plus_platform_interface/lib/method_channel/method_channel_device_info.dart b/packages/device_info_plus/device_info_plus_platform_interface/lib/method_channel/method_channel_device_info.dart index 1350ebddea..8b1d7ca298 100644 --- a/packages/device_info_plus/device_info_plus_platform_interface/lib/method_channel/method_channel_device_info.dart +++ b/packages/device_info_plus/device_info_plus_platform_interface/lib/method_channel/method_channel_device_info.dart @@ -11,7 +11,7 @@ class MethodChannelDeviceInfo extends DeviceInfoPlatform { /// The method channel used to interact with the native platform. @visibleForTesting MethodChannel channel = - MethodChannel('dev.fluttercommunity.plus/device_info'); + const MethodChannel('dev.fluttercommunity.plus/device_info'); // Method channel for Android devices @override diff --git a/packages/network_info_plus/network_info_plus/example/lib/main.dart b/packages/network_info_plus/network_info_plus/example/lib/main.dart index d67f4633a1..0157d32beb 100644 --- a/packages/network_info_plus/network_info_plus/example/lib/main.dart +++ b/packages/network_info_plus/network_info_plus/example/lib/main.dart @@ -22,10 +22,12 @@ void _enablePlatformOverrideForDesktop() { void main() { _enablePlatformOverrideForDesktop(); - runApp(MyApp()); + runApp(const MyApp()); } class MyApp extends StatelessWidget { + const MyApp({Key? key}) : super(key: key); + // This widget is the root of your application. @override Widget build(BuildContext context) { @@ -34,13 +36,13 @@ class MyApp extends StatelessWidget { theme: ThemeData( primarySwatch: Colors.blue, ), - home: MyHomePage(title: 'Flutter Demo Home Page'), + home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } } class MyHomePage extends StatefulWidget { - MyHomePage({Key? key, this.title}) : super(key: key); + const MyHomePage({Key? key, this.title}) : super(key: key); final String? title; diff --git a/packages/network_info_plus/network_info_plus_linux/lib/src/network_info_real.dart b/packages/network_info_plus/network_info_plus_linux/lib/src/network_info_real.dart index bf546645e7..72e7a7e76f 100644 --- a/packages/network_info_plus/network_info_plus_linux/lib/src/network_info_real.dart +++ b/packages/network_info_plus/network_info_plus_linux/lib/src/network_info_real.dart @@ -102,6 +102,7 @@ class NetworkInfoLinux extends NetworkInfoPlatform { } @visibleForTesting + // ignore: prefer_function_declarations_over_variables NetworkManagerClientFactory createClient = () => NetworkManagerClient(); } diff --git a/packages/network_info_plus/network_info_plus_platform_interface/lib/method_channel_network_info.dart b/packages/network_info_plus/network_info_plus_platform_interface/lib/method_channel_network_info.dart index 0e19304f75..9581fbcf8a 100644 --- a/packages/network_info_plus/network_info_plus_platform_interface/lib/method_channel_network_info.dart +++ b/packages/network_info_plus/network_info_plus_platform_interface/lib/method_channel_network_info.dart @@ -15,7 +15,7 @@ class MethodChannelNetworkInfo extends NetworkInfoPlatform { /// The method channel used to interact with the native platform. @visibleForTesting MethodChannel methodChannel = - MethodChannel('dev.fluttercommunity.plus/network_info'); + const MethodChannel('dev.fluttercommunity.plus/network_info'); @override Future getWifiName() async { diff --git a/packages/package_info_plus/package_info_plus/example/test_driver/package_info_plus_e2e.dart b/packages/package_info_plus/package_info_plus/example/test_driver/package_info_plus_e2e.dart index c7f83b646d..8ffdfd54e6 100644 --- a/packages/package_info_plus/package_info_plus/example/test_driver/package_info_plus_e2e.dart +++ b/packages/package_info_plus/package_info_plus/example/test_driver/package_info_plus_e2e.dart @@ -7,6 +7,7 @@ import 'package:flutter_test/flutter_test.dart'; import 'package:integration_test/integration_test.dart'; import 'package:package_info_plus/package_info_plus.dart'; import 'package:package_info_example/main.dart'; +// ignore: import_of_legacy_library_into_null_safe import 'package:universal_io/io.dart'; void main() { diff --git a/packages/package_info_plus/package_info_plus_web/test/package_info_plus_web_test.dart b/packages/package_info_plus/package_info_plus_web/test/package_info_plus_web_test.dart index a5fc43734e..28c3dd0578 100644 --- a/packages/package_info_plus/package_info_plus_web/test/package_info_plus_web_test.dart +++ b/packages/package_info_plus/package_info_plus_web/test/package_info_plus_web_test.dart @@ -10,6 +10,7 @@ import 'package_info_plus_web_test.mocks.dart'; @GenerateMocks([http.Client]) void main() { + // ignore: constant_identifier_names const VERSION_JSON = { 'app_name': 'package_info_example', 'build_number': '1', diff --git a/packages/package_info_plus/package_info_plus_web/test/package_info_plus_web_test.mocks.dart b/packages/package_info_plus/package_info_plus_web/test/package_info_plus_web_test.mocks.dart index 3d37fc9e95..7c8163a2e0 100644 --- a/packages/package_info_plus/package_info_plus_web/test/package_info_plus_web_test.mocks.dart +++ b/packages/package_info_plus/package_info_plus_web/test/package_info_plus_web_test.mocks.dart @@ -2,6 +2,8 @@ // in package_info_plus_web/test/package_info_plus_web_test.dart. // Do not manually edit this file. +// ignore_for_file: camel_case_types, unnecessary_overrides + import 'dart:async' as _i5; import 'dart:convert' as _i6; import 'dart:typed_data' as _i7; diff --git a/packages/package_info_plus/package_info_plus_windows/lib/src/file_version_info.dart b/packages/package_info_plus/package_info_plus_windows/lib/src/file_version_info.dart index d863fdfe61..da60f2b518 100644 --- a/packages/package_info_plus/package_info_plus_windows/lib/src/file_version_info.dart +++ b/packages/package_info_plus/package_info_plus_windows/lib/src/file_version_info.dart @@ -17,6 +17,7 @@ class _LANGANDCODEPAGE extends Struct { } final _kernel32 = DynamicLibrary.open('kernel32.dll'); +// ignore: non_constant_identifier_names final _GetUserDefaultLangID = _kernel32 .lookupFunction('GetUserDefaultLangID'); diff --git a/packages/sensors_plus/sensors_plus/example/lib/main.dart b/packages/sensors_plus/sensors_plus/example/lib/main.dart index 72dc809b7f..77b686a941 100644 --- a/packages/sensors_plus/sensors_plus/example/lib/main.dart +++ b/packages/sensors_plus/sensors_plus/example/lib/main.dart @@ -11,10 +11,12 @@ import 'package:sensors_plus/sensors_plus.dart'; import 'snake.dart'; void main() { - runApp(MyApp()); + runApp(const MyApp()); } class MyApp extends StatelessWidget { + const MyApp({Key? key}) : super(key: key); + @override Widget build(BuildContext context) { return MaterialApp( @@ -22,13 +24,13 @@ class MyApp extends StatelessWidget { theme: ThemeData( primarySwatch: Colors.blue, ), - home: MyHomePage(title: 'Flutter Demo Home Page'), + home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } } class MyHomePage extends StatefulWidget { - MyHomePage({Key? key, this.title}) : super(key: key); + const MyHomePage({Key? key, this.title}) : super(key: key); final String? title; diff --git a/packages/sensors_plus/sensors_plus/example/lib/snake.dart b/packages/sensors_plus/sensors_plus/example/lib/snake.dart index dfb10b1853..0b4d18b66b 100644 --- a/packages/sensors_plus/sensors_plus/example/lib/snake.dart +++ b/packages/sensors_plus/sensors_plus/example/lib/snake.dart @@ -11,7 +11,8 @@ import 'package:flutter/material.dart'; import 'package:sensors_plus/sensors_plus.dart'; class Snake extends StatefulWidget { - Snake({this.rows = 20, this.columns = 20, this.cellSize = 10.0}) { + Snake({Key? key, this.rows = 20, this.columns = 20, this.cellSize = 10.0}) + : super(key: key) { assert(10 <= rows); assert(10 <= columns); assert(5.0 <= cellSize); @@ -22,6 +23,7 @@ class Snake extends StatefulWidget { final double cellSize; @override + // ignore: no_logic_in_create_state State createState() => SnakeState(rows, columns, cellSize); } diff --git a/packages/share_plus/share_plus/example/lib/image_previews.dart b/packages/share_plus/share_plus/example/lib/image_previews.dart index cd8779ed5e..f496ad9a2b 100644 --- a/packages/share_plus/share_plus/example/lib/image_previews.dart +++ b/packages/share_plus/share_plus/example/lib/image_previews.dart @@ -52,7 +52,7 @@ class _ImagePreview extends StatelessWidget { child: Stack( children: [ ConstrainedBox( - constraints: BoxConstraints( + constraints: const BoxConstraints( maxWidth: 200, maxHeight: 200, ), @@ -65,7 +65,7 @@ class _ImagePreview extends StatelessWidget { child: FloatingActionButton( backgroundColor: Colors.red, onPressed: onDelete, - child: Icon(Icons.delete)), + child: const Icon(Icons.delete)), ), ), ], diff --git a/packages/share_plus/share_plus/example/lib/main.dart b/packages/share_plus/share_plus/example/lib/main.dart index 9eb99f4d4c..045f596caf 100644 --- a/packages/share_plus/share_plus/example/lib/main.dart +++ b/packages/share_plus/share_plus/example/lib/main.dart @@ -11,10 +11,12 @@ import 'package:share_plus/share_plus.dart'; import 'image_previews.dart'; void main() { - runApp(DemoApp()); + runApp(const DemoApp()); } class DemoApp extends StatefulWidget { + const DemoApp({Key? key}) : super(key: key); + @override DemoAppState createState() => DemoAppState(); } @@ -61,8 +63,8 @@ class DemoAppState extends State { const Padding(padding: EdgeInsets.only(top: 12.0)), ImagePreviews(imagePaths, onDelete: _onDeleteImage), ListTile( - leading: Icon(Icons.add), - title: Text('Add image'), + leading: const Icon(Icons.add), + title: const Text('Add image'), onTap: () async { final imagePicker = ImagePicker(); final pickedFile = await imagePicker.pickImage( diff --git a/packages/share_plus/share_plus_platform_interface/test/share_plus_platform_interface_test.dart b/packages/share_plus/share_plus_platform_interface/test/share_plus_platform_interface_test.dart index 18cc581af7..9017bb5fde 100644 --- a/packages/share_plus/share_plus_platform_interface/test/share_plus_platform_interface_test.dart +++ b/packages/share_plus/share_plus_platform_interface/test/share_plus_platform_interface_test.dart @@ -63,7 +63,7 @@ void main() { }); test('sharing file sets correct mimeType', () async { - final path = 'tempfile-83649a.png'; + const path = 'tempfile-83649a.png'; final file = File(path); try { file.createSync(); @@ -78,7 +78,7 @@ void main() { }); test('sharing file sets passed mimeType', () async { - final path = 'tempfile-83649a.png'; + const path = 'tempfile-83649a.png'; final file = File(path); try { file.createSync(); diff --git a/packages/share_plus/share_plus_web/lib/share_plus_web.dart b/packages/share_plus/share_plus_web/lib/share_plus_web.dart index ae256beb9f..7f93d40e98 100644 --- a/packages/share_plus/share_plus_web/lib/share_plus_web.dart +++ b/packages/share_plus/share_plus_web/lib/share_plus_web.dart @@ -13,6 +13,7 @@ class SharePlusPlugin extends SharePlatform { SharePlatform.instance = SharePlusPlugin(); } + // ignore: prefer_typing_uninitialized_variables final _navigator; /// A constructor that allows tests to override the window object used by the plugin. From 81fda9a54c9eb08e1839c59275e8cc1d9850e672 Mon Sep 17 00:00:00 2001 From: Aditya Thakur Date: Wed, 6 Oct 2021 16:32:58 +0530 Subject: [PATCH 5/6] Update analysis_options.yaml --- .../example/analysis_options.yaml | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/packages/package_info_plus/package_info_plus/example/analysis_options.yaml b/packages/package_info_plus/package_info_plus/example/analysis_options.yaml index c48c349fce..73b14a1b60 100644 --- a/packages/package_info_plus/package_info_plus/example/analysis_options.yaml +++ b/packages/package_info_plus/package_info_plus/example/analysis_options.yaml @@ -1,14 +1,8 @@ # TODO: Remove this when migrated to null safety -include: package:pedantic/analysis_options.yaml - -analyzer: - exclude: - # Ignore generated files - - '**/*.g.dart' - - 'lib/src/generated/*.dart' +include: package:flutter_lints/flutter.yaml linter: rules: - public_member_api_docs: true - prefer_final_in_for_each: true - prefer_final_locals: true + - prefer_final_in_for_each + - prefer_final_locals + From d647c1c2a02a9c069d57e9993f59f872ce60876c Mon Sep 17 00:00:00 2001 From: Aditya Thakur Date: Wed, 6 Oct 2021 16:44:19 +0530 Subject: [PATCH 6/6] Fix analyze issues in package_info_plus --- .../package_info_plus/example/lib/main.dart | 8 +++++--- .../example/test_driver/package_info_plus_e2e.dart | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/package_info_plus/package_info_plus/example/lib/main.dart b/packages/package_info_plus/package_info_plus/example/lib/main.dart index 22bd230ad5..803a45b501 100644 --- a/packages/package_info_plus/package_info_plus/example/lib/main.dart +++ b/packages/package_info_plus/package_info_plus/example/lib/main.dart @@ -10,22 +10,24 @@ import 'package:flutter/material.dart'; import 'package:package_info_plus/package_info_plus.dart'; void main() { - runApp(MyApp()); + runApp(const MyApp()); } class MyApp extends StatelessWidget { + const MyApp({Key? key}) : super(key: key); + @override Widget build(BuildContext context) { return MaterialApp( title: 'PackageInfo Demo', theme: ThemeData(primarySwatch: Colors.blue), - home: MyHomePage(title: 'PackageInfo example app'), + home: const MyHomePage(title: 'PackageInfo example app'), ); } } class MyHomePage extends StatefulWidget { - MyHomePage({Key? key, this.title}) : super(key: key); + const MyHomePage({Key? key, this.title}) : super(key: key); final String? title; diff --git a/packages/package_info_plus/package_info_plus/example/test_driver/package_info_plus_e2e.dart b/packages/package_info_plus/package_info_plus/example/test_driver/package_info_plus_e2e.dart index 8ffdfd54e6..3a9593c17a 100644 --- a/packages/package_info_plus/package_info_plus/example/test_driver/package_info_plus_e2e.dart +++ b/packages/package_info_plus/package_info_plus/example/test_driver/package_info_plus_e2e.dart @@ -47,7 +47,7 @@ void main() { }); testWidgets('example', (WidgetTester tester) async { - await tester.pumpWidget(MyApp()); + await tester.pumpWidget(const MyApp()); await tester.pumpAndSettle(); if (Platform.isAndroid) { expect(find.text('package_info_example'), findsOneWidget);