From 2a920d4f516e974af01212c4ba74d6e9347cf8e2 Mon Sep 17 00:00:00 2001 From: Daniel Rammer Date: Tue, 16 May 2023 09:36:11 -0500 Subject: [PATCH 1/2] removed default timeout Signed-off-by: Daniel Rammer --- pkg/manager/impl/util/single_task_execution.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkg/manager/impl/util/single_task_execution.go b/pkg/manager/impl/util/single_task_execution.go index 74a53de99..44c803494 100644 --- a/pkg/manager/impl/util/single_task_execution.go +++ b/pkg/manager/impl/util/single_task_execution.go @@ -26,7 +26,6 @@ const maxNodeIDLength = 63 var defaultRetryStrategy = core.RetryStrategy{ Retries: 3, } -var defaultTimeout = ptypes.DurationProto(24 * time.Hour) const systemNamePrefix = ".flytegen.%s" @@ -102,7 +101,6 @@ func CreateOrGetWorkflowModel( Metadata: &core.NodeMetadata{ Name: generateNodeNameFromTask(taskIdentifier.Name), Retries: &defaultRetryStrategy, - Timeout: defaultTimeout, }, Inputs: generateBindings(*task.Closure.CompiledTask.Template.Interface.Inputs, noInputNodeID), Target: &core.Node_TaskNode{ From fe872475ea0518018713913dd73852059f3c611b Mon Sep 17 00:00:00 2001 From: Daniel Rammer Date: Tue, 16 May 2023 10:09:22 -0500 Subject: [PATCH 2/2] removed unnecessary dependencies Signed-off-by: Daniel Rammer --- pkg/manager/impl/util/single_task_execution.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkg/manager/impl/util/single_task_execution.go b/pkg/manager/impl/util/single_task_execution.go index 44c803494..d23f38c98 100644 --- a/pkg/manager/impl/util/single_task_execution.go +++ b/pkg/manager/impl/util/single_task_execution.go @@ -4,7 +4,6 @@ import ( "context" "fmt" "strings" - "time" "unicode" "github.com/flyteorg/flyteadmin/pkg/errors" @@ -17,7 +16,6 @@ import ( "github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/admin" "github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/core" "github.com/flyteorg/flytestdlib/logger" - "github.com/golang/protobuf/ptypes" "google.golang.org/grpc/codes" )