Merged
Conversation
juliaogris
force-pushed
the
syntax-coloring
branch
4 times, most recently
from
05b05ac to
290d04f
Compare
|
firebase-deployment: https://evy-lang--111-h4ddwnw1.web.app (422152c) |
juliaogris
force-pushed
the
syntax-coloring
branch
from
290d04f to
792ad9b
Compare
Copy relevant yace editor source files verbatim from https://github.com/petersolopov/yace/blob/8ed1f99977c4db9bdd60db4e2f5ba4edfcfc1940/src : index.js plugins/isKey.js plugins/history.js plugins/preserveInden.js plugins/tab.js Copy all files into a single files unchanged `frontend/module/yace-editor.js` as we are not (yet) using a JS bundler. Add prettier ignore line as this file doesn't pass style checks.
Reformat Yace editor module with `make prettier` after removing it from the .prettierignore file. Remove all but the main editor's default exports and remove all imports.
juliaogris
force-pushed
the
syntax-coloring
branch
from
792ad9b to
3744502
Compare
juliaogris
force-pushed
the
syntax-coloring
branch
from
3744502 to
98ae443
Compare
camh-
approved these changes
Mar 21, 2023
Member
camh-
left a comment
camh-
left a comment
There was a problem hiding this comment.
It looks very pretty. But with all that js and css, all I can say is cool bananas. go for it.
Have a cucumber 🥒
juliaogris
force-pushed
the
syntax-coloring
branch
2 times, most recently
from
2cdd7b6 to
4ee2bb6
Compare
camh-
reviewed
Mar 21, 2023
frontend/index.js
Outdated
| const source = await response.text() | ||
| document.querySelector("#code").value = source | ||
| editor.update({ value: source }) | ||
| document.querySelector(".editor-wrap").scrollTo(0,0 ) |
Member
There was a problem hiding this comment.
nit: that's some odd spacing for the function parameters
Add evy syntax colouring by implementing a custom highlight function for yace, inspired by the Yace author's markdown highlighter mdhl. The highlighter is a basic lexer where each token is wrapped in its own span with the appropriate class. Move styling of yace created elements all to index.css and display line number by default. Link: https://github.com/petersolopov/mdhl
juliaogris
force-pushed
the
syntax-coloring
branch
from
4ee2bb6 to
422152c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add evy syntax colouring by implementing a custom highlight function for
lightweight JS code editor Yace.
Copy all relevant Yace source files with minor tweaks into a single file
frontend/module/yace-editor.jsas we are not (yet) using a JS bundler.Link: https://github.com/petersolopov/yace
Link: https://github.com/petersolopov/mdhl