Merged
Conversation
Rename newStringEvent to newKeyEvent as the stringEvent is only used in one place and can be more specific. This makes it more consistent with the onInput and the upcoming onAnimate.
|
firebase-deployment: https://evy-lang--81-9qbk365r.web.app (5f17740) |
Add `on animate elapsedms:num` based on JS' window.requestAnimationFrame. The parameter passed is the number of elapsed Milliseconds since the animation started.
Fix flicker for animations via updated yielding. The yielder yields about every 100ms to check if the cancel button has been pressed (in case of an accidental endless loop). Add a Reset method to the Sleeping yielder so that that the counter be reset on all external sleeps and before executing a an eventHandler. Additionally use the yielding sleep for the reading in JS, so make read a Method on the yielder.
juliaogris
force-pushed
the
on-animate
branch
from
691cf7c to
5f17740
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
on animate elapsedms:numbased on JS' window.requestAnimationFrame.The parameter passed is the number of elapsed Milliseconds since the
animation started.
Rework yielding and make Sleep part of the runtime to fix flickering of
the animation.
https://evy-lang--81-9qbk365r.web.app/#animate
Aside: the initial sleep / dot animation is now flicker free too
https://evy-lang--81-9qbk365r.web.app/#dot