chore(test): added test for re-canvasing modules

Author: ful1e5

src/clickgen/parser/png.py

@@ -74,10 +74,6 @@ def _parse(self) -> List[CursorFrame]:
                     raise ValueError(
                         f"'sizes' input '{s}' must be an integer or integers separated by ':'."
                     )
-                except IndexError:
-                    raise ValueError(
-                        f"'sizes' input '{s}' must contain one ':' to separate sizes."
-                    )
             elif isinstance(s, int):
                 size = s
                 canvas_size = s

src/clickgen/writer/windows.py

@@ -57,10 +57,8 @@ def re_canvas(size: int, img: Image.Image):
             re_canvas(96, clone).save(blob, "PNG")
         elif width <= 128 or height <= 128:
             re_canvas(128, clone).save(blob, "PNG")
-        elif width <= 256 or height <= 256:
-            re_canvas(256, clone).save(blob, "PNG")
         else:
-            raise ValueError(f"Unable to re-canvas windows cursors: {width}x{height}")
+            re_canvas(256, clone).save(blob, "PNG")
 
         blob.seek(0)
         image_data.append(blob.read())

tests/parser/test_png_parser.py

@@ -45,6 +45,18 @@ def test_single_png_parser_raises_01(blob):
         SinglePNGParser(blob, hotspot=(201, 100))
 
 
+def test_single_png_parser_raises_size_error_for_canvasing(blob):
+    with pytest.raises(ValueError):
+        SinglePNGParser(blob, hotspot=(3, 3), sizes=["test"])
+    with pytest.raises(ValueError):
+        SinglePNGParser(blob, hotspot=(3, 3), sizes=["20:"])
+    with pytest.raises(ValueError):
+        SinglePNGParser(blob, hotspot=(3, 3), sizes=[":20"])
+
+    with pytest.raises(TypeError):
+        SinglePNGParser(blob, hotspot=(3, 3), sizes=[(20, 20)])
+
+
 def test_multi_png_parser(blobs, hotspot, sizes, delay):
     p = MultiPNGParser(blobs, hotspot, sizes, delay)
 

tests/writer/test_windows_writer.py

@@ -18,6 +18,26 @@ def test_windows_cur_writer(cursor_frame, x11_tmp_dir: Path):
     assert cfile.is_file()
 
 
+def test_windows_cur_writer_re_canvas(image: Image, hotspot, delay):
+    def cur_frame(size: int):
+        i = image.resize(size=(size, size), resample=3)
+        return CursorImage(i, hotspot, nominal=31)
+
+    to_cur(
+        CursorFrame(
+            [
+                cur_frame(20),
+                cur_frame(40),
+                cur_frame(60),
+                cur_frame(90),
+                cur_frame(120),
+                cur_frame(250),
+            ],
+            delay,
+        )
+    )
+
+
 def test_windows_cur_writer_raises(image: Image, hotspot, delay):
     i = image.resize(size=(500, 500), resample=3)
     c = CursorImage(i, hotspot, nominal=i.size[0])