diff --git a/.github/workflows/cla.yml b/.github/workflows/cla.yml index dc4de9e..fa6af27 100644 --- a/.github/workflows/cla.yml +++ b/.github/workflows/cla.yml @@ -1,12 +1,28 @@ -name: CLA Assistant +name: CLA Assistant Workflow on: - issue_comment: - types: [created] - pull_request_target: + pull_request: types: [opened, synchronize] jobs: - CLA: - uses: Expensify/GitHub-Actions/.github/workflows/cla.yml@main - secrets: inherit + check-cla: + runs-on: ubuntu-latest + steps: + - name: CLA Assistant Action + uses: cla-assistant/github-action@v1 + with: + token: ${{ secrets.GITHUB_TOKEN }} + claUrl: https://cla-assistant.io/fullstack707/App-saif + repo: ${{ github.repository }} + path-to-signatures: fullstack707/App-saif/cla.json + path-to-document: https://github.com/fullstack707/App-saif/blob/main/CLA.md + branch: main + remote-organization-name: Expensify + remote-repository-name: CLA + lock-pullrequest-aftermerge: false + allowlist: snyk-bot,OSBotify,os-botify[bot],imgbot[bot] + use-dco-flag: false + suggest-recheck: true + env: + PERSONAL_ACCESS_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }} + diff --git a/cla.json b/cla.json new file mode 100644 index 0000000..d06ee19 --- /dev/null +++ b/cla.json @@ -0,0 +1,13 @@ +[ + { + "user_name": "fullstack707", + "repo_owner": "fullstack707", + "repo_name": "App-saif", + "gist_name": "SAP_CLA", + "gist_url": "https://gist.github.com/CLAassistant/bd1ea8ec8aa0357414e8", + "gist_version": "cff2da09036ebbf8df8598125dbcdae8a874d12c", + "signed_at": "2024-12-11T15:50:59.943Z", + "revoked_at": "", + "org_cla": false + } +] diff --git a/package-lock.json b/package-lock.json index 1604f1f..fefaa13 100644 --- a/package-lock.json +++ b/package-lock.json @@ -217,7 +217,7 @@ "dotenv": "^16.0.3", "electron": "^32.2.3", "electron-builder": "25.0.0", - "eslint": "^8.57.0", + "eslint": "^8.57.1", "eslint-config-airbnb-typescript": "^18.0.0", "eslint-config-expensify": "^2.0.74", "eslint-config-prettier": "^9.1.0", @@ -3531,7 +3531,9 @@ } }, "node_modules/@eslint/js": { - "version": "8.57.0", + "version": "8.57.1", + "resolved": "https://registry.npmjs.org/@eslint/js/-/js-8.57.1.tgz", + "integrity": "sha512-d9zaMRSTIKDLhctzH12MtXvJKSSUhaHcjV+2Z+GK+EEY7XKpP5yR4x+N3TAcHTcu963nIr+TMcCb4DBCYX1z6Q==", "dev": true, "license": "MIT", "engines": { @@ -5598,11 +5600,14 @@ "license": "Apache-2.0" }, "node_modules/@humanwhocodes/config-array": { - "version": "0.11.14", + "version": "0.13.0", + "resolved": "https://registry.npmjs.org/@humanwhocodes/config-array/-/config-array-0.13.0.tgz", + "integrity": "sha512-DZLEEqFWQFiyK6h5YIeynKx7JlvCYWL0cImfSRXZ9l4Sg2efkFGTuFf6vzXjK1cq6IYkU+Eg/JizXw+TD2vRNw==", + "deprecated": "Use @eslint/config-array instead", "dev": true, "license": "Apache-2.0", "dependencies": { - "@humanwhocodes/object-schema": "^2.0.2", + "@humanwhocodes/object-schema": "^2.0.3", "debug": "^4.3.1", "minimatch": "^3.0.5" }, @@ -5624,6 +5629,9 @@ }, "node_modules/@humanwhocodes/object-schema": { "version": "2.0.3", + "resolved": "https://registry.npmjs.org/@humanwhocodes/object-schema/-/object-schema-2.0.3.tgz", + "integrity": "sha512-93zYdMES/c1D69yZiKDBj0V24vqNzB/koF26KPaagAfd3P/4gUlh3Dys5ogAK+Exi9QyzlD8x/08Zt7wIKcDcA==", + "deprecated": "Use @eslint/object-schema instead", "dev": true, "license": "BSD-3-Clause" }, @@ -20064,15 +20072,18 @@ } }, "node_modules/eslint": { - "version": "8.57.0", + "version": "8.57.1", + "resolved": "https://registry.npmjs.org/eslint/-/eslint-8.57.1.tgz", + "integrity": "sha512-ypowyDxpVSYpkXr9WPv2PAZCtNip1Mv5KTW0SCurXv/9iOpcrH9PaqUElksqEB6pChqHGDRCFTyrZlGhnLNGiA==", + "deprecated": "This version is no longer supported. Please see https://eslint.org/version-support for other options.", "dev": true, "license": "MIT", "dependencies": { "@eslint-community/eslint-utils": "^4.2.0", "@eslint-community/regexpp": "^4.6.1", "@eslint/eslintrc": "^2.1.4", - "@eslint/js": "8.57.0", - "@humanwhocodes/config-array": "^0.11.14", + "@eslint/js": "8.57.1", + "@humanwhocodes/config-array": "^0.13.0", "@humanwhocodes/module-importer": "^1.0.1", "@nodelib/fs.walk": "^1.2.8", "@ungap/structured-clone": "^1.2.0", diff --git a/package.json b/package.json index 3c6ca5e..a6f5f18 100644 --- a/package.json +++ b/package.json @@ -274,7 +274,7 @@ "dotenv": "^16.0.3", "electron": "^32.2.3", "electron-builder": "25.0.0", - "eslint": "^8.57.0", + "eslint": "^8.57.1", "eslint-config-airbnb-typescript": "^18.0.0", "eslint-config-expensify": "^2.0.74", "eslint-config-prettier": "^9.1.0", diff --git a/src/components/AddPaymentCard/PaymentCardForm.tsx b/src/components/AddPaymentCard/PaymentCardForm.tsx index 1541b7b..ef0695f 100644 --- a/src/components/AddPaymentCard/PaymentCardForm.tsx +++ b/src/components/AddPaymentCard/PaymentCardForm.tsx @@ -144,36 +144,36 @@ function PaymentCardForm({ const validate = (values: FormOnyxValues): FormInputErrors => { const errors = ValidationUtils.getFieldRequiredErrors(values, REQUIRED_FIELDS); - + if (values.nameOnCard && !ValidationUtils.isValidLegalName(values.nameOnCard)) { errors.nameOnCard = translate(label.error.nameOnCard); } - + if (values.cardNumber && !ValidationUtils.isValidDebitCard(values.cardNumber.replace(/ /g, ''))) { errors.cardNumber = translate(label.error.cardNumber); } - + if (values.expirationDate && !ValidationUtils.isValidExpirationDate(values.expirationDate)) { errors.expirationDate = translate(label.error.expirationDate); } - + if (values.securityCode && !ValidationUtils.isValidSecurityCode(values.securityCode)) { errors.securityCode = translate(label.error.securityCode); } - + if (values.addressStreet && !ValidationUtils.isValidAddress(values.addressStreet)) { errors.addressStreet = translate(label.error.addressStreet); } - + if (values.addressZipCode && !/^\d{5}(-\d{4})?$/.test(values.addressZipCode)) { // Validate ZIP code (5-digit or 9-digit ZIP format) errors.addressZipCode = translate(label.error.addressZipCode); } - + if (!values.acceptTerms) { errors.acceptTerms = translate('common.error.acceptTerms'); } - + return errors; }; diff --git a/src/pages/AddPersonalBankAccountPage.tsx b/src/pages/AddPersonalBankAccountPage.tsx index 5035571..d99db40 100644 --- a/src/pages/AddPersonalBankAccountPage.tsx +++ b/src/pages/AddPersonalBankAccountPage.tsx @@ -43,7 +43,7 @@ function AddPersonalBankAccountPage() { break; } }, [topMostCentralPane]); -//Testing + const submitBankAccountForm = useCallback(() => { const bankAccounts = plaidData?.bankAccounts ?? []; const selectedPlaidBankAccount = bankAccounts.find((bankAccount) => bankAccount.plaidAccountID === selectedPlaidAccountId);