Add partial/incomplete CBOR Sequences test case.

Signed-off-by: Yan Qing <txr1883@gmail.com>

Author: zensh

diagnose.go

@@ -147,13 +147,14 @@ func (dm *diagMode) diagnose(data []byte) (*diagnose, error) {
 	}
 
 	di := &diagnose{
-		dm: dm, d: de, w: &bytes.Buffer{},
 		byteStringEncoding:      dm.opts.ByteStringEncoding,
 		byteStringHexWhitespace: dm.opts.ByteStringHexWhitespace,
 		byteStringText:          dm.opts.ByteStringText,
 		byteStringEmbeddedCBOR:  dm.opts.ByteStringEmbeddedCBOR,
 		cborSequence:            dm.opts.CBORSequence,
 		indicateFloatPrecision:  dm.opts.IndicateFloatPrecision,
+
+		dm: dm, d: de, w: &bytes.Buffer{},
 	}
 	return di, nil
 }
@@ -169,15 +170,15 @@ func Diagnose(data []byte) (string, error) {
 }
 
 type diagnose struct {
-	dm                      *diagMode
-	d                       *decoder
-	w                       *bytes.Buffer
 	byteStringEncoding      ByteStringEncoding
 	byteStringHexWhitespace bool
 	byteStringText          bool
 	byteStringEmbeddedCBOR  bool
 	cborSequence            bool
 	indicateFloatPrecision  bool
+	dm                      *diagMode
+	d                       *decoder
+	w                       *bytes.Buffer
 }
 
 func (di *diagnose) diag() (string, error) {
@@ -460,11 +461,11 @@ func (di *diagnose) encodeByteString(val []byte) error {
 
 		if di.byteStringEmbeddedCBOR {
 			if di2, err := di.dm.diagnose(val); err == nil {
-				if data, err := di2.diag(); err == nil {
+				if str, err := di2.diag(); err == nil {
 					if err := di.writeString("<<"); err != nil {
 						return err
 					}
-					if err := di.writeString(string(data)); err != nil {
+					if err := di.writeString(str); err != nil {
 						return err
 					}
 					return di.writeString(">>")

diagnose_test.go

@@ -9,7 +9,7 @@ import (
 	"testing"
 )
 
-func TestDiagnoseExamples(t *testing.T) {
+func TestDiagnosticNotationExamples(t *testing.T) {
 	// https://www.rfc-editor.org/rfc/rfc8949.html#name-examples-of-encoded-cbor-da
 	testCases := []struct {
 		cbor []byte
@@ -722,3 +722,61 @@ func TestDiagnoseFloatingPointNumber(t *testing.T) {
 		})
 	}
 }
+
+func TestDiagnoseCBORSequences(t *testing.T) {
+	testCases := []struct {
+		title       string
+		cbor        []byte
+		diag        string
+		opts        *DiagOptions
+		returnError bool
+	}{
+		{
+			"CBOR Sequences without CBORSequence option",
+			hexDecode("f93e0064494554464401020304"),
+			``,
+			&DiagOptions{
+				CBORSequence: false,
+			},
+			true,
+		},
+		{
+			"CBOR Sequences with CBORSequence option",
+			hexDecode("f93e0064494554464401020304"),
+			`1.5, "IETF", h'01020304'`,
+			&DiagOptions{
+				CBORSequence: true,
+			},
+			false,
+		},
+		{
+			"partial/incomplete CBOR Sequences",
+			hexDecode("f93e00644945544644010203"),
+			`1.5, "IETF"`,
+			&DiagOptions{
+				CBORSequence: true,
+			},
+			true,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.title, func(t *testing.T) {
+			dm, err := tc.opts.DiagMode()
+			if err != nil {
+				t.Errorf("DiagMode() for 0x%x returned error %q", tc.cbor, err)
+			}
+
+			str, err := dm.Diagnose(tc.cbor)
+			if tc.returnError && err == nil {
+				t.Errorf("Diagnose(0x%x) returned error %q", tc.cbor, err)
+			} else if !tc.returnError && err != nil {
+				t.Errorf("Diagnose(0x%x) returned error %q", tc.cbor, err)
+			}
+
+			if str != tc.diag {
+				t.Errorf("Diagnose(0x%x) returned `%s`, want %s", tc.cbor, str, tc.diag)
+			}
+		})
+	}
+}