Expected log entries

Author: trasher

tests/GaletteObjectsLend/Filters/tests/units/CategoriesList.php

@@ -72,6 +72,10 @@ public function testCreate(): void
 
         //not existing order, same kept
         $filters->setDirection('abcd');
+        $this->expectLogEntry(
+            \Analog::WARNING,
+            '[GaletteObjectsLend\Filters\CategoriesList|Pagination] "abcd" is not a valid backing value for enum Galette\Enums\SQLOrder'
+        );
         $this->assertSame(\GaletteObjectsLend\Repository\Categories::ORDERBY_ACTIVITY, $filters->orderby);
         $this->assertSame(\Galette\Enums\SQLOrder::DESC->value, $filters->getDirection());
 
@@ -94,6 +98,11 @@ public function testCreate(): void
 
         //out of known values, no change
         $filters->active_filter = 42;
+        $this->expectLogEntry(
+            \Analog::WARNING,
+            '[CategoriesList] Value for active filter should be either 0, 1 or 2 (42 given)
+'
+        );
         $this->assertSame(\GaletteObjectsLend\Repository\Categories::INACTIVE_CATEGORIES, $filters->active_filter);
 
         $ofilters = new \GaletteObjectsLend\Filters\ObjectsList();

tests/GaletteObjectsLend/Filters/tests/units/ObjectsList.php

@@ -75,6 +75,10 @@ public function testCreate(): void
         $filters->setDirection('abcde');
         $this->assertSame(\GaletteObjectsLend\Repository\Objects::ORDERBY_STATUS, $filters->orderby);
         $this->assertSame(\Galette\Enums\SQLOrder::DESC->value, $filters->getDirection());
+        $this->expectLogEntry(
+            \Analog::WARNING,
+            '[GaletteObjectsLend\Filters\ObjectsList|Pagination] "abcde" is not a valid backing value for enum Galette\Enums\SQLOrder'
+        );
 
         //change direction only
         $filters->setDirection(\Galette\Enums\SQLOrder::ASC);
@@ -89,25 +93,17 @@ public function testCreate(): void
         $filters->active_filter = \GaletteObjectsLend\Repository\Objects::INACTIVE_OBJECTS;
         $this->assertSame(\GaletteObjectsLend\Repository\Objects::INACTIVE_OBJECTS, $filters->active_filter);
 
-        //cast is forced
-        $filters->active_filter = (string) \GaletteObjectsLend\Repository\Objects::INACTIVE_OBJECTS;
-        $this->assertSame(\GaletteObjectsLend\Repository\Objects::INACTIVE_OBJECTS, $filters->active_filter);
-
         //out of known values, no change
         $filters->active_filter = 42;
+        $this->expectLogEntry(
+            \Analog::WARNING,
+            '[ObjectsList] Value for active filter should be either 1, 1 or 2 (42 given)'
+        );
         $this->assertSame(\GaletteObjectsLend\Repository\Objects::INACTIVE_OBJECTS, $filters->active_filter);
 
         $filters->field_filter = \GaletteObjectsLend\Repository\Objects::FILTER_SERIAL;
         $this->assertSame(\GaletteObjectsLend\Repository\Objects::FILTER_SERIAL, $filters->field_filter);
 
-        //cast is forced
-        $filters->field_filter = (string) \GaletteObjectsLend\Repository\Objects::FILTER_SERIAL;
-        $this->assertSame(\GaletteObjectsLend\Repository\Objects::FILTER_SERIAL, $filters->field_filter);
-
-        //non numeric value, no change
-        $filters->field_filter = 'abc';
-        $this->assertSame(\GaletteObjectsLend\Repository\Objects::FILTER_SERIAL, $filters->field_filter);
-
         //reinit and test defaults are back
         $filters->reinit();
         $this->testDefaults($filters);

tests/GaletteObjectsLend/Filters/tests/units/StatusList.php

@@ -71,6 +71,10 @@ public function testCreate(): void
 
         //not existing order, same kept
         $filters->setDirection('abcd');
+        $this->expectLogEntry(
+            \Analog::WARNING,
+            '[GaletteObjectsLend\Filters\StatusList|Pagination] "abcd" is not a valid backing value for enum Galette\Enums\SQLOrder'
+        );
         $this->assertSame(\GaletteObjectsLend\Repository\Status::ORDERBY_STOCK, $filters->orderby);
         $this->assertSame(\Galette\Enums\SQLOrder::DESC->value, $filters->getDirection());
 
@@ -87,12 +91,12 @@ public function testCreate(): void
         $filters->active_filter = \GaletteObjectsLend\Repository\Status::INACTIVE;
         $this->assertSame(\GaletteObjectsLend\Repository\Status::INACTIVE, $filters->active_filter);
 
-        //cast is forced
-        $filters->active_filter = \GaletteObjectsLend\Repository\Status::INACTIVE;
-        $this->assertSame(\GaletteObjectsLend\Repository\Status::INACTIVE, $filters->active_filter);
-
         //out of known values, no change
         $filters->active_filter = 42;
+        $this->expectLogEntry(
+            \Analog::WARNING,
+            '[StatusList] Value for active filter should be either 1 or 2 (42 given)'
+        );
         $this->assertSame(\GaletteObjectsLend\Repository\Status::INACTIVE, $filters->active_filter);
 
         //set stock filter
@@ -104,6 +108,10 @@ public function testCreate(): void
 
         //out of known values, no change
         $filters->stock_filter = 42;
+        $this->expectLogEntry(
+            \Analog::WARNING,
+            '[StatusList] Value for stock filter should be either 1, 2 or 0 (42 given)'
+        );
         $this->assertSame(\GaletteObjectsLend\Repository\Status::OUT_STOCK, $filters->stock_filter);
 
         //reinit and test defaults are back