Skip to content

fix(gatsby-plugin-sitemap): Removed redundant check for siteUrl#17683

Merged
wardpeet merged 1 commit intogatsbyjs:masterfrom
dhakerShivnarayan:patch-1
Sep 17, 2019
Merged

fix(gatsby-plugin-sitemap): Removed redundant check for siteUrl#17683
wardpeet merged 1 commit intogatsbyjs:masterfrom
dhakerShivnarayan:patch-1

Conversation

@dhakerShivnarayan
Copy link
Copy Markdown
Contributor

Description

Related Issues

@dhakerShivnarayan dhakerShivnarayan requested a review from a team September 17, 2019 06:20
@lannonbr lannonbr changed the title Removed redundant check for siteUrl fix(gatsby-plugin-sitemap): Removed redundant check for siteUrl Sep 17, 2019
Copy link
Copy Markdown
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code is always better. Thank you! 💯

@wardpeet wardpeet merged commit 1c4dc65 into gatsbyjs:master Sep 17, 2019
@gatsbot
Copy link
Copy Markdown

gatsbot bot commented Sep 17, 2019

Holy buckets, @dhakerShivnarayan — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@wardpeet
Copy link
Copy Markdown
Contributor

Published in gatsby-plugin-sitemap@2.2.13

LOLdevelopr pushed a commit to LOLdevelopr/gatsby-1 that referenced this pull request Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants