ipv6: fix a bug in ndisc_send_redirect

Li Wei · davem330 · commit 4d65a2465f6f · 2011-11-23T03:51:54.000-05:00
Release skb when transmit rate limit _not_ allow

Signed-off-by: Li Wei &lt;lw@cn.fujitsu.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
@@ -1571,7 +1571,7 @@ void ndisc_send_redirect(struct sk_buff *skb, struct neighbour *neigh,
 	}
 	if (!rt->rt6i_peer)
 		rt6_bind_peer(rt, 1);
-	if (inet_peer_xrlim_allow(rt->rt6i_peer, 1*HZ))
+	if (!inet_peer_xrlim_allow(rt->rt6i_peer, 1*HZ))
 		goto release;
 
 	if (dev->addr_len) {

Original file line number	Diff line number	Diff line change
`@@ -1571,7 +1571,7 @@ void ndisc_send_redirect(struct sk_buff skb, struct neighbour neigh,`
`1571`	`1571`	`}`
`1572`	`1572`	`if (!rt->rt6i_peer)`
`1573`	`1573`	`rt6_bind_peer(rt, 1);`
`1574`		`- if (inet_peer_xrlim_allow(rt->rt6i_peer, 1*HZ))`
	`1574`	`+ if (!inet_peer_xrlim_allow(rt->rt6i_peer, 1*HZ))`
`1575`	`1575`	`goto release;`
`1576`	`1576`
`1577`	`1577`	`if (dev->addr_len) {`