Skip to content

Close JDBC logwriter when class goes out of scope #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomas-sexenian merged 2 commits into from
Aug 15, 2023
Merged

Close JDBC logwriter when class goes out of scope #761

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d46f253
Close JDBC logwriter when class goes out of scope
Aug 15, 2023
85b7836
Merge branch 'master' into BrokenJDBCLog
tomas-sexenian Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions java/src/main/java/com/genexus/db/driver/GXDBDebug.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,17 +86,12 @@ public GXDBDebug(JDBCLogConfig cfg)
}
}
private PrintWriter createWriter(String filename) throws IOException {
BufferedWriter buffWriter = null;
try (Writer baseWriter = new FileWriter(fileName)){
if (cfg.buffered){
buffWriter = new BufferedWriter(baseWriter);
return new PrintWriter(buffWriter);
} else {
return new PrintWriter(baseWriter);
}
} finally {
if (buffWriter != null) buffWriter.close();
Writer baseWriter = new FileWriter(fileName);
if (cfg.buffered)
{
baseWriter = new BufferedWriter(baseWriter);

Check failure

Code scanning / Fortify on Demand

Unreleased Resource: Streams

The function createWriter() in GXDBDebug.java sometimes fails to release a system resource allocated by FileWriter() on line 89.The program can potentially fail to release a system resource.
}
return new PrintWriter(baseWriter);
}

public void closeLog()
Expand Down Expand Up @@ -249,4 +244,9 @@ public void close(int level)
}
}

@Override
protected void finalize() {
closeLog();
}

}