GXDebugStream was being closed instantly after creating it#785
Merged
Conversation
gusbro
commented
Oct 14, 2023
gusbro
commented
Contributor
- Fix issue 105285
- Improve performance (use BufferedOutputStream)
- Set executor policy to CallerRunsPolicy and shutdown executor upon application exit
- Fix corner case for escaping 0xFF. When the first 0xFF byte was produced by WriteScaledLong it was not accounted for.
Collaborator
Cherry pick to beta success |
gusbro
changed the title
iroqueta
reviewed
Oct 17, 2023
iroqueta
left a comment
iroqueta
left a comment
Collaborator
There was a problem hiding this comment.
import java.nio.channels.FileChannel; it's not necessary
Collaborator
Cherry pick to beta success |
Contributor
Author
removed |
iroqueta
approved these changes
Oct 17, 2023
gusbro
added a commit
that referenced
this pull request
Oct 18, 2023
* GXDebugStream was being closed too instantly after creating it * fix lint warnings (cherry picked from commit fbd9a0d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.