Skip to content

DFWPNum lost pressition when bigdecimals are used #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iroqueta merged 2 commits into from
Dec 1, 2023
Merged

DFWPNum lost pressition when bigdecimals are used #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b99938
DFWPNum lost pressition when bigdecimals are used
iroqueta Nov 17, 2023
9f71bc1
Merge branch 'master' into DecimalInDFWPNum
iroqueta Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/src/main/java/com/genexus/CommonUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2983,7 +2983,7 @@ public static String strNoRound(double value, int length, int decimals)
}


static String str(BigDecimal value, int length, int decimals, boolean round) {
public static String str(BigDecimal value, int length, int decimals, boolean round) {
if (length - 1 <= decimals)
{
// Esto es que hizo str(_, 2, 1) o str(_, 3, 2), todas cosas
Expand Down
4 changes: 3 additions & 1 deletion common/src/main/java/com/genexus/IDelimitedFilesSafe.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ public interface IDelimitedFilesSafe {
byte dfwopen(final String filename, String fdel, final String sdel, final int append, final String enc);

byte dfwnext();
byte dfwpnum(double num, int dec);
byte dfwpnum(long num, int dec);
byte dfwpnum(BigDecimal num, int dec);
byte dfwpnum(double num, int dec);
byte dfwptxt(String txt, int len);
byte dfwpdate(Date date, String fmt, String sep);
byte dfwclose();
Expand Down
17 changes: 16 additions & 1 deletion common/src/main/java/com/genexus/util/DelimitedFilesSafe.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,12 +756,27 @@ public byte dfwpnum(int num)
return 0;
}

public byte dfwpnum(long num, int dec)
{
return dfwpnum(new BigDecimal(num), dec);
}

public byte dfwpnum(BigDecimal num, int dec)
{
String doubnum = CommonUtil.ltrim(CommonUtil.str(num, 20 + dec, dec, true));
return dfwpnum(doubnum, dec);
}
public byte dfwpnum(double num, int dec)
{
String doubnum = CommonUtil.ltrim(CommonUtil.str(num, 20 + dec, dec));
return dfwpnum(doubnum, dec);
}

private byte dfwpnum(String doubnum, int dec)
{
byte retval = GX_ASCDEL_SUCCESS;
if (dfwopen_in_use)
{
String doubnum = CommonUtil.ltrim(CommonUtil.str(num, 20 + dec, dec));
int k = doubnum.indexOf(".");
if (dec == 0)
{
Expand Down