Drain entire download stream#830
Merged
Merged
Conversation
Issue: 107019
Collaborator
Cherry pick to beta success |
ggallotti
reviewed
Mar 6, 2024
added 2 commits
March 6, 2024 15:31
Collaborator
Cherry pick to beta success |
ggallotti
reviewed
Mar 18, 2024
| } catch (IOException ex) { | ||
| logger.error("Error while downloading file to the external provider", ex); | ||
| } finally { | ||
| try {objectData.close();} catch (IOException ioe) {logger.error("Error while draining the S3ObjectInputStream", ioe);} |
Member
There was a problem hiding this comment.
This will crash if objectData is null.
Ant the Finally should be in the LAST try.
ggallotti
reviewed
Mar 18, 2024
| } catch (IOException e) { | ||
| logger.error("Error while processing the input stream", e); | ||
| } finally { | ||
| objectData.close(); |
Member
There was a problem hiding this comment.
This is needed? You are inside a Try resource code. Thw clous will be done automatically.
added 2 commits
March 18, 2024 12:49
Collaborator
Cherry pick to beta success |
Collaborator
Cherry pick to beta success |
ggallotti
reviewed
Mar 18, 2024
| } catch (IOException ex) { | ||
| logger.error("Error while downloading file to the external provider", ex); | ||
| } finally { | ||
| try {objectData.close();} catch (IOException ioe) {logger.error("Error while draining the S3ObjectInputStream", ioe);} |
Member
There was a problem hiding this comment.
Sorry! The location of the catch was ok!
The missing was the IF condition. Now it's ok, bute you need to restore the finally position to the original place.
Collaborator
Cherry pick to beta success |
ggallotti
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: 107019