Skip to content

Add manual Otel instrumentation for Spans#837

Merged
sjuarezgx merged 4 commits into
masterfrom
Traces__ManualInstrumentation
Mar 18, 2024
Merged

Add manual Otel instrumentation for Spans#837
sjuarezgx merged 4 commits into
masterfrom
Traces__ManualInstrumentation

Conversation

@sjuarezgx

Copy link
Copy Markdown
Contributor

@genexusbot

Copy link
Copy Markdown
Collaborator
Cherry pick to beta failed, 1 conflicted file in commit 9da5ad1
  • pom.xml

@genexusbot

Copy link
Copy Markdown
Collaborator
Manual cherry pick to beta success

@sjuarezgx sjuarezgx requested a review from ggallotti March 14, 2024 09:48
Comment thread gxobservability/pom.xml Outdated
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-sdk-extension-autoconfigure</artifactId>
<version>1.23.0-alpha</version>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump to version 1.36?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread gxobservability/pom.xml
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-bom</artifactId>
<version>1.23.0</version>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump to version 1.36?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to the latest.

Comment thread gxobservability/pom.xml Outdated
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>8</source>
<target>8</target>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why target JDK8?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the JDK version.

@ggallotti ggallotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

Update io.opentelemetry libraries.
@genexusbot

Copy link
Copy Markdown
Collaborator
Cherry pick to beta success

@sjuarezgx sjuarezgx requested a review from ggallotti March 16, 2024 17:25
@sjuarezgx sjuarezgx merged commit 0106855 into master Mar 18, 2024
@sjuarezgx sjuarezgx deleted the Traces__ManualInstrumentation branch March 18, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants