Skip to content

issue204942/javascript_modules_support #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmendez merged 2 commits into from
Jun 24, 2025
Merged

issue204942/javascript_modules_support #975

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
566b63c
feature:Add type module for javascript tag
Jun 12, 2025
19c0863
Merge branch 'master' into issue204942/javascript_modules_support
claudiamurialdo Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions gxweb/src/main/java/com/genexus/internet/HttpAjaxContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,11 @@ public void ClearJavascriptSources() {
javascriptSources.clear();
}

public void AddJavascriptSource(String jsSrc, String urlBuildNumber, boolean userDefined, boolean isInlined)
public void AddJavascriptSource(String jsSrc, String urlBuildNumber, boolean userDefined, boolean isInlined) {
AddJavascriptSource( jsSrc, urlBuildNumber, userDefined, isInlined, false);
}

public void AddJavascriptSource(String jsSrc, String urlBuildNumber, boolean userDefined, boolean isInlined, boolean isModule)
{
if(!javascriptSources.contains(jsSrc))
{
Expand All @@ -686,7 +690,7 @@ public void AddJavascriptSource(String jsSrc, String urlBuildNumber, boolean use
queryString = "";
attributes = "data-gx-external-script";
}
String fragment = "<script type=\"text/javascript\" src=\"" + oldConvertURL(jsSrc) + queryString + "\" " + attributes + "></script>" ;
String fragment = "<script type=\"" + (isModule ? "module" : "text/javascript") + "\" src=\"" + oldConvertURL(jsSrc) + queryString + "\" " + attributes + "></script>" ;
if (isAjaxRequest() || isInlined || jsSrc == "jquery.js" || jsSrc == "gxcore.js")
{
writeTextNL(fragment);
Expand Down
Loading