Skip to content

Commit 714c78d

Browse files
raunofreibergnhunzaker
authored andcommitted
Fixtures nits (facebook#13375)
* fix: PropTypes failing in textarea fixtures * fix: Iframe title attribute in fixtures * Make description a optional prop in FixtureSet
1 parent a0190f8 commit 714c78d

File tree

10 files changed

+10
-9
lines changed

10 files changed

+10
-9
lines changed

fixtures/dom/src/components/FixtureSet.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const React = window.React;
33

44
const propTypes = {
55
title: PropTypes.node.isRequired,
6-
description: PropTypes.node.isRequired,
6+
description: PropTypes.node,
77
};
88

99
class FixtureSet extends React.Component {

fixtures/dom/src/components/Iframe.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ class IframePortal extends React.Component {
3232
return (
3333
<div>
3434
<iframe
35+
title="Iframe portal"
3536
style={{border: 'none', height: this.props.height}}
3637
ref={this.handleRef}
3738
/>

fixtures/dom/src/components/fixtures/buttons/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function onButtonClick() {
1010
export default class ButtonTestCases extends React.Component {
1111
render() {
1212
return (
13-
<FixtureSet title="Buttons" description="">
13+
<FixtureSet title="Buttons">
1414
<TestCase
1515
title="onClick with disabled buttons"
1616
description="The onClick event handler should not be invoked when clicking on a disabled buyaton">

fixtures/dom/src/components/fixtures/date-inputs/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const React = window.React;
88
class DateInputFixtures extends React.Component {
99
render() {
1010
return (
11-
<FixtureSet title="Dates" description="">
11+
<FixtureSet title="Dates">
1212
<TestCase title="Switching between date and datetime-local">
1313
<TestCase.Steps>
1414
<li>Type a date into the date picker</li>

fixtures/dom/src/components/fixtures/error-handling/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ class TriggerErrorAndCatch extends React.Component {
8787
export default class ErrorHandlingTestCases extends React.Component {
8888
render() {
8989
return (
90-
<FixtureSet title="Error handling" description="">
90+
<FixtureSet title="Error handling">
9191
<TestCase
9292
title="Break on uncaught exceptions"
9393
description="In DEV, errors should be treated as uncaught, even though React catches them internally">

fixtures/dom/src/components/fixtures/event-pooling/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const React = window.React;
77
class EventPooling extends React.Component {
88
render() {
99
return (
10-
<FixtureSet title="Event Pooling" description="">
10+
<FixtureSet title="Event Pooling">
1111
<MouseMove />
1212
<Persistence />
1313
</FixtureSet>

fixtures/dom/src/components/fixtures/media-events/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export default class MediaEvents extends React.Component {
6060
}, {});
6161

6262
return (
63-
<FixtureSet title="Media Events" description="">
63+
<FixtureSet title="Media Events">
6464
<TestCase
6565
title="Event bubbling"
6666
description="Media events should synthetically bubble">

fixtures/dom/src/components/fixtures/mouse-events/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const React = window.React;
66
class MouseEvents extends React.Component {
77
render() {
88
return (
9-
<FixtureSet title="Mouse Events" description="">
9+
<FixtureSet title="Mouse Events">
1010
<MouseMovement />
1111
</FixtureSet>
1212
);

fixtures/dom/src/components/fixtures/password-inputs/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const React = window.React;
66

77
function NumberInputs() {
88
return (
9-
<FixtureSet title="Password inputs" description="">
9+
<FixtureSet title="Password inputs">
1010
<TestCase
1111
title="The show password icon"
1212
description={`

fixtures/dom/src/components/fixtures/selects/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class SelectFixture extends React.Component {
4646

4747
render() {
4848
return (
49-
<FixtureSet title="Selects" description="">
49+
<FixtureSet title="Selects">
5050
<form className="field-group">
5151
<fieldset>
5252
<legend>Controlled</legend>

0 commit comments

Comments
 (0)