Fix loader in Houdini 18 as it returns 'long' instead of 'int'#479
Merged
Conversation
Contributor
|
Hi, we solved this issue few day ago with try except under import part. Like: and in displayText we add this check: |
Collaborator
Author
|
Seems like a similar fix. I'll merge this in a few days if there are no objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
It seems somehow the returned version number is not an
intin Houdini 18 but along. As such, the assertion in theVersionDelegatewould catch it incorrectly.This is now resolved by checking it against
numbers.Integralto ensure it's also Python 3+ proof wherelongno longer exists.