Skip to content

Highlight update fix 2#521

Merged
davidlatwe merged 3 commits into
getavalon:masterfrom
ynput:highlight_update_fix_2
Feb 3, 2020
Merged

Highlight update fix 2#521
davidlatwe merged 3 commits into
getavalon:masterfrom
ynput:highlight_update_fix_2

Conversation

@iLLiCiTiT
Copy link
Copy Markdown
Contributor

@iLLiCiTiT iLLiCiTiT commented Jan 30, 2020

Issue to solve:
Follow up previous PR #518

  • OptionMenu sometimes doesn't get mouseMoveEvent and is ignoring mouseEnterEvent, hence it the highlight of actions isn't triggered sometimes.

Suggestion:

  • added mouse tracking for label in OptionalActionWidget
  • OptionBox was changed from QWidget to QLabel since it's only child was QLabel

@iLLiCiTiT iLLiCiTiT mentioned this pull request Jan 30, 2020
Closed
davidlatwe
davidlatwe approved these changes Jan 31, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@davidlatwe davidlatwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up !
Can confirm this PR works in Maya, Houdini and Nuke :)
Will merge this tomorrow 🚀

@mkolar mkolar closed this Jan 31, 2020
@mkolar mkolar deleted the highlight_update_fix_2 branch January 31, 2020 21:26
@iLLiCiTiT iLLiCiTiT restored the highlight_update_fix_2 branch January 31, 2020 21:26
@davidlatwe davidlatwe reopened this Feb 1, 2020
@davidlatwe davidlatwe merged commit f74cc33 into getavalon:master Feb 3, 2020
@mkolar mkolar deleted the highlight_update_fix_2 branch March 15, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidlatwe davidlatwe davidlatwe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iLLiCiTiT @davidlatwe @mkolar