fix: unbound variable _group in reset/dc-detect-version script (#1283)

[lovetodream]

This would fix the reset script. [#1283 –ed.]

Because the dc-detect-version is only used in the reset script, I think it is fine to add the _group and _endgroup declarations directly.

[chadwhitacre]

ref #1283

[chadwhitacre]

Blech #1273. 😖

[lovetodream]

Blech #1273. 😖

I Just noticed that #1273 was closed. Does this mean that this can be merged?

[chadwhitacre]

Does this mean that this can be merged?

Almost. #1273 turned into #1289, which (it turns out) basically dupes #1290, which revives #1251, which we had to revert in #1272 because it effed up CI over in sentry. Kind of a tangle right now but I think we are making progress. 😁

Hopefully we can get back here soon ... 🤞

[chadwhitacre]

Still getting a garbled relay config. 🤔

https://github.com/getsentry/self-hosted/runs/5009812723?check_suite_focus=true#step:5:121

[chadwhitacre]

Still getting a garbled relay config.

lol sorry wrong PR! I thought the failure here was on #1289 😂 😭 Once we get that cleaned up and merged and rebase here we should be good ...

[aminvakil]

As #1315 has been merged, should this fix also reflect GCB too?

[chadwhitacre]

Yeah, we need to rebase/update.

[aminvakil]

@lovetodream I guess this can be merged if you rebase from master and run the tests again.

Thanks for fixing this!

[chadwhitacre]

/gcbrun

[aminvakil]

LGTM unless squashing commits is not an option and this should be rebased without a merge commit.

[chadwhitacre]

Hey it's green! 😁

[chadwhitacre]

Thanks for your patience @lovetodream. 🙏