From d08c5543b83ef81f666b5d00be10ba8015ab2262 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 5 Jun 2026 09:31:45 +0200 Subject: [PATCH 1/6] fix(attributes): Set `pii: 'maybe'` on `faas` string attribute --- model/attributes/faas/faas__name.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model/attributes/faas/faas__name.json b/model/attributes/faas/faas__name.json index f6cc5fab..085ab3cf 100644 --- a/model/attributes/faas/faas__name.json +++ b/model/attributes/faas/faas__name.json @@ -3,7 +3,7 @@ "brief": "The name of the serverless function", "type": "string", "pii": { - "key": "false" + "key": "maybe" }, "is_in_otel": true, "example": "my_function", From 8dcf4da8060f8dc39ea1cf8c1032ee36bcf82eef Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 5 Jun 2026 09:32:49 +0200 Subject: [PATCH 2/6] pr number --- model/attributes/faas/faas__name.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/model/attributes/faas/faas__name.json b/model/attributes/faas/faas__name.json index 085ab3cf..63feb278 100644 --- a/model/attributes/faas/faas__name.json +++ b/model/attributes/faas/faas__name.json @@ -10,7 +10,8 @@ "visibility": "public", "changelog": [ { - "version": "next" + "version": "next", + "prs": [403, 415] } ] } From 5856ad5c2619ee73c2df7cd43a6e49ac14dd989e Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 5 Jun 2026 09:41:28 +0200 Subject: [PATCH 3/6] generate --- javascript/sentry-conventions/src/attributes.ts | 6 +++--- python/src/sentry_conventions/attributes.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/javascript/sentry-conventions/src/attributes.ts b/javascript/sentry-conventions/src/attributes.ts index f48a6c26..8297efe1 100644 --- a/javascript/sentry-conventions/src/attributes.ts +++ b/javascript/sentry-conventions/src/attributes.ts @@ -4754,7 +4754,7 @@ export type FAAS_IDENTITY_TYPE = string; * * Attribute Value Type: `string` {@link FAAS_NAME_TYPE} * - * Contains PII: false + * Contains PII: maybe * * Attribute defined in OTEL: Yes * Visibility: public @@ -18251,12 +18251,12 @@ export const ATTRIBUTE_METADATA: Record = { brief: 'The name of the serverless function', type: 'string', pii: { - isPii: 'false', + isPii: 'maybe', }, isInOtel: true, visibility: 'public', example: 'my_function', - changelog: [{ version: 'next' }], + changelog: [{ version: 'next', prs: [403, 415] }], }, [FAAS_TIME]: { brief: 'A string containing the function invocation time in the ISO 8601 format expressed in UTC.', diff --git a/python/src/sentry_conventions/attributes.py b/python/src/sentry_conventions/attributes.py index ca5d29ab..6a0c06a3 100644 --- a/python/src/sentry_conventions/attributes.py +++ b/python/src/sentry_conventions/attributes.py @@ -2915,7 +2915,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta): """The name of the serverless function Type: str - Contains PII: false + Contains PII: maybe Defined in OTEL: Yes Visibility: public Example: "my_function" @@ -11355,12 +11355,12 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta): "faas.name": AttributeMetadata( brief="The name of the serverless function", type=AttributeType.STRING, - pii=PiiInfo(isPii=IsPii.FALSE), + pii=PiiInfo(isPii=IsPii.MAYBE), is_in_otel=True, visibility=Visibility.PUBLIC, example="my_function", changelog=[ - ChangelogEntry(version="next"), + ChangelogEntry(version="next", prs=[403, 415]), ], ), "faas.time": AttributeMetadata( From 9d65548f2e4d74e1de4891d9ad93aa119694c5bf Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 5 Jun 2026 09:42:02 +0200 Subject: [PATCH 4/6] default to `'maybe'` in create attribute CLI script --- scripts/create_attribute.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/create_attribute.ts b/scripts/create_attribute.ts index 8caa75b6..4a6d489a 100644 --- a/scripts/create_attribute.ts +++ b/scripts/create_attribute.ts @@ -273,10 +273,11 @@ async function askForAttributePii() { select({ message: 'Does the attribute contain PII?', options: [ + { value: 'maybe', label: 'Maybe' }, { value: 'true', label: 'Yes' }, { value: 'false', label: 'No' }, - { value: 'maybe', label: 'Maybe' }, ], + initialValue: 'maybe', }), ); } From be964607a03eb8824ba840c421bce47a354fd159 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 5 Jun 2026 09:45:21 +0200 Subject: [PATCH 5/6] entry point --- model/attributes/faas/faas__entry_point.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model/attributes/faas/faas__entry_point.json b/model/attributes/faas/faas__entry_point.json index 350286b0..9fdaa614 100644 --- a/model/attributes/faas/faas__entry_point.json +++ b/model/attributes/faas/faas__entry_point.json @@ -3,7 +3,7 @@ "brief": "The code that's run when the cloud provider invokes your function.", "type": "string", "pii": { - "key": "false" + "key": "maybe" }, "is_in_otel": false, "example": "my_main_function", From abda68e6d630fba87ce10781918fba12351c5c64 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 5 Jun 2026 09:45:44 +0200 Subject: [PATCH 6/6] regenerate --- javascript/sentry-conventions/src/attributes.ts | 4 ++-- python/src/sentry_conventions/attributes.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/javascript/sentry-conventions/src/attributes.ts b/javascript/sentry-conventions/src/attributes.ts index 8297efe1..e19ccc46 100644 --- a/javascript/sentry-conventions/src/attributes.ts +++ b/javascript/sentry-conventions/src/attributes.ts @@ -4712,7 +4712,7 @@ export type FAAS_DURATION_IN_MS_TYPE = number; * * Attribute Value Type: `string` {@link FAAS_ENTRY_POINT_TYPE} * - * Contains PII: false + * Contains PII: maybe * * Attribute defined in OTEL: No * Visibility: public @@ -18227,7 +18227,7 @@ export const ATTRIBUTE_METADATA: Record = { brief: "The code that's run when the cloud provider invokes your function.", type: 'string', pii: { - isPii: 'false', + isPii: 'maybe', }, isInOtel: false, visibility: 'public', diff --git a/python/src/sentry_conventions/attributes.py b/python/src/sentry_conventions/attributes.py index 6a0c06a3..45fc36fd 100644 --- a/python/src/sentry_conventions/attributes.py +++ b/python/src/sentry_conventions/attributes.py @@ -2893,7 +2893,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta): """The code that's run when the cloud provider invokes your function. Type: str - Contains PII: false + Contains PII: maybe Defined in OTEL: No Visibility: public Example: "my_main_function" @@ -11333,7 +11333,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta): "faas.entry_point": AttributeMetadata( brief="The code that's run when the cloud provider invokes your function.", type=AttributeType.STRING, - pii=PiiInfo(isPii=IsPii.FALSE), + pii=PiiInfo(isPii=IsPii.MAYBE), is_in_otel=False, visibility=Visibility.PUBLIC, example="my_main_function",