feat(angular): Add service worker guide for fixing invalid file hashes in ngsw#11494
Merged
Conversation
|
@lennybakkalian is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
lennybakkalian
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Lms24
reviewed
Oct 8, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Hey @lennybakkalian thanks again for opening this PR! The content is great, I'll just move it to the Angular specific source maps guide rather than making it appear in every JS-based guide. ngsw.json is rather Angular-specific after all :)
Lms24
changed the title
Lms24
changed the title
Lms24
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File hash mismatch in ngsw.json after injecting debugIds
After injecting debugIds into the build chunks, the file hashes in ngsw.json become invalid, preventing proper caching by the service worker. This issue requires regenerating ngsw.json after the debugIds are injected to restore correct caching functionality.
getsentry/sentry-javascript#13449 (comment)
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.