SentryMinidump: native crash report does not contain expected scope / context if a beforeSend function is supplied

[bowswung]

• Review the documentation: https://docs.sentry.io/platforms/javascript/electron/
• Search for existing issues: https://github.com/getsentry/sentry-electron/issues
• Use the latest release: https://github.com/getsentry/sentry-electron/releases
• Provide a link to the affected event from your Sentry account

Versions + Platform

• SDK version - @sentry/electron@v3.0.7
• Electron version - electron@v16.0.10
• Platform - Windows

Description

As in title - if you supply a beforeSend function then the default SentryMinidump integration will not correctly fill in the scope on the event when sending a crash report.

This may be intentional, but I couldn't find docs stating this. The problematic line is this one - https://github.com/getsentry/sentry-electron/blob/master/src/main/integrations/sentry-minidump/index.ts#L234

which instead of giving the beforeSend function the newEvent that has been filled with scope, it passes the original event.

Fixing should be trivially to pass newEvent to beforeSend (we have patched this in locally and it seems to be working in the way we expect).

[timfish]

Thank you for reporting, I'll take a look!