AWS Lambda layer build#3110
Merged
Merged
Conversation
The packages to upload to the AWS Lambda layer are zipped. This zip file is cached.
Created another workflow to build the AWS Lambda layer by running a script when changes something on @sentry/serverless
HazAT
requested changes
Dec 9, 2020
Member
HazAT
left a comment
HazAT
left a comment
There was a problem hiding this comment.
.github/workflows/awslambda-build.yml is cool but I is it uploading the artifacts as well?
The goal is that this zip is contained in the artifact bundle once Github actions finished building.
HazAT
requested changes
Dec 9, 2020
Removed the AWS Lambda workflow, and added the build to the main workflow. Also, included the generated zip file to the artifacts.
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
kamilogorek
reviewed
Dec 9, 2020
The publish functionality should not be here, deleted.
Referenced the docs. Also, updated `yarn.lock`.
Instead of setting a default value at the beginning of the function, so that the undefined is avoided, it's now set in the parameter.
Fixed the broken promise, and removed the `path-exists` dependency from `package.json`.
…y/sentry-javascript into serverless/awslambda-automation
Using the function available in the same node version. Also, removed some logs.
…y/sentry-javascript into serverless/awslambda-automation
Contributor
size-limit report
|
Be more specific in the initializer script and rename it to `awslambda-auto`.
HazAT
approved these changes
Dec 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When something changes in @sentry/serverless a new action is triggered to build a zip file with all necessary @sentry packages to upload to AWS Lambda.