From 655daa136aa146e28421117617af149442c9aa9d Mon Sep 17 00:00:00 2001 From: Francesco Gringl-Novy Date: Fri, 12 Jun 2026 10:45:09 +0200 Subject: [PATCH] ref: Remove unused SENTRY_BUILD_PRESERVE_MODULES env check from rollup configs The `SENTRY_BUILD_PRESERVE_MODULES` env var was never set anywhere in the codebase, so the `preserveModules` ternary always resolved to its default branch. Collapse it to the static default value in every rollup.npm.config.mjs. Co-Authored-By: Claude Opus 4.8 (1M context) --- packages/browser-utils/rollup.npm.config.mjs | 5 +---- packages/browser/rollup.npm.config.mjs | 5 +---- packages/core/rollup.npm.config.mjs | 5 +---- packages/feedback/rollup.npm.config.mjs | 5 +---- packages/opentelemetry/rollup.npm.config.mjs | 5 +---- packages/profiling-node/rollup.npm.config.mjs | 5 +---- packages/replay-canvas/rollup.npm.config.mjs | 5 +---- packages/replay-internal/rollup.npm.config.mjs | 5 +---- packages/server-utils/rollup.npm.config.mjs | 5 +---- 9 files changed, 9 insertions(+), 36 deletions(-) diff --git a/packages/browser-utils/rollup.npm.config.mjs b/packages/browser-utils/rollup.npm.config.mjs index d28a7a6f54a0..7416307b5bac 100644 --- a/packages/browser-utils/rollup.npm.config.mjs +++ b/packages/browser-utils/rollup.npm.config.mjs @@ -7,10 +7,7 @@ export default makeNPMConfigVariants( // set exports to 'named' or 'auto' so that rollup doesn't warn exports: 'named', // set preserveModules to true because we don't want to bundle everything into one file. - preserveModules: - process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined - ? true - : Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES), + preserveModules: true, }, }, }), diff --git a/packages/browser/rollup.npm.config.mjs b/packages/browser/rollup.npm.config.mjs index 40e3cbff5906..a9df26ae0bae 100644 --- a/packages/browser/rollup.npm.config.mjs +++ b/packages/browser/rollup.npm.config.mjs @@ -9,10 +9,7 @@ export default makeNPMConfigVariants( // set exports to 'named' or 'auto' so that rollup doesn't warn exports: 'named', // set preserveModules to true because we don't want to bundle everything into one file. - preserveModules: - process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined - ? true - : Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES), + preserveModules: true, }, }, }), diff --git a/packages/core/rollup.npm.config.mjs b/packages/core/rollup.npm.config.mjs index 610de17fadf3..47d28e630457 100644 --- a/packages/core/rollup.npm.config.mjs +++ b/packages/core/rollup.npm.config.mjs @@ -20,10 +20,7 @@ const settings = { // set exports to 'named' or 'auto' so that rollup doesn't warn exports: 'named', // set preserveModules to true because we don't want to bundle everything into one file. - preserveModules: - process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined - ? true - : Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES), + preserveModules: true, }, plugins: [ replace({ diff --git a/packages/feedback/rollup.npm.config.mjs b/packages/feedback/rollup.npm.config.mjs index 103eb72c68dc..03e8c739c9d6 100644 --- a/packages/feedback/rollup.npm.config.mjs +++ b/packages/feedback/rollup.npm.config.mjs @@ -9,10 +9,7 @@ export default makeNPMConfigVariants( exports: 'named', // set preserveModules to false because for feedback we actually want // to bundle everything into one file. - preserveModules: - process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined - ? false - : Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES), + preserveModules: false, }, }, esbuild: { diff --git a/packages/opentelemetry/rollup.npm.config.mjs b/packages/opentelemetry/rollup.npm.config.mjs index d0d33de1790f..593c4fe0e1a0 100644 --- a/packages/opentelemetry/rollup.npm.config.mjs +++ b/packages/opentelemetry/rollup.npm.config.mjs @@ -10,10 +10,7 @@ export default makeNPMConfigVariants( // set exports to 'named' or 'auto' so that rollup doesn't warn exports: 'named', // set preserveModules to false because we want to bundle everything into one file. - preserveModules: - process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined - ? false - : Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES), + preserveModules: false, }, }, }), diff --git a/packages/profiling-node/rollup.npm.config.mjs b/packages/profiling-node/rollup.npm.config.mjs index 80b26c2ac232..e5906080260f 100644 --- a/packages/profiling-node/rollup.npm.config.mjs +++ b/packages/profiling-node/rollup.npm.config.mjs @@ -9,10 +9,7 @@ export default makeNPMConfigVariants( exports: 'named', // set preserveModules to false because for profiling we actually want // to bundle everything into one file. - preserveModules: - process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined - ? false - : Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES), + preserveModules: false, }, }, }), diff --git a/packages/replay-canvas/rollup.npm.config.mjs b/packages/replay-canvas/rollup.npm.config.mjs index 3b4431fa6829..8c50a33f0afb 100644 --- a/packages/replay-canvas/rollup.npm.config.mjs +++ b/packages/replay-canvas/rollup.npm.config.mjs @@ -9,10 +9,7 @@ export default makeNPMConfigVariants( exports: 'named', // set preserveModules to false because for Replay we actually want // to bundle everything into one file. - preserveModules: - process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined - ? false - : Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES), + preserveModules: false, }, }, }), diff --git a/packages/replay-internal/rollup.npm.config.mjs b/packages/replay-internal/rollup.npm.config.mjs index f45b4f21b72b..4cf2b0263eac 100644 --- a/packages/replay-internal/rollup.npm.config.mjs +++ b/packages/replay-internal/rollup.npm.config.mjs @@ -11,10 +11,7 @@ export default makeNPMConfigVariants( exports: 'named', // set preserveModules to false because for Replay we actually want // to bundle everything into one file. - preserveModules: - process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined - ? false - : Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES), + preserveModules: false, }, }, }), diff --git a/packages/server-utils/rollup.npm.config.mjs b/packages/server-utils/rollup.npm.config.mjs index d28a7a6f54a0..7416307b5bac 100644 --- a/packages/server-utils/rollup.npm.config.mjs +++ b/packages/server-utils/rollup.npm.config.mjs @@ -7,10 +7,7 @@ export default makeNPMConfigVariants( // set exports to 'named' or 'auto' so that rollup doesn't warn exports: 'named', // set preserveModules to true because we don't want to bundle everything into one file. - preserveModules: - process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined - ? true - : Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES), + preserveModules: true, }, }, }),